[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/108 I agree this should configurable on the Host. It should be possible to remove the Comparator entirely if the version code is used directly in the Mapper. I'd like this to be more robust. I'm

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/108 I'm starting to lean toward requiring this new feature to require a configuration option to enable it, and have it default to `false`. My justification is that it represents a breaking beh

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 @markt-asf I’m sorry to nag you about this, but I didn’t get any feedback since my improvements on this patch series. --- -

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 I added support for version suffixes and rebased this on `trunk`. Maybe you want to have another look. --- - To unsubscribe, e-m

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 I added another bunch of patches. One of them implementing a different approach to a cached version representation based on @ChristopherSchultz’s suggestion. Instead of creating zero-padded string

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/108 I think there is a lot of merit in Chris's idea. The concept of some sort of internal pre-computed version string that addresses ordering concerns by zero padding numerical components is one that w

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 @markt-asf @ChristopherSchultz Thanks for your feedback so far and for the partial merge. To be honest I didn’t think about any performance implications or side effects because I didn’

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/108 The performance of this strategy can be significantly improved by converting the "version number" into a value that can more easily be compared against other values. This can be done in se

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/108 I have applied the optimisation commit (thanks) but not the ordering changes. The patch changes the order for undeploy without changing the order for version mapping. This will lead to une