[Bug 69659] Automatic JSP EL optimization

2025-05-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #9 from John Engebretson --- Yep, we can easily detect it from Generator.java via something like: if (!"true".equals(ctxt.getOptions().getJspConfig().getErrorOnELNotFound()) { And I have a String-based implementation that operates

[Bug 69659] Automatic JSP EL optimization

2025-04-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #8 from John Engebretson --- Gotcha, thanks - in #1 equivalence can be explicitly changed, and in #2 we could interfere with side effects that a particular application added. More cases may follow, but as you noted, they would like

[Bug 69659] Automatic JSP EL optimization

2025-04-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #7 from Mark Thomas --- It isn't always true but the cases where it isn't true may be detectable and/or rare enough that it is still worth doing. I think the cases are 1. errorOnELNotFound page directive set to true 2. A custom EL

[Bug 69659] Automatic JSP EL optimization

2025-04-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #6 from John Engebretson --- Thanks Mark! I didn't follow all of that, but is there a case where this: ${not empty bean && not empty bean.property} cannot safely be translated to: ${not empty bean.property} for literally every

[Bug 69659] Automatic JSP EL optimization

2025-04-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #5 from Mark Thomas --- Tx. That helps. I've obviously been spending too much time with the Jakarta EL spec. Pure EL will throw exceptions for those. I'd forgotten about the null handling implemented in Jakarta Pages. The challenge

[Bug 69659] Automatic JSP EL optimization

2025-04-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #4 from John Engebretson --- Created attachment 40030 --> https://bz.apache.org/bugzilla/attachment.cgi?id=40030&action=edit Unit test demonstrating current null behavior Certainly - demonstration JSP attached. -- You are recei

[Bug 69659] Automatic JSP EL optimization

2025-04-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #3 from Mark Thomas --- That null handling behaviour isn't what I'd expect. I'd expect some exceptions. Can you create a simple JSP that demonstrates the null handling you are seeing? -- You are receiving this mail because: You a

[Bug 69659] Automatic JSP EL optimization

2025-04-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #2 from John Engebretson --- Thanks Christopher! Very helpful. > How much mileage could you get out of a simple regex-style replacement that > looks for very specific things like this? I would get excellent mileage, although I'm

[Bug 69659] Automatic JSP EL optimization

2025-04-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69659 --- Comment #1 from Christopher Schultz --- An optimizing compiler won't add much because it can't really prove those things are true unless we teach it, which is probably not worth it. Even the JIT probably isn't able to figure out that it's d