https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REOPENED
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #11 from Mark Thomas ---
My analysis agrees with Chris's. There might be a re-hash during start-up that
multiplying by 4/3 would address although the impact of that is going to be
pretty minimal. The runtime impact is going to be ze
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #10 from John Engebretson ---
I agree, no per-request impact.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail:
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #9 from Christopher Schultz ---
Which operation are we trying to optimize, here? Is it startup-time of the JSP
when it's first put into service?
If so, simply multiplying the import count by a constant should create enough
initial
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #8 from John Engebretson ---
This is an interesting callout, thanks - I assumed that
`HashMap`/`LinkedHashMap` viewed initialCapacity as the number of entries to
hold, and calculated the array size separately using initialCapacity a
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
Mark Thomas changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #6 from Dan Armstrong ---
I don't know if I can edit previous comment. Probably just "0.75" instead of
"0.75f" to avoid float to double conversion before call to Math.ceil
--
You are receiving this mail because:
You are the assig
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #5 from Dan Armstrong ---
The initial sizing to LinkedHashSet is not factoring-in the load factor (0.75
by default), thus resulting in some unnecessary re-hashing.
https://github.com/apache/tomcat/blob/b58963db1384ac286774a0d894a4
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #4 from John Engebretson ---
This changed reached prod and had the (small) expected impact. Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
Remy Maucherat changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #2 from Remy Maucherat ---
Ok, this sounds reasonable looking at the code.
https://github.com/apache/tomcat/blob/main/java/org/apache/jasper/compiler/Generator.java#L623
--
You are receiving this mail because:
You are the assignee
https://bz.apache.org/bugzilla/show_bug.cgi?id=68546
--- Comment #1 from John Engebretson ---
Sorry, error with the numbering in the last sentence: the attached speed test
shows a big improvement with #1 (right-sizing) but a greater improvement from
either #2 or #3.
--
You are receiving this ma
12 matches
Mail list logo
