[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 Michael Osipov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GitHub] [tomcat-native] asfgit merged pull request #19: Bug 66666: Remove non-reachable functions from ssl.c

2023-06-29 Thread via GitHub
asfgit merged PR #19: URL: https://github.com/apache/tomcat-native/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache

[tomcat-native] branch main updated: Bug 66666: Remove non-reachable functions from ssl.c

2023-06-29 Thread michaelo
functions from ssl.c 2e865ff87 is described below commit 2e865ff8788b3c738170713771ba5a2ec0e2e364 Author: Michael Osipov AuthorDate: Fri Jun 23 11:09:58 2023 +0200 Bug 6: Remove non-reachable functions from ssl.c --- native/include/ssl_private.h | 1 - native/src/ssl.c

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 --- Comment #8 from Michael Osipov --- PR provided. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat

[GitHub] [tomcat-native] michael-o opened a new pull request, #19: Bug 66666: Remove non-reachable functions from ssl.c

2023-06-23 Thread via GitHub
michael-o opened a new pull request, #19: URL: https://github.com/apache/tomcat-native/pull/19 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 Michael Osipov changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Michael Osipo

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 --- Comment #6 from Michael Osipov --- (In reply to Mark Thomas from comment #5) > I can't see any reason I kept those other than oversight. No objections to > removal in 2.0.x. Great, will work on a PR. -- You are receiving this mail becaus

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 --- Comment #5 from Mark Thomas --- I can't see any reason I kept those other than oversight. No objections to removal in 2.0.x. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 --- Comment #4 from Mark Thomas --- Let me check and see if there is a reason I didn't remove this code or if I just missed it. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 --- Comment #3 from Michael Osipov --- (In reply to Christopher Schultz from comment #2) > We have been hesitant to remove things from tcnative even if they are not > used by the Java components. > > Some (unspecified) downstream users may be

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 Christopher Schultz changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Chr

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 --- Comment #1 from Michael Osipov --- As far as I can see, when setPasswordCallback() is gone typedef struct { charpassword[SSL_MAX_PASSWORD_LEN]; const char *prompt; tcn_callback_t cb; } tcn_pass_cb_t; can be red

[Bug 66666] Remove non-reachable functions from ssl.c

2023-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=6 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are recei