https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #14 from Mark Thomas ---
It has been more than a month and the requested information to enable the issue
to be recreated has not been provided.
Without the information to reproduce the issue, this bug report will eventually
be reso
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
Mark Thomas changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #13 from Mark Thoma
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #12 from Mark Thomas ---
Note that cache validation needs to be per URI (and not per JAR) to account for
various use cases where web application resources are changed while a web
application is running and those resources overlap wi
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #11 from Joe Jackson ---
Hey Christopher,
Sorry for the delay in getting back to you. I haven't been able to create a
demo application, but basically, you would just need a high number of jars and
then call StandardRoot.getResource
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #10 from Christopher Schultz ---
Upon further review, I wonder if the difference is that you have removed the
use of String.substring() in a few locations, instead appending slices of the
source Strings.
--
You are receiving this
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #9 from Christopher Schultz ---
I still don't see the savings in the code, but I do see the difference in your
metrics. We can only see the output, though. What kind of "load" are you
putting on this? Technically, you could get that
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #8 from Joe Jackson ---
I've added the screenshots showing JFR profiling data before and after the
patch. The StringBuilder does still generate garbage, but it's reduced by about
3x - 4x. Mainly because there is less need to create
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #7 from Joe Jackson ---
Created attachment 38349
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38349&action=edit
before fix
--
You are receiving this mail because:
You are the assignee for the bug.
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #6 from Joe Jackson ---
Created attachment 38348
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38348&action=edit
after fix
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #5 from Christopher Schultz ---
(In reply to Joe Jackson from comment #4)
> For my use case, we have a big focus on the garbage generation of
> the app and this showed up as a contributor so I figured it would be worth
> bringing up
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #4 from Joe Jackson ---
Thanks for the quick feedback. I was also concerned about the readability
trade-off. For my use case, we have a big focus on the garbage generation of
the app and this showed up as a contributor so I figured
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
--- Comment #3 from Konstantin Kolinko ---
1. What version of Java have you tested with? (And what version of Tomcat?)
String handling rather differs between versions of JRE.
2. I spotted one bug within the patch (attachment 38343). Maybe th
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178
Christopher Schultz changed:
What|Removed |Added
Summary|Garbage from strings in |Reduce garbage from strings
14 matches
Mail list logo
