[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-05-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 --- Comment #7 from Mark Thomas --- I've committed a fix for 10.1.x. I'll give folks a chance to review it before I think about back-porting it. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 --- Comment #6 from Mark Thomas --- Interesting. I expanded the current upgrade with request body tests to use GET and POST and they still passed. Switching to a Reader triggered the issue because that triggers a call to available() and - as R

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 --- Comment #5 from Remy Maucherat --- It doesn't work because, although a SavedRequestInputFilter is set using setInputBuffer on the Request, the available() method uses an action to check the internal buffer, which now goes to the new process

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 --- Comment #4 from Remy Maucherat --- Ok, the spec is not as clear as I would expect. OTOH, upgrading is optional, and this has some resource use and could make some legitimate POSTs to fail (if they are over maxSavePostSize). Is it really wo

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 --- Comment #3 from Mark Thomas --- My reading of RFC 7230 is that when using upgrade the entire request is sent via HTTP/1.1, the upgrade happens and then the response is returned via the upgraded protocol. This is going to require buffering

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 --- Comment #2 from bclozel --- Also, see https://bz.apache.org/bugzilla/show_bug.cgi?id=65726 which fixed a similar issue in the past. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66023] Getting requestbody as inputstream fails when upgrading to h2c

2022-04-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66023 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Mauchera