https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #11 from Michael Orr ---
Done. Pull request has been updated. Let me know if there's anything I've
missed.
--
You are receiving this mail because:
You are the assignee for the bug.
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #10 from Mark Thomas ---
Thanks for the offer of an updated patch.
Lets go with HttpServletRequest.getServerName() returning an empty string in
this case as that is consistent with the Host header that was sent.
--
You are receiv
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #9 from Michael Orr ---
Good question.
Let me know how you want to proceed, and I'll add tests and code accordingly.
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #8 from Mark Thomas ---
Patch looks good - thanks for including the tests.
My main thought at this point is what should HttpServletRequest.getServerName()
return? My reading of the Javadoc is if the Host header is present, its valu
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #7 from Mark Thomas ---
Thanks. Looking at this now.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsub
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #6 from Michael Orr ---
I managed to find time after all! Here's the pull request:
https://github.com/apache/tomcat/pull/124
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #5 from Mark Thomas ---
OK. The other open issues are looking to be trickier than expected so we have a
little more time than I first thought. I'll leave this until last to give you
as much time as possible.
--
You are receiving t
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #4 from Michael Orr ---
Hi Mark, it won't happen this week. Possibly by the end of next week.
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #3 from Mark Thomas ---
Is there an ETA on your fix? We have reached the start of the month and I
expect we'll want to tag a new version with this fix included in the next few
days.
--
You are receiving this mail because:
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #2 from Mark Thomas ---
Please go ahead.
We typically (and this is a typical case) fix the issue in trunk first and then
back-port. My initial impression is that this is a fairly simple fix. Don't
forget to check/add/update the uni
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
--- Comment #1 from Michael Orr ---
I should add that I'm happy to investigate a fix for this, assuming there are
no objections to the proposed change.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739
Michael Orr changed:
What|Removed |Added
CC||michaelomich...@gmail.com
--
You are re
13 matches
Mail list logo
