[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #11 from Remy Maucherat --- https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/startup/ContextConfig.java#L1339 -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #10 from Christopher Schultz --- (In reply to Slava Risenberg from comment #8) > (In reply to Remy Maucherat from comment #6) > > I'd rather add an IAE to ContainerBase.setName. > > ContainerBase is an abstract class, making change

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #9 from Remy Maucherat --- For starters, wrapper = servlet so that should be ok. Then containers are supposed to have names in Catalina (they go in children maps keyed by name ...), so it's good to do it that way. -- You are recei

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #8 from Slava Risenberg --- (In reply to Remy Maucherat from comment #6) > I'd rather add an IAE to ContainerBase.setName. ContainerBase is an abstract class, making change in it will affect other irrelevant Classes like StandardCo

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #6 from Remy Maucherat --- I'd rather add an IAE to ContainerBase.setName. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscr

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #5 from Slava Risenberg --- (In reply to Coty Sutherland from comment #0) > When using a web.xml that specifies a servlet element, but excludes > servlet-name a NPE is observed and the webapp fails to deploy. A check > should be add

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #4 from Slava Risenberg --- There are two issues to consider: 1. Don't think that enabling XML validation rapidly against DTD is a good idea, Tomcat has a large user base and I assume that a lot of users have broken/invalid web.xml

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #3 from Christopher Schultz --- How is it annoying? Just set "setSchema(schema); setValidating(false);". It's only going to validate once per context-launch, so this isn't a performance problem. Validating XML documents against t

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #2 from Remy Maucherat --- XML validation is annoying IMO, having checks for functionally significant items can be useful (also, the issue here might exist with embedded or some other use maybe ?). -- You are receiving this mail b

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 --- Comment #1 from Christopher Schultz --- The XML schema *requires the servlet-name element. (Note that the servlet-class element is not required.) Tomcat simply doesn't use the schema to validate web.xml, so this "error" falls through the cr

[Bug 62090] NPE in o.a.t.util.modeler.Util when servlet-name does not exist in web.xml

2018-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62090 Coty Sutherland changed: What|Removed |Added Keywords||Beginner -- You are receiving this