[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 --- Comment #7 from Coty Sutherland --- Actually using "caught" was the wrong word. I prevented the NPE by checking the certificate a bit earlier in the stack and threw a FNFE (where a warn was previously logged) up to the Connector init. Take

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 --- Comment #6 from Christopher Schultz --- Catching NPE/FNFE is pretty ugly. Is there a better way to do it? I'd prefer to pro-actively validate the configuration and tell the user something is wrong than catch these exceptions. -- You are r

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 Coty Sutherland changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 --- Comment #4 from Coty Sutherland --- (In reply to Mark Thomas from comment #3) > We should check that the behaviour is consistent for: > - no keystore or PEM file specified This behaves the same as the bugzilla description (throws an NPE).

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 --- Comment #3 from Mark Thomas --- No good reason I can recall. We should check that the behaviour is consistent for: - no keystore or PEM file specified - keystore specified but file does not exist - PEM file specified but file doe snot exis

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 --- Comment #2 from Coty Sutherland --- (In reply to Remy Maucherat from comment #1) > Should we catch this sort of configuration as an error even in cases where > it would kind of work ? Like if there are SSL config bits on the Connector > ele

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032 --- Comment #1 from Remy Maucherat --- Should we catch this sort of configuration as an error even in cases where it would kind of work ? Like if there are SSL config bits on the Connector element *and* one or more SSLHostConfig elements, then