https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #17 from Mark Thomas ---
Review comments fixed.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr.
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #16 from Konstantin Kolinko ---
Thank you.
Minor things
1. JMX
2. As Servlet Specification javadoc [1] explicitly says "servlet container must
convert the relative URL to an absolute URL before sending the response to the
client"
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #14 from Mark Thomas ---
I can get Tomcat to send a suitable relative redirect for directories but not
context roots. I don't see a way around this. Any relative redirect from from
/foo to /foo/ is going to have to have 'foo/' in it
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #13 from Mark Thomas ---
It appears that ProxyPassReverse only rewrites absolute URLs. That will be a
problem for redirects of the form /some/path
Tomcat generates redirects like this in a few places and we can fix those but
it doe
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
Konstantin Kolinko changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #11 from Ajay Sindwani ---
@Mark Thomas
Logically since 7/8 backports, existing app servers, will receive your patch
through minor upgrades, the defaults should maintain the existing behavior to
prevent wasted labor and troubleshoo
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #10 from Mark Thomas ---
I haven't found a client that doesn't support it yet. I did find one reference
for curl [1] that suggests back then all browsers supported various forms of
relative redirects.
[1] http://daniel.haxx.se/blog
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #9 from Mark Thomas ---
The complexity is to ensure that the session ID only gets added if the redirect
is to a location within the current web application.
In nearly all cases it will get skipped anyway since the session will have
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #8 from Remy Maucherat ---
Not really related, the processing for session id encoding in the URL
(encodeRedirectURL and encodeURL) is extraordinarily complex and expensive. I
don't remember why it looks like that.
--
You are recei
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #7 from Remy Maucherat ---
I verified the behavior with a telnet. If it is known all clients are
compatible, then it should be fine. I read in the original description "many
modern browsers support 302s to relative Locations", so wh
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #5 from Remy Maucherat ---
Similar to 58660, I think the behavior change may not be such a good idea. It
could be done in 9, but not elsewhere by default.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #4 from Mark Thomas ---
Good news. RFC2616 has been obsoleted by RFC7231 and friends. RFC7231 allows
redirects to be relative. This looks like it could turn into my favourite type
of bug report - one I can fix by deleting code :)
-
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #3 from Christopher Schultz ---
(In reply to Ajay Sindwani from comment #2)
> Both the servlet spec and Tomcat need to be updated then. Tomcat doesn't
> have to wait for the servlet spec, unless the update is already accepted.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #2 from Ajay Sindwani ---
Both the servlet spec and Tomcat need to be updated then. Tomcat doesn't have
to wait for the servlet spec, unless the update is already accepted.
The expense of doing 302 rewriting can be cleaned fro
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #1 from Mark Thomas ---
This would be contrary to the requirements of the Servlet specification.
See https://java.net/jira/browse/SERVLET_SPEC-100 for the request to change
that (and some other stuff).
--
You are receiving th
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917
Chuck Caldarale changed:
What|Removed |Added
Severity|normal |enhancement
--
You are receivin
18 matches
Mail list logo
