https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
Rainer Jung changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #7 from Rainer Jung ---
Chris: any chance you've got the updated patch lying around somewhere? Or can
do it during the next few days?
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #6 from Christopher Schultz ---
(In reply to Konstantin Kolinko from comment #5)
> First, the above code has an error. The IPv4 address part can be longer by 4
> decimal digits than the one written above.
Aah, yes. Thanks for p
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #5 from Konstantin Kolinko ---
(In reply to Christopher Schultz from comment #4)
> That's only 97 bytes plus a NULL-terminator. Where did you get the 39 from?
39 is the size of IPv6 address in the form used in your example. You
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #4 from Christopher Schultz ---
(In reply to Konstantin Kolinko from comment #3)
> (In reply to Christopher Schultz from comment #2)
> > Created attachment 31557 [details]
> > Proposed patch (against mod_jk/trunk)
> >
> > I hav
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #3 from Konstantin Kolinko ---
(In reply to Christopher Schultz from comment #2)
> Created attachment 31557 [details]
> Proposed patch (against mod_jk/trunk)
>
> I have raised the size of buf from 64 to 100 characters. The mess
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #2 from Christopher Schultz ---
Created attachment 31557
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31557&action=edit
Proposed patch (against mod_jk/trunk)
I have raised the size of buf from 64 to 100 characters
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #1 from Christopher Schultz ---
Agreed.
The use of 'buf' when passed-into inet_ntop4|6 inside jk_dump_sinfo is also not
sane: the final argument should be the length of the buffer available. It is
blindly set to 16 (for IPv4) o