https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
Rainer Jung changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #14 from Rainer Jung ---
Fixed in 1583726.
Will be part of version 1.2.40.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To uns
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #13 from Rainer Jung ---
A more minimalistic patch would be (untested yet):
Index: common/jk_map.c
===
--- common/jk_map.c (revision 1583423)
+++ common/jk_map
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #12 from Christopher Schultz ---
Konstantin,
Yeah, sorry about the tabs. I used vi in stupid-mode. I'll get close cleaned-up
before a commit.
As for the stncpy, I was originally thinking that an int couldn't be longer
than a f
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #11 from Konstantin Kolinko ---
(In reply to Christopher Schultz from comment #10)
Looks good.
Some style comments
1. Beware tabs. This line is formatted oddly because it has a tab character:
> + lastchar = buf + len -
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #10 from Christopher Schultz ---
I have verified that this patch works under both Linux and OS X Mavericks. I'll
commit shortly.
Index: native/common/jk_map.c
===
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #9 from Christopher Schultz ---
(In reply to Susan Burgee from comment #8)
> (In reply to sandy from comment #0)
> > Apple appears to have made strcpy() enforce that the src and dest buffers
> > may not overlap. As a result jk_m
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #8 from Susan Burgee ---
(In reply to sandy from comment #0)
> Apple appears to have made strcpy() enforce that the src and dest buffers
> may not overlap. As a result jk_map_get_int() may fail on the line
> strcpy(but, rc); as
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #7 from sa...@clickshare.com ---
This is the reductive case when m && name returns false in jk_map_get_string()
#include
#include
int main(int argc, const char * argv[])
{
char buf[50] = "Hello, world";
const char *r
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #6 from sa...@clickshare.com ---
Yes, this problem is new with Mavericks (10.9). It was working fine on 10.8
I will try to create you a test case... Unfortunately, It has been about 25
years since I did any C memory management -
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #5 from Christopher Schultz ---
strcpy(buf1, buf1) also does not fail.
$ cc --version
Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn)
Target: x86_64-apple-darwin12.5.0
Thread model: posix
Hmm... did you just upg
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #4 from Christopher Schultz ---
So, SIGABRT?
I'm trying to reproduce in a test-case, but this doesn't seem to work:
#include
#include
int main(int argc, char *argv[]) {
char *a = "Hello, world!";
char buf1[50];
strcp
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
Christopher Schultz changed:
What|Removed |Added
OS||All
--
You are receiving th
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
sa...@clickshare.com changed:
What|Removed |Added
OS|All |Mac OS X 10.9
--- Comment #3
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
--- Comment #2 from Christopher Schultz ---
Honestly, I'm not even sure why the code is written this way.
char buf[];
sprintf(buf, "%d", default_value);
char *rc = jk_map_get_string(m, name, buf);
size_t len = strlen(rc);
if(len)
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
Peter Aarestad changed:
What|Removed |Added
CC||aares...@gmail.com
--
You are re
https://issues.apache.org/bugzilla/show_bug.cgi?id=55696
Christopher Schultz changed:
What|Removed |Added
OS||All
--- Comment #1 from Chri
17 matches
Mail list logo
