[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #6 from Jeremy Boynes --- How does this interact with annotation scanning and ServletContainerInitializers? For example, a transformer could add or remove annotations or class dependencies (e.g. adding new interfaces) that rela

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #5 from Jeremy Boynes --- I have reservations around the security consequences of providing anything that has access to the webapp classloader the ability to modify any code defined by that classloader. Currently, that has to

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #4 from Nick Williams --- First, here's the companion Spring Framework enhancement request: https://jira.springsource.org/browse/SPR-10788 /I/ don't need to extend WebappClassLoader. I plan on simply adding to the existing Weba

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #3 from Rainer Jung --- Sorry, me again: if we want to support it in an agent free way, it seems it woul suffice to add a addTransformer() (or probably better registerTransformer() and unregisterTranformer()) call to the WebappC

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #2 from Rainer Jung --- Why would one need to extend the webapp class loader? A quick look to java.lang.instrument indicates that one should be able to do it with a normal instrumentation agent. Can you clarify? The registered

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #1 from Mark Thomas --- I have no objections in principle but obviously I'd want to see the proposed patch first. I will say that someone from the Spring project will need to confirm that any proposed patch is a) correct and b)