[Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-06-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 Brian Burch changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-04-01 Thread Mark Thomas
On 31/03/2013 10:27, Brian Burch wrote: On 22/03/13 01:11, Brian Burch wrote: I'll keep this enhancement open until I've had time to think properly... although your new Basic "parser" has returned to BasicAuthenticator, there might still be some merit in moving it to HttpParser and keeping my p

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-31 Thread Brian Burch
On 22/03/13 01:11, Brian Burch wrote: I'll keep this enhancement open until I've had time to think properly... although your new Basic "parser" has returned to BasicAuthenticator, there might still be some merit in moving it to HttpParser and keeping my proposed test suite, especially now you ha

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-21 Thread Brian Burch
On 21/03/13 09:33, Julian Reschke wrote: On 2013-03-21 10:15, Mark Thomas wrote: ... I'm sorry you feel that your efforts have been wasted. My intention was to get you a robust Base64 implementation to work with for the other improvements you had in mind for BASIC auth. If there are other improv

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-21 Thread Brian Burch
On 21/03/13 09:15, Mark Thomas wrote: On 21/03/2013 07:56, Brian Burch wrote: On 20/03/13 10:17, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 Sorry I could not reply more quickly, Mark, but I am currently in Australia and I am probably asleep while you a

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-21 Thread Julian Reschke
On 2013-03-21 10:15, Mark Thomas wrote: ... I'm sorry you feel that your efforts have been wasted. My intention was to get you a robust Base64 implementation to work with for the other improvements you had in mind for BASIC auth. If there are other improvements you have in mind for BASIC auth the

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-21 Thread Mark Thomas
On 21/03/2013 07:56, Brian Burch wrote: > On 20/03/13 10:17, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 > > Sorry I could not reply more quickly, Mark, but I am currently in > Australia and I am probably asleep while you are working. Not a problem. One

[Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 --- Comment #3 from Julian Reschke --- You may want to have a look at the the cases at: http://greenbytes.de/tech/tc/httpauth/ -- You are receiving this mail because: You are the assignee for the bug. ---

Re: [Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-21 Thread Brian Burch
On 20/03/13 10:17, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 Sorry I could not reply more quickly, Mark, but I am currently in Australia and I am probably asleep while you are working. Judging by the flurry of activity in this area, I conclude my cha

[Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 --- Comment #2 from Mark Thomas --- I've done some additional testing. On a warmed up system the JRE and Tomcat Base64 decoding implementations are comparable. Tomcat does warm up faster. Without warm up on 100 iterations (different in

[Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 --- Comment #1 from Mark Thomas --- Regarding your points: 1. Clarity vs efficiency is always a trade off. It depends how much efficiency has been lost. Do you have any performance numbers? 2. I don't see a test case either. I'd rather ge