[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #14 from Nick Williams --- Excellent! That works for me. It's hard to find a lot of this information on Google these days, especially since so much of it is password-hidden. I see what you did, though. You created that bug a fe

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #13 from Mark Thomas --- (In reply to comment #12) > Mark, this is what the API docs say about changeSessionId(): > > [quote] > Change the session id of the current session associated with this request > and return the new sess

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #12 from Nick Williams --- Mark, this is what the API docs say about changeSessionId(): [quote] Change the session id of the current session associated with this request and return the new session id. Returns: the original ses

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 Nick Williams changed: What|Removed |Added Attachment #29941|0 |1 is obsolete|

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 Nick Williams changed: What|Removed |Added Attachment #29943|Revised diff with extra |Revised diff with extra des

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #10 from Nick Williams --- Created attachment 29943 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29943&action=edit Revised diff with extra whitespace removed I hadn't noticed notifySessionListenersOnReplication. I

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #9 from Mark Thomas --- Overall the patch looks pretty good. One minor nit is the white space issues already mentioned. The one area where I think some changes are required is listener notification for clusters. If you look at

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #8 from Rainer Jung --- Trailing whitespace example: +++ C:/Tomcat-Build/Source/java/javax/servlet/http/HttpServletRequest.java (working copy) @@ -381,6 +381,15 @@ * @see #getSession(boolean) */ public Htt

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #7 from Nick Williams --- Yes. I am using Ant 1.8.4. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #6 from Konstantin Kolinko --- Are you using Apache Ant 1.8.x? (1.8.4 recommended) -- You are receiving this mail because: You are the assignee for the bug.

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 Nick Williams changed: What|Removed |Added Attachment #29940|0 |1 is obsolete|

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 --- Comment #4 from Nick Williams --- I added execute.validate=true to the build.properties file, and it downloaded validate and then validated. However, the build succeeded and I see nothing about any violations reported. The "validate:" s

[Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener

2013-02-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552 Rainer Jung changed: What|Removed |Added Summary|New Code: Completed Servlet |Completed Servlet 3.1 spec