https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Blocks||54499
--
You are receiving this ma
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #18 from Sheldon Shao ---
Hi Mark,
The code has been refined. Test cases and document also have been provided.
Could you please take a look ?
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29704|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29705|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29693|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #14 from Sheldon Shao ---
All have been fixed by your suggestion. Please take a look. Thanks.
(In reply to comment #3)
> Comment on attachment 29685 [details]
> ELInterpreterFactory
>
> In principle this looks like a good idea
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29694|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29696|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #11 from Sheldon Shao ---
Thank you very much for your information!
I'll try to follow up with this approach.
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #3)
>
> > > 4. I dislike the use of s
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #10 from Rainer Jung ---
(In reply to comment #9)
> (In reply to comment #3)
> > 4. I dislike the use of system properties when they are not necessary. If
> > the class name was handled as a servlet context initialization param
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #9 from Sheldon Shao ---
(In reply to comment #3)
> Comment on attachment 29685 [details]
> ELInterpreterFactory
>
> In principle this looks like a good idea.
>
> I have a couple of concerns with the patch as currently written
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #8 from Sheldon Shao ---
Created attachment 29696
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29696&action=edit
Test case for ELInterpreterFactory
Test case for ELInterpreterFactory
--
You are receiving this ma
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29686|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29685|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29684|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
OS||All
--- Comment #4 from Sheldon Sha
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #3 from Mark Thomas ---
Comment on attachment 29685
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29685
ELInterpreterFactory
In principle this looks like a good idea.
I have a couple of concerns with the patch as
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #2 from Sheldon Shao ---
Created attachment 29686
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29686&action=edit
Patch for Generator.java
--
You are receiving this mail because:
You are the assignee for the bug.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
Sheldon Shao changed:
What|Removed |Added
Attachment #29684|application/octet-stream|text/plain
mime type|
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239
--- Comment #1 from Sheldon Shao ---
Created attachment 29685
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29685&action=edit
ELInterpreterFactory
--
You are receiving this mail because:
You are the assignee for the bug.
---
21 matches
Mail list logo
