[GitHub] tomcat pull request: Change response character encoding

2015-12-22 Thread ukari
Github user ukari commented on the pull request: https://github.com/apache/tomcat/pull/25#issuecomment-166806452 Thank both of you very much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tomcat pull request: Change response character encoding

2015-12-21 Thread ukari
Github user ukari commented on the pull request: https://github.com/apache/tomcat/pull/25#issuecomment-166529165 I get it, but it won't work for application/json due to this line ```java if (ct != null && ct.startsWith("text/")) { ``` --- If you

[GitHub] tomcat pull request: Change response character encoding

2015-12-18 Thread ukari
Github user ukari commented on the pull request: https://github.com/apache/tomcat/pull/25#issuecomment-165782452 I put that example in email, so you can't see it in github. https://drive.google.com/file/d/0BxfFe2h4UJX4OEdMZ2dZMTBvYzBvOEl5Ykx4WUxNVWJiRmpj/view?usp=sharing -

[GitHub] tomcat pull request: Change response character encoding

2015-12-18 Thread ukari
Github user ukari commented on the pull request: https://github.com/apache/tomcat/pull/25#issuecomment-165767039 Here is the example 2015-12-18 20:12 GMT+08:00 Wenjie Zhang : > Here is the document for this filter, > http://tomcat.apache.org/tomcat-7.0-doc/

[GitHub] tomcat pull request: Change response character encoding

2015-12-18 Thread ukari
Github user ukari commented on the pull request: https://github.com/apache/tomcat/pull/25#issuecomment-165763957 Oh, you are right, sorry I make the mistake. But why response's encoding not changed after I set AddDefaultCharsetFilter?(I mean a HttpServletResponse) I

[GitHub] tomcat pull request: Change response character encoding

2015-12-17 Thread ukari
GitHub user ukari opened a pull request: https://github.com/apache/tomcat/pull/25 Change response character encoding It seems that encoding was forgotten to be changed in function doFilter(). When I set AddDefaultCharsetFilter in web.xml, like the following