[GitHub] tomcat pull request: Split AccessLogValve and extract the formatti...

2014-05-23 Thread mthomas-pivotal
Github user mthomas-pivotal commented on the pull request: https://github.com/apache/tomcat/pull/2#issuecomment-43977821 I believe a variation of this has been applied to trunk and that this pull request can be closed. --- If your project is set up for it, you can reply to this

[GitHub] tomcat pull request: Update service.bat

2014-05-23 Thread mthomas-pivotal
Github user mthomas-pivotal commented on the pull request: https://github.com/apache/tomcat/pull/3#issuecomment-43977698 A rather late response but yes, this pull request should be closed (which I don;t think I can do - can I?) --- If your project is set up for it, you can reply to

[GitHub] tomcat pull request: Document the use of "shutdown" and "port" att...

2014-05-05 Thread mthomas-pivotal
Github user mthomas-pivotal commented on the pull request: https://github.com/apache/tomcat/pull/6#issuecomment-42253821 I am also -1 on this change. I'd actually prefer to see fewer comments in the default server.xml rather than more comments. --- If your project is set up f