[GitHub] tomcat issue #39: Provide the correct port when using proxy

2017-01-21 Thread SvetlinZarev
Github user SvetlinZarev commented on the issue: https://github.com/apache/tomcat/pull/39 Hi, I've already created a bugzilla ticket: https://bz.apache.org/bugzilla/show_bug.cgi?id=60617 > Do you read changelogs? I do. --- If your project is set up for it,

[GitHub] tomcat issue #39: Provide the correct port when using proxy

2017-01-16 Thread SvetlinZarev
Github user SvetlinZarev commented on the issue: https://github.com/apache/tomcat/pull/39 > Does the CONNECT verb not imply a default port number when none is present? @ChristopherSchultz According to [rfc2817 section 5.2](https://www.ietf.org/rfc/rfc2817.txt): &

[GitHub] tomcat issue #39: Provide the correct port when using proxy

2017-01-14 Thread SvetlinZarev
Github user SvetlinZarev commented on the issue: https://github.com/apache/tomcat/pull/39 Issue Description === WsWebSocketContainer generates bad CONNECT request when a proxy is used. The host does not contain port information, hence the app cannot connect to wss

[GitHub] tomcat issue #39: Provide the correct port when using proxy

2017-01-13 Thread SvetlinZarev
Github user SvetlinZarev commented on the issue: https://github.com/apache/tomcat/pull/39 It's not a no-op. Imagine the following case: WS-Host: wss://echo.websocket.org proxy-host: proxy proxy-port: 8080 The flow is as follows: URI path = the WS

[GitHub] tomcat pull request #39: Provide the correct port when using proxy

2017-01-13 Thread SvetlinZarev
GitHub user SvetlinZarev opened a pull request: https://github.com/apache/tomcat/pull/39 Provide the correct port when using proxy Fix "create-connection" failures in case of proxied connection. The proxy needs the remote port information in order to know to whi

[GitHub] tomcat issue #34: fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_F...

2016-09-28 Thread SvetlinZarev
Github user SvetlinZarev commented on the issue: https://github.com/apache/tomcat/pull/34 Nope, Boolean.getBoolean("xxx") tries to convert the value of the system property "xxx" to a boolean or returns false if it's missing. The method name is indeed very