Re: Two questions about SemaphoreValve support for filtering (bug # 41679)

2007-03-06 Thread Scott Marlow
Remy Maucherat wrote: Scott Marlow wrote: I didn't want a single request to consume Semaphore permits from more than one SemaphoreValve. I'm not sure about that, since for example the last valve could be more restrictive than the first one, etc. It seems more logical to me to c

Re: Two questions about SemaphoreValve support for filtering (bug # 41679)

2007-03-06 Thread Scott Marlow
I don't see how a request going through a Valve can be "already throttled", as requests are supposed to go through a valve only once. Can you give an example ? (maybe multiple valves in a row like what is suggested below ?) Valves only accept the concrete Request class, no wrapping allowed.

Two questions about SemaphoreValve support for filtering (bug # 41679)

2007-03-06 Thread Scott Marlow
ubclass. I assume that if several SemaphoreValve instances are specified in conf/server.xml, that they are executed in the order that they appear. This appears to be the behavior in Tomcat 5.x + 5.5.x. Is this a valid assumption to add to the doc? Than