Re: svn commit: r1410764 - in /tomcat/trunk: build.properties.default java/org/apache/jasper/compiler/JDTCompiler.java

2012-11-19 Thread Peter Roßbach
+1 Peter Am 17.11.2012 um 21:25 schrieb Konstantin Kolinko: > 2012/11/17 Mark Thomas : >> On 17/11/2012 19:27, ma...@apache.org wrote: >>> Author: markt >>> Date: Sat Nov 17 19:27:33 2012 >>> New Revision: 1410764 >>> >>> URL: http://svn.apache.org/viewvc?rev=1410764&view=rev >>> Log: >>> Update

Re: [VOTE] Release Apache Tomcat 7.0.28

2012-06-17 Thread Peter Roßbach
> [x ] Stable - go ahead and release as 7.0.28 Stable Test websockets changes Peter Am 15.06.2012 um 11:14 schrieb Mark Thomas: > The proposed Apache Tomcat 7.0.28 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.28

Re: svn commit: r1310693 - in /tomcat/tc7.0.x/trunk: res/maven/tomcat-jasper.pom webapps/docs/changelog.xml

2012-04-07 Thread Peter Roßbach
I know, but this is the current tomcat used ecj version # - Eclipse JDT, version 3.2 or later - jdt.version=3.7.2 jdt.release=R-3.7.2-201202080800 jdt.home=${base.path}/ecj-${jdt.version} jdt.jar=${jdt.home}/ecj-${jdt.version}.jar # The download will be moved to the archive area eventuall

Re: svn commit: r1310712 - in /tomcat/tc7.0.x/trunk: res/maven/tomcat-catalina-ha.pom res/maven/tomcat-coyote.pom res/maven/tomcat-embed-jasper.pom res/maven/tomcat-util.pom webapps/docs/changelog.xml

2012-04-07 Thread Peter Roßbach
We must download maven-ant-tasks-2.1.3 and jsch without maven tasks and then we can use it! Peter Am 07.04.2012 um 11:16 schrieb Mark Thomas: > On 07/04/2012 10:14, Peter Roßbach wrote: >> cool remove a point of my TODO list >> +1 >> >> I have checked that also new

Re: svn commit: r1310712 - in /tomcat/tc7.0.x/trunk: res/maven/tomcat-catalina-ha.pom res/maven/tomcat-coyote.pom res/maven/tomcat-embed-jasper.pom res/maven/tomcat-util.pom webapps/docs/changelog.xml

2012-04-07 Thread Peter Roßbach
cool remove a point of my TODO list +1 I have checked that also new maven-ant-tasks-2.1.3 works. How we can download this jar and jsch? Peter Am 07.04.2012 um 11:00 schrieb ma...@apache.org: > Author: markt > Date: Sat Apr 7 09:00:47 2012 > New Revision: 1310712 > > URL: http://svn.apache.or

Re: svn commit: r1310707 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

2012-04-07 Thread Peter Roßbach
Yes, but most Http-Header send with first uppercase letter. is a cosmetic fix :-) Peter Am 07.04.2012 um 10:53 schrieb Mark Thomas: > On 07/04/2012 09:51, p...@apache.org wrote: >> Author: pero >> Date: Sat Apr 7 08:51:44 2012 >> New Revision: 1310707 >> >> URL: http://svn.apache.org/viewvc?r

Re: svn commit: r1310640 - /tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java

2012-04-07 Thread Peter Roßbach
Thanx Mark, Peter Am 07.04.2012 um 01:40 schrieb ma...@apache.org: > Author: markt > Date: Fri Apr 6 23:40:57 2012 > New Revision: 1310640 > > URL: http://svn.apache.org/viewvc?rev=1310640&view=rev > Log: > Fix typo > > Modified: >tomcat/trunk/test/org/apache/catalina/websocket/TestWebSock

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-01-31 Thread Peter Roßbach
Hi Oliver, sorry for late testing the release: +1 (beta-1) I thing the plugin need more folks to testing. :-) Peter Am 26.01.2012 um 19:05 schrieb Olivier Lamy: > Hi, > > I'd like to release the Apache Tomcat Maven plugin 2.0-beta-1. > > The staging repository is available here: > https://

Re: [VOTE] Grant Olivier Lamy commit karma to the Tomcat repo (for the Maven plugin)

2011-08-27 Thread Peter Roßbach
+1 Peter Am 25.08.2011 um 16:44 schrieb Mark Thomas: > Subject says it all. > > Here is my +1 to start this off. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev

Re: [RESULT] [VOTE] Release Apache Tomcat 7.0.19

2011-07-18 Thread Peter Roßbach
[X] Stable - go ahead and release as 7.0.19 Stable Peter Am 18.07.2011 um 11:32 schrieb Mark Thomas: > On 14/07/2011 10:21, Mark Thomas wrote: > The result of the vote is stable, with the following minor issues to be > noted in the release announcement: > > 1. AJP NIO connector does not use pers

Re: JK 1.2.32 release kick

2011-07-02 Thread Peter Roßbach
+1 Peter Am 27.06.2011 um 20:03 schrieb Mladen Turk: > Hi, > > I have a time slot available so I volunteer as a 1.2.32 RM. > Think we are good for a new release. > > Comments, objections? > > > Regards > -- > ^TM > > - > To

Vote: Add Checkstyle roleset and make code cleanups!

2010-07-08 Thread Peter Roßbach
Hi, after the discussion about code style (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj ), I think that we must vote for this fix: https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 It includes a starting point for a very limited checkstyle ruleset. +1: progressively introduce che

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Peter Roßbach
I totally argreed with Marc Guillemot. It is time to more invest to the cosmetic things at the tomcat code basis. Peter Am 08.07.2010 um 07:37 schrieb Marc Guillemot: Hi Mark, Mark Thomas wrote: ... There is nothing stopping you running FindBugs, Checkstyle or any other tool locally.

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Peter Roßbach
Hi! I miss the checkstyle and findbugs quality checks in the project. Marc has contributed a good starting point at https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 Then I can check my personal problem with the tab/space replacement, before checkin code :-) Currently we have in 144 f

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-07 Thread Peter Roßbach
+1 Stable Test tar.gz with MAC OS X and it works fine. Thanks, Peter Am 01.07.2010 um 18:11 schrieb Jim Jagielski: The builds for Tomcat 5.5.30 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the releas

Re: svn commit: r960348 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java test/org/apache/catalina/core/TestAsyncListener.java webapps/docs/changelog.xml

2010-07-04 Thread Peter Roßbach
Hi Mark, why you remove and doesn't correct the TestCases? Please, explain how a AsyncListner can receive onTimeout ? Peter Am 04.07.2010 um 17:44 schrieb ma...@apache.org: Author: markt Date: Sun Jul 4 15:44:45 2010 New Revision: 960348 URL: http://svn.apache.org/viewvc?rev=960348&view=r

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-04 Thread Peter Roßbach
Hmm, Spec says: public boolean isAsyncStarted() - Returns true if async processing has started on this request, and false otherwise. If this request has been dispatched using one of the AsyncContext.dispatch methods since it was put in asynchronous mode, or a call to AsynContext.complete is m

Re: svn commit: r960283 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml

2010-07-04 Thread Peter Roßbach
Hi Rainer, source of AsyncContextImpl has a lot of open checkstyle warnings. I check my eclipse but all formatter use space instead tabs. Very strange... Peter Am 04.07.2010 um 01:17 schrieb Rainer Jung: Hi Peter, On 04.07.2010 00:48, p...@apache.org wrote: Author: pero Date: Sat Jul 3

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-02 Thread Peter Roßbach
/02/2010 04:11 PM, Peter Roßbach wrote: Hi Jean-Frederic, had you check my test case TestAsyncListener? Can you checkin or send me your test case. Normally the setTimeout will call the connector (ACTION_ASYNC_SETTIMEOUT). Which I think it does but the timeout doesn't occur, at least wit

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-02 Thread Peter Roßbach
I am very sure the NIO and APR Connector affected, but I don't have find a fix. Peter Am 02.07.2010 um 19:48 schrieb Mark Thomas: On 02/07/2010 15:15, jean-frederic clere wrote: On 07/02/2010 03:08 PM, Marc Guillemot wrote: Rainer Jung wrote: ... Exact details are forbidden, but I'm sure

Re: svn commit: r960069 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java

2010-07-02 Thread Peter Roßbach
Many Thanks and sorry :-) Peter Am 02.07.2010 um 19:50 schrieb ma...@apache.org: Author: markt Date: Fri Jul 2 17:50:56 2010 New Revision: 960069 URL: http://svn.apache.org/viewvc?rev=960069&view=rev Log: Make new timeout thread a daemon thread so Tomcat will shutdown properly Modified:

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-02 Thread Peter Roßbach
Hi Jean-Frederic, had you check my test case TestAsyncListener? Can you checkin or send me your test case. Peter Am 02.07.2010 um 15:15 schrieb jean-frederic clere: On 07/02/2010 03:08 PM, Marc Guillemot wrote: Rainer Jung wrote: ... Exact details are forbidden, but I'm sure there'll be so

Re: svn commit: r958362 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java test/org/apache/catalina/core/TestAsyncListener.java webapps/docs/changelog.xml

2010-06-30 Thread Peter Roßbach
I am highly interessed why does my fix is wrong :-) Is my fix really wrong, you can revert my checkin. Today I present the new Tomcat 7 release at Java User Forum Stuttgart (Germany). Many thanks, Peter Am 01.07.2010 um 08:20 schrieb jean-frederic clere: On 06/30/2010 09:15 PM, Peter

Re: Proposal: Some todo's at AsyncContext detected...

2010-06-30 Thread Peter Roßbach
ike to help out I would encourage you to look at Peter's test case, compare the expected behaviour to what the spec defines and offer your view on whether there is a bug that needs fixing or not. If there is an issue, patches would be even better. Mark Cheers, Marc. Peter Roßb

Proposal: Some todo's at AsyncContext detected...

2010-06-27 Thread Peter Roßbach
Hi! I detected some Todo's at AsyncContext - AsyncContext.createListener We don't make a resource injection or make it configurable! Servlet 3.0 API comment: "This method supports resource injection if the given clazz represents a Managed Bean. See the Java EE platform and JSR 2

Re: [VOTE] Release Apache Tomcat 7.0.0 as beta

2010-06-20 Thread Peter Roßbach
+1 beta Peter Am 14.06.2010 um 00:15 schrieb Mark Thomas: The propsoed 7.0.0 release is [ ] Broken - do not release [ ] Alpha - go ahead and release as 7.0.0 Alpha [x ] Beta - go ahead and release as 7.0.0 Beta - To unsu

Re: tag 6.0.27 on Monday

2010-06-14 Thread Peter Roßbach
Hi Jean-Frederic, only the last 6.0.26 release has a wrong normal juli.jar. Can you correct this? Please, made a check after tomcat 6.0.27 maven publish. No regression... Many thanks Peter Am 14.06.2010 um 08:57 schrieb jean-frederic clere: On 06/13/2010 11:09 AM, Peter Roßbach wrote

Re: tag 6.0.27 on Monday

2010-06-13 Thread Peter Roßbach
Hi Jenn-Frederic, at the 6.0.26 Release we have deployed a wrong juli.jar at the maven repo: http://tomcat.apache.org/dev/dist/m2-repository/org/apache/tomcat/juli/6.0.26/juli-6.0.26.jar This jar is the commons-logging/log4j juli package. Cheers, Peter Am 10.06.2010 um 07:59 schrieb jean-f

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0-RC4

2010-06-11 Thread Peter Roßbach
+1 I VOTE BETA Peter Am 07.06.2010 um 16:38 schrieb Mark Thomas: All, The next Tomcat 7.0.0 release candiate is ready for testing. 7.0.0-RC4 can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC4/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCA

Re: tag 6.0.27 on Monday

2010-06-11 Thread Peter Roßbach
+1 Peter Am 10.06.2010 um 07:59 schrieb jean-frederic clere: Hi, I plan to tag 6.0.27 on Monday (European morning) and start the release process. Comments? Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...

Re: Draft of first blog post announcing TC7

2010-05-17 Thread Peter Roßbach
+1 my improvements for the list. rewrite the internal component lifecycle management easier tomcat embedding used only java executor API at all connectors Peter Am 17.05.2010 um 16:41 schrieb Mark Thomas: I have drafted an announcement of the upcoming TC7 release for our first blog post.

Re: svn commit: r939253 - in /tomcat/trunk/test: org/apache/catalina/core/ webapp-3.0-fragments/ webapp-3.0-fragments/WEB-INF/ webapp-3.0-fragments/WEB-INF/lib/ webapp-3.0-fragments/folder/

2010-04-29 Thread Peter Roßbach
Hi, I have debug the problem and it seams very strange. Why zip file is closed? I have build a standalone example with other files from scratch and I got my resource from bundled jar:/META-INF/resource/hello.jsp. But as I use the resource.jar it not work and also my jar don't work with the

Re: svn commit: r939221 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java

2010-04-29 Thread Peter Roßbach
OK, I change my default. A lot of tomcat classes has this problem. I found 861 java files at tomcat 7 with token "Revision"! Peter Am 29.04.2010 um 09:30 schrieb kkoli...@apache.org: Author: kkolinko Date: Thu Apr 29 07:30:29 2010 New Revision: 939221 URL: http://svn.apache.org/viewvc?rev

Re: svn commit: r937325 - in /tomcat/trunk/java/org/apache: catalina/ha/session/DeltaManager.java el/lang/ExpressionBuilder.java

2010-04-28 Thread Peter Roßbach
Add to my ToDo list :-) Peter Am 29.04.2010 um 01:09 schrieb Mark Thomas: .. and also we can optimized the "for"-statement to for(Valve valve: valves) { if(valve instanceof ReplicationValve) { replicationValve = (ReplicationValve)valve ; break; } } Not without changing when the debug messag

Re: svn commit: r939143 - /tomcat/trunk/webapps/docs/changelog.xml

2010-04-28 Thread Peter Roßbach
+1 for that! Makes life easier... Peter Am 29.04.2010 um 02:36 schrieb ma...@apache.org: Author: markt Date: Thu Apr 29 00:36:35 2010 New Revision: 939143 URL: http://svn.apache.org/viewvc?rev=939143&view=rev Log: It isn't practical to list every single commit that implemented Servlet 3.0.

Tomcat 7 ; Servlet API question - Spec 8.2.3 overwrite WebServlet annotation parameter

2010-04-28 Thread Peter Roßbach
Hi, I have read the servlet 3.0 spec and play around with some simple examples. I setup a very simple annotated servlet: == package annotation; import java.io.IOException; import java.io.PrintWriter; import javax.servlet.ServletException; import javax.servlet.annotation.WebInitParam; impor

Re: .classpath and .project in src distribution (was: svn commit: r937993)

2010-04-27 Thread Peter Roßbach
The current setup of the .project and .classpath files works good for many years. I think it was helpfull for user of the src distribution, also use the correct eclipse setup. The license issue is really bad and we must fixit! We can do that with a little ant task. To move .project and .c

Re: svn commit: r937325 - in /tomcat/trunk/java/org/apache: catalina/ha/session/DeltaManager.java el/lang/ExpressionBuilder.java

2010-04-26 Thread Peter Roßbach
le. Peter Am 26.04.2010 um 12:43 schrieb Mark Thomas: On 26/04/2010 10:28, Peter Roßbach wrote: Hi Mark, bad fix! The method getValves() only exists at CatalinaCluster! getCluster() returns an object of type CatalinaCluster. The check wasn't doing anything apart from wasting CPU

Re: svn commit: r937325 - in /tomcat/trunk/java/org/apache: catalina/ha/session/DeltaManager.java el/lang/ExpressionBuilder.java

2010-04-26 Thread Peter Roßbach
Hi Mark, bad fix! The method getValves() only exists at CatalinaCluster! peter Am 23.04.2010 um 17:09 schrieb ma...@apache.org: Modified: tomcat/trunk/java/org/apache/catalina/ha/session/ DeltaManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/De

Re: Using JIRA instead STATUS.txt

2010-03-14 Thread Peter Roßbach
+1 Peter Am 14.03.2010 um 08:07 schrieb Mladen Turk: Hi, I would suggest that we use JIRA instead maintaining STATUS.txt files. Each branch can then be a separate component and each status vote JIRA issue classified as either bug, feature, etc... Voting is supported except that one cannot vot

Re: JK 1.2.29 Plan

2010-01-06 Thread Peter Roßbach
+1 Regards Peter Am 06.01.2010 um 11:07 schrieb Rainer Jung: Any objections to the following plan about JK 1.2.29? - 15.01.2009 make snapshot available for testing feedback like we did for nearly all previous releases - ~22.01.2009 tag 1.2.29 (exact date depending whether there's bug feed

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-17 Thread Peter Roßbach
Cool refactoring! +1 Peter Am 13.08.2009 um 22:07 schrieb Filip Hanik - Dev Lists: Here is why I think its good 1. Current pools can't shrink, so when peak has been hit, that's where were at 2. Current pools are unfair, synchronized (workers) { workers.wait() }, executors are a bit more f

Re: svn commit: r772875 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-10 Thread Peter Roßbach
OK, I see the problem Peter Am 10.05.2009 um 04:03 schrieb Konstantin Kolinko: + +* Fix Close Stream at WebappClassLoader after read error + http://svn.apache.org/viewvc?rev=772872&view=rev + +1: pero + -1: + Nice catch, but what bugs me here (in WebappClassLoader#findResourceInterna

Re: [ANN] New committer: Konstantin Kolinko

2009-05-08 Thread Peter Roßbach
Hello Konstantin, Great work and very welcome in the tomcat team. Regards, Peter Am 06.05.2009 um 09:52 schrieb Mark Thomas: On behalf of the Tomcat committers I am pleased to announce that Konstantin Kolinko has been voted in as a new Tomcat committer. Please join me in welcoming him. M