On Tue, May 30, 2017 at 5:34 PM, Mark Thomas wrote:
> On 30/05/17 13:55, Katya Todorova wrote:
> > Hello,
> >
> > Looking at javax.servlet.jsp.tagext.TagLibraryInfo, uri and prefix
> fields
> > are declared final while according to the spec and tomcat docume
Hello,
Looking at javax.servlet.jsp.tagext.TagLibraryInfo, uri and prefix fields
are declared final while according to the spec and tomcat documentation
they should not be.
Is that intentionally done?
Thank you,
Katya
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/tagext/
TagL
On Wed, Apr 5, 2017 at 3:57 PM, Mark Thomas wrote:
> On 05/04/2017 07:50, Katya Todorova wrote:
>
>>
>>> Applied. Many thanks.
>>>
>>> If you'd like to work on this further then can I suggest you take a look
>>> at Konstantin's comm
>
> Applied. Many thanks.
>
> If you'd like to work on this further then can I suggest you take a look
> at Konstantin's comments:
>
> http://markmail.org/message/vp5voob7elspflax
I looked at the comments and it seems there are things to be clarified
before going in this direction:
- should we in
> You can either create a pull request on github or create a Bugzilla
> issue and attach a patch.
> Mark
>
I've created a separate pull request for leading zeros issue since I think
it requires additional discussion whether to be submitted or not. Although
this fix honors the specification, it l
>
> I recommend using the code coverage reports as a guide.
>
> https://ci.apache.org/projects/tomcat/tomcat9/coverage/
>
> and add test cases if they increase code coverage. Hmm. It looks like
> there is some low hanging fruit in the parsing code to improve coverage.
>
> You can run the tests wi
On Tue, Mar 28, 2017 at 5:45 PM, Mark Thomas wrote:
> On 28/03/17 15:23, Katya Todorova wrote:
> > Hi,
> >> r1787662 adds Host header validation along with a fair number of unit
> tests.
> >> It includes a performance test which indicates - on my machine at lea
On Tue, Mar 28, 2017 at 5:45 PM, Mark Thomas wrote:
> On 28/03/17 15:23, Katya Todorova wrote:
> > Hi,
> >> r1787662 adds Host header validation along with a fair number of unit
> tests.
> >> It includes a performance test which indicates - on my machine at lea
Hi,
> r1787662 adds Host header validation along with a fair number of unit tests.
> It includes a performance test which indicates - on my machine at least
> - that the performance impact is in the noise. I'd like to see better
> performance for full IPv6 addresses but the current code looks to be
