Re: WebSockets in Tomcat 6

2012-03-15 Thread Filip Hanik - Dev Lists
On 3/15/2012 6:54 AM, Mark Thomas wrote: On 14/03/2012 17:42, Filip Hanik Mailing Lists wrote: http://people.apache.org/~fhanik/reports/servers/ Attached is a patch that leverages the Tomcat WebSocket API with minimalistic changes and uses that to implement WebSockets in Tomcat 6.0.x http://peo

Re: WebSocket status

2012-03-14 Thread Filip Hanik - Dev Lists
On 3/14/2012 8:14 AM, Mark Thomas wrote: On 14/03/2012 10:15, Johno Crawford wrote: On 8/03/2012 9:10 PM, Mark Thomas wrote: On 08/03/2012 09:12, Johno Crawford wrote: What's next / left on the TODO list Mark? Anything I can help out with? Porting the generic HTTP upgrade followed by the WebS

Re: WebSocket status

2012-03-02 Thread Filip Hanik - Dev Lists
On 3/2/2012 2:13 AM, Mark Thomas wrote: You can't register on a selector using another thread. Bingo. That explains it. Is that documented anywhere? I'm not sure if the java.nio documentation says it, I think it does. The Selector object is not thread safe. trying to manipulate interestops and

Re: svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-01 Thread Filip Hanik - Dev Lists
Thanks for that John, I'll fix that too. Filip On 3/1/2012 4:42 PM, Johno Crawford wrote: On 2/03/2012 12:05 AM, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 23:05:51 2012 New Revision: 1295978 URL: http://svn.apache.org/viewvc?rev=1295978&view=rev Log: Fix WebSocket's non blockin

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
od for thought :) On 3/1/2012 11:15 AM, Mark Thomas wrote: On 01/03/2012 18:01, Filip Hanik - Dev Lists wrote: Alright, now that I'm all squared away with Autobahn and test cases running. Is there a specific unit test you have to produce this behavior? That would help me for digging

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-01 Thread Filip Hanik - Dev Lists
On 3/1/2012 11:42 AM, Mark Thomas wrote: On 01/03/2012 18:27, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 18:27:56 2012 New Revision: 1295724 URL: http://svn.apache.org/viewvc?rev=1295724&view=rev Log: Allow the examples to configure the buffer on the fly Guess you beat me to it.

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
On 2/28/2012 11:39 AM, Mark Thomas wrote: Thanks for the feedback. You may also be able to help with some problems I am having getting non-blocking behaviour between messages with NIO. I'm not 100% clear what is happening yet, but I think it is something like: - HTTP GET (with upgrade request ar

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
I see, MessageInbound has hard coded receive buffers. Got it Filip On 3/1/2012 10:13 AM, Filip Hanik - Dev Lists wrote: Mark, what buffer size are you referring to increase for the web socket tests to all pass? Filip On 3/1/2012 9:42 AM, Mark Thomas wrote: On 01/03/2012 15:03, Filip Hanik

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
Mark, what buffer size are you referring to increase for the web socket tests to all pass? Filip On 3/1/2012 9:42 AM, Mark Thomas wrote: On 01/03/2012 15:03, Filip Hanik - Dev Lists wrote: I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part of Poller.processKey() Thoughts and/or comments? Not knowing the NIO code very well, there might be a better way to achieve the same result that I haven't seen. Mark [1] http://people.apache

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
On 3/1/2012 5:33 AM, Mark Thomas wrote: On 01/03/2012 11:31, Mark Thomas wrote: On 28/02/2012 21:29, Mark Thomas wrote: On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: On 2/28/2012 11:39 AM, Mark Thomas wrote: You may also be able to help with some problems I am having getting non

Re: WebSocket status

2012-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2012 11:39 AM, Mark Thomas wrote: On 28/02/2012 16:58, Filip Hanik - Dev Lists wrote: On 2/28/2012 4:08 AM, Mark Thomas wrote: WebSocket is working with good performance and passing all Autobahn tests on BIO, NIO and APR. Currently, all three connectors using blocking IO throughout so

Re: [VOTE] Release Apache Tomcat Native 1.1.23

2012-02-28 Thread Filip Hanik - Dev Lists
[+1] Released Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: WebSocket status

2012-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2012 4:08 AM, Mark Thomas wrote: WebSocket is working with good performance and passing all Autobahn tests on BIO, NIO and APR. Currently, all three connectors using blocking IO throughout so there is a one to one mapping between threads and connections. Therefore, scalability is not wha

Re: AccessLogValve enhancement

2012-02-17 Thread Filip Hanik - Dev Lists
On 2/17/2012 8:55 AM, Francis Galiegue wrote: While AccessLogValve is the subject... Any chance we can do away with the default, unparseable timestamp format? With Apache, it is allowed to specify the timestamp using strftime(3)-like format, I'd like to be able to do the same with Tomcat's Acces

Re: AccessLogValve enhancement

2012-02-17 Thread Filip Hanik - Dev Lists
On 2/16/2012 2:12 PM, Konstantin Kolinko wrote: Do not send attachments to this mailing list ever! The world could implode!! - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@

Re: svn commit: r1080719 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-01-16 Thread Filip Hanik - Dev Lists
/01/2012 22:04, Filip Hanik - Dev Lists wrote: I'm looking for a better reason for this change. What was the reasoning behind this limitation, as it breaks years of compatibility. Workaround is to point docBase to a directory. The reasoning was that the documentation said one thing (that

Re: svn commit: r1183612 [2/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-13 Thread Filip Hanik - Dev Lists
sonal formatting preference for one developer, down the line can make it a lot harder to trace changes for others. Filip On 1/13/2012 3:34 PM, Konstantin Kolinko wrote: 2012/1/14 Filip Hanik - Dev Lists: Commits like this, make it very difficult to trace down changes in the SVN history. I know both

Re: svn commit: r1080719 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-01-13 Thread Filip Hanik - Dev Lists
I'm looking for a better reason for this change. What was the reasoning behind this limitation, as it breaks years of compatibility. Workaround is to point docBase to a directory. best Filip On 3/11/2011 11:40 AM, ma...@apache.org wrote: Author: markt Date: Fri Mar 11 18:40:13 2011 New Revisi

Re: Proposal: use tomcat-version-number in server.xml element?

2011-12-02 Thread Filip Hanik - Dev Lists
On 12/2/2011 10:11 AM, Konstantin Kolinko wrote: 2011/12/2 Christopher Schultz: All, This may be a waste of time, but it's worth suggesting IMO. We have lots of users who try to upgrade between major versions of Tomcat by simply installing the new Tomcat somewhere, copying their configuration

Re: Change in behavior for Connector maxKeepAliveRequests in 7.0.21+

2011-11-17 Thread Filip Hanik - Dev Lists
On 11/17/2011 2:00 AM, Konstantin Kolinko wrote: 2011/11/17 Ryan Morgan: Hey everyone, As part of the HTTP connector refactoring that occurred in 7.0.21 (see http://svn.apache.org/viewvc?diff_format=h&view=revision&revision=1158367) the Connector behavior has changed when maxKeepAliveRequests

Re: Tomcat 6.0.34

2011-09-08 Thread Filip Hanik - Dev Lists
On 9/7/2011 11:48 AM, Anand, Amit (Contractor) wrote: All, Kinda new to tomcat but have a couple quick questions which came up regarding CVE-2011-3109 (Bug 51698). Questions: Any timeline to when stable release of 6.0.34 is supposed to be released? Just follow this list. That's the best way

Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-26 Thread Filip Hanik - Dev Lists
Thank you! On 8/26/2011 7:31 AM, Konstantin Kolinko wrote: 2011/8/25 Konstantin Kolinko: URL: http://svn.apache.org/viewvc?rev=1157874&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 1) I think that because of this change the " while (con != null) {" loop may run infi

Re: [VOTE] Grant Olivier Lamy commit karma to the Tomcat repo (for the Maven plugin)

2011-08-25 Thread Filip Hanik - Dev Lists
+1 On 8/25/2011 8:44 AM, Mark Thomas wrote: Subject says it all. Here is my +1 to start this off. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: is this acceptor threadsafe?

2011-08-15 Thread Filip Hanik - Dev Lists
On 8/15/2011 6:34 AM, Ҷï wrote: /** * Server socket acceptor thread. */ protected class Acceptor implements Runnable { /** * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor.

Re: [VOTE] Release Apache Tomcat 7.0.19

2011-07-18 Thread Filip Hanik - Dev Lists
[X] Stable - go ahead and release as 7.0.19 Stable On 7/14/2011 3:21 AM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.19 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.19/ The svn tag is: http://svn.apache.org/repos/asf/tom

Re: Distributable contexts and non-serializable session attributes

2011-07-10 Thread Filip Hanik - Dev Lists
go ahead add it in, if you add in a flag to toggle the behavior, and the flag is defaulted to today's behavior. you're safe, and you give users an option Filip On 7/10/2011 1:38 PM, Rainer Jung wrote: I implemented an addition to DeltaManager which allows to filter which session attributes act

Re: [jdbc-pool] AT sign in manifest (filtered version strings)

2011-07-10 Thread Filip Hanik - Dev Lists
feel free to commit the fix On 7/10/2011 2:38 PM, Rainer Jung wrote: I tested the jdbc-pool building, which is part of the release right now. The manifest contains patterns of the form @@VERSION@@, e.g. org.apache.tomcat.jdbc.pool;version="@@VERSION@@"; org.apache.tomcat.jdbc.pool.interceptor;v

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-10 Thread Filip Hanik - Dev Lists
On 7/10/2011 6:59 AM, Rainer Jung wrote: Hi Filip, On 07.07.2011 23:40, fha...@apache.org wrote: Author: fhanik Date: Thu Jul 7 21:40:05 2011 New Revision: 1144061 URL: http://svn.apache.org/viewvc?rev=1144061&view=rev Log: Include jdbc-pool into tomcat release. Added: tomcat/trunk/res/

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-08 Thread Filip Hanik - Dev Lists
On 7/7/2011 5:55 PM, Konstantin Kolinko wrote: 2011/7/8: Author: fhanik Date: Thu Jul 7 21:40:05 2011 New Revision: 1144061 URL: http://svn.apache.org/viewvc?rev=1144061&view=rev Log: Include jdbc-pool into tomcat release. Added: tomcat/trunk/res/maven/tomcat-jdbc.pom 1) svn:eol-style fo

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Filip Hanik - Dev Lists
On 6/20/2011 8:06 AM, Mladen Turk wrote: On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything t

Re: Plan for 7.0.15

2011-06-03 Thread Filip Hanik - Dev Lists
On 6/3/2011 10:13 AM, Mark Thomas wrote: On 03/06/2011 17:07, Filip Hanik - Dev Lists wrote: I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. DBCP will still be the default, but allows users to configure an alternative fairly easily without downloading sep

Re: Plan for 7.0.15

2011-06-03 Thread Filip Hanik - Dev Lists
I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. DBCP will still be the default, but allows users to configure an alternative fairly easily without downloading separate libraries. It's easy to include in the build process, the jar is very small, so it doesn't bloat the

Re: LocalXA patch proposition

2011-05-24 Thread Filip Hanik - Dev Lists
hi Philippe, open a bugzilla item https://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%20Modules Add your patch there, and I will happily take a look thanks for contributing Filip On 5/24/2011 8:31 AM, Philippe Mouawad wrote: Hello, I have implemented for Ofbiz a port of DBCP Local

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Filip Hanik - Dev Lists
+1 sounds good Filip On 5/18/2011 7:38 AM, Mark Thomas wrote: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would updat

Re: svn commit: r1103633 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

2011-05-16 Thread Filip Hanik - Dev Lists
tch(readTimeout,TimeUnit.MILLISECONDS); +} Filip On 5/16/2011 3:38 PM, Mark Thomas wrote: On 16/05/2011 16:24, Filip Hanik - Dev Lists wrote: -1 for this change. 0 means infinite (no timeout) http://download.oracle.com/javase/6/docs/api/java/net/Socket.html#setSoTimeout%28int%29 The problem

Re: svn commit: r1103633 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

2011-05-16 Thread Filip Hanik - Dev Lists
-1 for this change. 0 means infinite (no timeout) http://download.oracle.com/javase/6/docs/api/java/net/Socket.html#setSoTimeout%28int%29 Filip On 5/16/2011 1:31 AM, ma...@apache.org wrote: Author: markt Date: Mon May 16 07:31:23 2011 New Revision: 1103633 URL: http://svn.apache.org/viewvc?re

Re: DO NOT REPLY [Bug 51189] New: Acceptor threads are blocked

2011-05-12 Thread Filip Hanik - Dev Lists
on most OS:es there is a single lock for accepting new connections, so a better default is 1 for acceptor thread count. there is no performance gain in multiple threads, none that I was ever able to detect. Filip On 5/12/2011 2:32 AM, bugzi...@apache.org wrote: https://issues.apache.org/bugzil

Re: [VOTE] Release Apache Tomcat 7.0.14

2011-05-10 Thread Filip Hanik - Dev Lists
On 5/9/2011 5:31 PM, Mark Thomas wrote: [X] Stable - go ahead and release as 7.0.14 Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Time for 7.0.13

2011-05-05 Thread Filip Hanik - Dev Lists
+1 Filip On 5/5/2011 10:00 AM, Mark Thomas wrote: All open bugs (apart from 49683 which should probably be re-classed as an enhancement) have been fixed in trunk, the BIO changes have been applied and recent enhancement requests (with patches) have been applied. I am about to start the testing

Re: BIO performance issues

2011-05-05 Thread Filip Hanik - Dev Lists
fan-tastic! Thank you! On 5/5/2011 9:56 AM, Mark Thomas wrote: On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: Here is what I propose, and you'll see that it's pretty much inline with what you suggest. a) add in a flag that lets keep alive be turned off during c

Re: BIO performance issues

2011-05-04 Thread Filip Hanik - Dev Lists
On 5/4/2011 9:54 AM, Mark Thomas wrote: On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: On 5/3/2011 2:02 PM, Mark Thomas wrote: In a similar fashion, we can also craft a test run that will yield a substantial improvement over the old implementation in throughput. So there is a test case to

Re: BIO performance issues

2011-05-04 Thread Filip Hanik - Dev Lists
On 5/3/2011 2:02 PM, Mark Thomas wrote: All, Summary --- While trying to align the documentation for maxConnections with the actual implementation a couple of performance issue have been identified with the BIO connector. All bar one of these have been fixed. A fix needs to be agreed for the

Re: bindOnInit and maxConnections for AJP connectors

2011-05-03 Thread Filip Hanik - Dev Lists
On 5/3/2011 10:50 AM, Mark Thomas wrote: On 21/04/2011 20:21, Mark Thomas wrote: On 06/04/2011 22:51, Tim Whittington wrote: On Wed, Apr 6, 2011 at 11:16 PM, Mark Thomas wrote: On 05/04/2011 10:50, Tim Whittington wrote: Is what's actually going on more like: APR: use maxConnections == poll

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2011-04-26 Thread Filip Hanik - Dev Lists
On 4/21/2011 8:00 AM, Mark Thomas wrote: On 19/04/2011 16:27, Filip Hanik - Dev Lists wrote: On 4/18/2011 4:39 AM, Mark Thomas wrote: On 18/04/2011 10:13, Remy Maucherat wrote: On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: Author: markt Date: Sat Apr 16 22:25:28 2011 New

Re: svn commit: r1095794 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11Processor.java webapps/docs/changelog.xml

2011-04-21 Thread Filip Hanik - Dev Lists
On 4/21/2011 1:02 PM, ma...@apache.org wrote: +int firstReadTimeout; +if (queueTime>= standardTimeout) { +// Queued for longer than timeout but there might be +// data so use shortest possible timeout +

Re: SpnegoAuthenticator feedback

2011-04-21 Thread Filip Hanik - Dev Lists
On 4/21/2011 3:09 AM, Mark Thomas wrote: On 20/04/2011 21:00, Filip Hanik - Dev Lists wrote: Here are some thoughts on the implementation Thanks for the feedback. 1. |com.sun.security.jgss.initiate is not needed This definition is not needed in jaas.conf. Tomcat is not a client in this case

SpnegoAuthenticator feedback

2011-04-20 Thread Filip Hanik - Dev Lists
Here are some thoughts on the implementation 1. |com.sun.security.jgss.initiate is not needed This definition is not needed in jaas.conf. Tomcat is not a client in this case, it's a server accepting tickets. the .initiate is only for clients that request a Kerberos ticket from the KDC. The examp

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Filip Hanik - Dev Lists
On 4/20/2011 10:07 AM, Mark Thomas wrote: The new code is better than the old. You are welcome to try and improve it further although I don't think there is much more scope for improvement given the performance figures I am seeing. My suggestion here would be to: 1. When a JAR file has been sca

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2011-04-19 Thread Filip Hanik - Dev Lists
On 4/18/2011 4:39 AM, Mark Thomas wrote: On 18/04/2011 10:13, Remy Maucherat wrote: On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: Author: markt Date: Sat Apr 16 22:25:28 2011 New Revision: 1094069 URL: http://svn.apache.org/viewvc?rev=1094069&view=rev Log: Fix https://issues.apa

Re: svn commit: r1086706 - in /tomcat/trunk/java/org/apache/catalina: Realm.java authenticator/SpnegoAuthenticator.java realm/CombinedRealm.java realm/LocalStrings.properties realm/LockOutRealm.java r

2011-04-11 Thread Filip Hanik - Dev Lists
On 4/7/2011 7:14 PM, Konstantin Kolinko wrote: 2011/4/8 Filip Hanik - Dev Lists: On 3/29/2011 2:05 PM, ma...@apache.org wrote: + * @param certs The gssContext processed by the {@link Authenticator}. + */ +public Principal authenticate(GSSContext gssContext); + + we can continue to

Re: bindOnInit and maxConnections for AJP connectors

2011-04-08 Thread Filip Hanik - Dev Lists
On 4/6/2011 3:51 PM, Tim Whittington wrote: > b) Check the input buffer at the end of the loop in > Http11Processor#process() and process the next request if there is any > data in the input buffer. > - No Increase in memory requirements. > - Fixes issue 3 > - Pipelined requests will get pr

Re: bindOnInit and maxConnections for AJP connectors

2011-04-08 Thread Filip Hanik - Dev Lists
On 4/8/2011 2:50 AM, Tim Whittington wrote: The input buffer is 8k by default (max header size), so this could be significant with a large maxConnections. significant in 1990 maybe :) even with 20k connections, this be a drop in the ocean compared to memory usage for today's applications ---

Re: JSP Compiler swallows exceptions when removing files

2011-04-07 Thread Filip Hanik - Dev Lists
yes On 4/7/2011 1:32 PM, Christopher Schultz wrote: All, While reading the code for jasper.compiler.Compiler on an unrelated errand, I noticed that the removeGeneratedFiles and removeGeneratedClassFiles methods contain this code: } catch (Exception e) { // Remove as much

Re: svn commit: r1086706 - in /tomcat/trunk/java/org/apache/catalina: Realm.java authenticator/SpnegoAuthenticator.java realm/CombinedRealm.java realm/LocalStrings.properties realm/LockOutRealm.java r

2011-04-07 Thread Filip Hanik - Dev Lists
On 3/29/2011 2:05 PM, ma...@apache.org wrote: + * @param certs The gssContext processed by the {@link Authenticator}. + */ +public Principal authenticate(GSSContext gssContext); + + we can continue to add methods and changing the interface, or we can do what most other systems do p

[RESULT] Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-30 Thread Filip Hanik - Dev Lists
Canceled. Not enough votes. Filip On 3/3/2011 12:24 PM, Filip Hanik - Dev Lists wrote: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/ Documentation http://people.apache.org/~fhanik/jdbc-pool

Re: svn commit: r1079575 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/deploy/LocalStrings.properties java/org/apache/catalina/deploy/NamingResources.

2011-03-29 Thread Filip Hanik - Dev Lists
namingResources.cleanupNoClose couldn't you implement a closeMethod="close" in the element, that way the name of the method is configurable. Filip On 3/8/2011 3:15 PM, ma...@apache.org wrote: Author: markt Date: Tue Mar 8 22:15:34 2011 New Revision: 1079575 URL: http://svn.apache.org/vie

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-10 Thread Filip Hanik - Dev Lists
In this interceptor, change RuntimeException to SQLException. I think that (2) is better than (1), because (2) doesn't depend on design of each Interceptors. On Thu, Mar 10, 2011 at 2:09 PM, Keiichi Fujino wrote: 2011/3/4 Filip Hanik - Dev Lists: Source and Binary Packages http://peop

Re: STATUS.txt reviews

2011-03-10 Thread Filip Hanik - Dev Lists
https://issues.apache.org/jira/browse/INFRA-3507 Filip On 3/10/2011 5:12 AM, Konstantin Kolinko wrote: 2011/3/3 Mark Thomas: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-10 Thread Filip Hanik - Dev Lists
turn a SQL exception instead of a NPE Filip On Mar 10, 2011, at 12:09 AM, Keiichi Fujino wrote: 2011/3/4 Filip Hanik - Dev Lists: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/ Document

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-09 Thread Filip Hanik - Dev Lists
ping! jdbc-pool needs a bit vote tlc On 03/03/2011 12:24 PM, Filip Hanik - Dev Lists wrote: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/ Documentation http://people.apache.org/~fhanik/jdbc

Re: Where do we stand with maven publishing?

2011-03-09 Thread Filip Hanik - Dev Lists
On 03/05/2011 09:49 AM, Henri Gomez wrote: And what about jdbc pool on Maven Central ? I want to, but it needs to pass a release first Filip 2011/3/4 Filip Hanik - Dev Lists: Where do we stand with publishing Tomcat jars/artifacts to a Maven repository. I see that the mvn-pub.xml has

Re: [VOTE] Release Apache Tomcat 7.0.10

2011-03-07 Thread Filip Hanik - Dev Lists
On 3/5/2011 7:32 AM, Mark Thomas wrote: [X] Stable - go ahead and release as 7.0.10 Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Where do we stand with maven publishing?

2011-03-07 Thread Filip Hanik - Dev Lists
On 3/5/2011 5:10 AM, Mark Thomas wrote: On 04/03/2011 23:46, Filip Hanik - Dev Lists wrote: Not in here http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/tomcat/catalina/ what am I missing? Couple of things. The artifact IDs were changed for Tomcat 7 so you need to look here: http

Re: Where do we stand with maven publishing?

2011-03-04 Thread Filip Hanik - Dev Lists
On 03/04/2011 12:18 PM, Mark Thomas wrote: On 04/03/2011 17:56, Filip Hanik - Dev Lists wrote: On 03/04/2011 01:54 AM, Mark Thomas wrote: On 04/03/2011 00:33, Filip Hanik - Dev Lists wrote: Got it. It doesn't seem to be published to https://repository.apache.org/ n

Re: Where do we stand with maven publishing?

2011-03-04 Thread Filip Hanik - Dev Lists
On 03/04/2011 01:54 AM, Mark Thomas wrote: On 04/03/2011 00:33, Filip Hanik - Dev Lists wrote: Got it. It doesn't seem to be published to https://repository.apache.org/ nor to ibiblio http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/tomcat/catalina/ Does it mean

Re: Where do we stand with maven publishing?

2011-03-03 Thread Filip Hanik - Dev Lists
On 3/3/2011 5:25 PM, Konstantin Kolinko wrote: 2011/3/4 Filip Hanik - Dev Lists: Where do we stand with publishing Tomcat jars/artifacts to a Maven repository. I see that the mvn-pub.xml has been updated, but I don't see where the source JARs are generated from. Are you talking about Tom

Re: svn commit: r1076736 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default build.xml sign.sh test/org/apache/tomcat/jdbc/test/Bug50571.java test/org/apache/tomcat/jdbc/test/Bug50805.java

2011-03-03 Thread Filip Hanik - Dev Lists
On 3/3/2011 1:25 PM, Konstantin Kolinko wrote: 2011/3/3: Author: fhanik Date: Thu Mar 3 19:20:38 2011 New Revision: 1076736 URL: http://svn.apache.org/viewvc?rev=1076736&view=rev Log: Add missing files and license header Add NOTICE/LICENSE to all JAR files Added: tomcat/trunk/modules/jdb

Where do we stand with maven publishing?

2011-03-03 Thread Filip Hanik - Dev Lists
Where do we stand with publishing Tomcat jars/artifacts to a Maven repository. I see that the mvn-pub.xml has been updated, but I don't see where the source JARs are generated from. best Filip - To unsubscribe, e-mail: dev-un

[VOTE] Release jdbc-pool 1.1.0.1

2011-03-03 Thread Filip Hanik - Dev Lists
Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/ Documentation http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html The proposed 1.1.0.1 release is: [ ] Broken - do not release [ ] Alpha - g

[RESULT] [VOTE] Release jdbc-pool 1.1.0.0

2011-03-03 Thread Filip Hanik - Dev Lists
I'll cancel this vote, get all the NOTICE and LICENSE files correct, as well as the tag matching the jars. best Filip On 3/2/2011 3:09 PM, Filip Hanik - Dev Lists wrote: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ Tag http://svn.apache.org/repos/asf/t

Re: [VOTE] Release jdbc-pool 1.1.0.0

2011-03-03 Thread Filip Hanik - Dev Lists
Thanks, I will get this taken care of, and reroll. Filip On 3/2/2011 8:21 PM, sebb wrote: On 2 March 2011 22:09, Filip Hanik - Dev Lists wrote: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ tomcat-juli.jar has NOTICE and LICENSE files, but none of the pool

[VOTE] Release jdbc-pool 1.1.0.0

2011-03-02 Thread Filip Hanik - Dev Lists
Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_0/ Documentation http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html The proposed 1.1.0.0 release is: [ ] Broken - do not release [ ] Alpha - g

Re: STATUS.txt reviews

2011-03-02 Thread Filip Hanik - Dev Lists
On 3/2/2011 2:05 PM, Mark Thomas wrote: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http

STATUS.txt reviews

2011-03-02 Thread Filip Hanik - Dev Lists
I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our bra

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-03-01 Thread Filip Hanik - Dev Lists
On 2/28/2011 5:27 PM, Mark Thomas wrote: On 01/03/2011 00:16, Filip Hanik - Dev Lists wrote: On 2/28/2011 4:49 PM, Mark Thomas wrote: It isn't clear to me if you are voting -1 on the above commit, and the following commits. r1074675 Understood and agree those commits are broken. I&#

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2011 4:49 PM, Mark Thomas wrote: It isn't clear to me if you are voting -1 on the above commit, and the following commits. r1074675 If you wish to do this, it should at least include: 1. input filters need to check if they retrieved the entire body if only partial, why even attempt a re

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-02-28 Thread Filip Hanik - Dev Lists
e not updated. In short, the NIO code can safely be backed out. The solution is quite simple, and it does not involve modifying the connectors. [1] setNeedClientAuth(true); http://download.oracle.com/javase/6/docs/api/javax/net/ssl/SSLEngine.html#setNeedClientAuth(boolean) best Filip On 2/

Re: [VOTE] Release Apache Tomcat 7.0.9

2011-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2011 12:00 PM, Mark Thomas wrote: On 28/02/2011 18:45, Filip Hanik - Dev Lists wrote: On 2/28/2011 11:30 AM, Mark Thomas wrote: On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote: [X] Broken - do not release http://svn.apache.org/viewvc?rev=1075030&view=rev http://svn.apache

Re: [VOTE] Release Apache Tomcat 7.0.9

2011-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2011 11:30 AM, Mark Thomas wrote: On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote: [X] Broken - do not release http://svn.apache.org/viewvc?rev=1075030&view=rev http://svn.apache.org/viewvc?rev=1074675&view=rev Are not completely correct implementations as they don'

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-02-28 Thread Filip Hanik - Dev Lists
against a trust store, then this valve, must make sure that the validation actually has taken place. Filip On 2/28/2011 11:06 AM, Filip Hanik - Dev Lists wrote: On 2/27/2011 4:30 AM, Mark Thomas wrote: On 25/02/2011 20:16, Filip Hanik - Dev Lists wrote: The simplest solution is, would be

Re: [VOTE] Release Apache Tomcat 7.0.9

2011-02-28 Thread Filip Hanik - Dev Lists
[X] Broken - do not release http://svn.apache.org/viewvc?rev=1075030&view=rev http://svn.apache.org/viewvc?rev=1074675&view=rev Are not completely correct implementations as they don't - support a timeout correctly - dont account for when a write is needed on the selector - they potentially garb

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-02-28 Thread Filip Hanik - Dev Lists
On 2/27/2011 4:30 AM, Mark Thomas wrote: On 25/02/2011 20:16, Filip Hanik - Dev Lists wrote: The simplest solution is, would be to use an individual selector. Register the socket and issue a select() on the thread you are running on. If you want to use a shared selector (like NIO does for reads

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-02-25 Thread Filip Hanik - Dev Lists
This looks like a CPU spinning handshake to me. The operation handshake(true, true); returns an IO interest to be registered with a selector. If the client is slow here or misbehaving, you could end up in a end less loop, and hence we can have introduced a very simple DoS vulnerability here.

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Filip Hanik - Dev Lists
On 02/22/2011 12:59 PM, Mark Thomas wrote: On 22/02/2011 19:34, Filip Hanik - Dev Lists wrote: Wouldn't you build this into the logging framework, instead of one specific component? You could, if you can find an efficient way to spot duplicate log messages and then differen

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Filip Hanik - Dev Lists
Wouldn't you build this into the logging framework, instead of one specific component? best Filip On 02/21/2011 08:21 AM, Mark Thomas wrote: The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. While better monit

Re: svn commit: r1071735 - /tomcat/trunk/modules/jdbc-pool/

2011-02-17 Thread Filip Hanik - Dev Lists
On 02/17/2011 11:50 AM, Konstantin Kolinko wrote: -build.properties -includes -output done thanks - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Connection draining when upload to large

2011-02-10 Thread Filip Hanik - Dev Lists
On 2/10/2011 6:04 AM, Rainer Jung wrote: Servlet 3 standardizes file uploads. It contains the ability to limit on request size, pretty much the same as commons fileupload supported for many years. It seems when this conditions triggers the rest of the request inout stream is still drained at th

Re: svn commit: r1068989 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

2011-02-10 Thread Filip Hanik - Dev Lists
I will fix it. Reattempt is managed in the channel itself at a much lower level. That has always been the case. Adding reattempt here is ambiguous, so I will readjust the interface to return void. best Filip On 2/10/2011 3:36 AM, Konstantin Kolinko wrote: 2011/2/9: Author: fhanik Date: Wed Fe

Re: svn commit: r1068808 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

2011-02-09 Thread Filip Hanik - Dev Lists
I'm glad you commented, there should be no looping at all. It was a left over from a previous proposal fixed in r1068996 Filip On 2/9/2011 2:35 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Wed Feb 9 09:35:16 2011 New Revision: 1068808 URL: http://svn.apache.org/viewvc?rev=1068808&vi

Re: [VOTE] Release build 6.0.32

2011-02-04 Thread Filip Hanik - Dev Lists
On 02/02/2011 12:37 PM, jean-frederic clere wrote: [X] Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-27 Thread Filip Hanik - Dev Lists
On 01/22/2011 11:01 AM, Jim Jagielski wrote: [X] Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1063791 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/RpcChannel.java webapps/docs/changelog.xml

2011-01-26 Thread Filip Hanik - Dev Lists
hmm, it should probably throw the commented out channel exception instead of simply bailing out with the flag set. After all the timeout has not been reached, so the caller should not be tricked into thinking that it has, since no one ever checks the interrupted flag Filip On 01/26/2011 09:5

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-24 Thread Filip Hanik - Dev Lists
I'd opt for the default value to be true. I rather have usability than spec compliance. that's exactly what the STRICT_SERVLET_COMPLIANCE flag does, it opts for usability,performance etc rather than spec compliance, and the default value I believe is false on that flag. Filip On 01/21/2011 11

Re: svn commit: r1061451 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-20 Thread Filip Hanik - Dev Lists
On 1/20/2011 11:45 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Thu Jan 20 18:45:09 2011 New Revision: 1061451 URL: http://svn.apache.org/viewvc?rev=1061451&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apa

Re: Need a 6.0.31 release

2011-01-20 Thread Filip Hanik - Dev Lists
+1 On 1/20/2011 9:09 AM, Mark Thomas wrote: The memory leak in the Tomcat 7 NIO connector [1] got back-ported to 6.0.x and included in 6.0.30. [2] I have proposed the fix for 6.0.x. Given the severity I think we need to approve the backport and start a 6.0.31 release asap. Mark [1] http://s

Re: Tomcat 7.0.x. still CTR?

2011-01-19 Thread Filip Hanik - Dev Lists
I'd prefer to stay CTR for a while. Chances are there are still much to be fixed given all the changes that have taken place. Filip On 1/18/2011 11:41 AM, Christopher Schultz wrote: All, Since Tomcat 7.0.x went stable, does that change the commit policy, or are we still doing commit-them-revie

Re: simple tomcat extension

2011-01-13 Thread Filip Hanik - Dev Lists
can't you just create a directory, drop your jars in there, and in conf/catalina.properties, configure the shared.loader property? best Filip On 1/13/2011 9:05 AM, Juraj Burian wrote: Hello folks, I would like introduce new & very simple extension of Tomcat. In my opinion, many people must ha

Re: [VOTE] Release build 6.0.30

2011-01-11 Thread Filip Hanik - Dev Lists
[X] Stable On 1/10/2011 10:18 AM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.30/ According to the release process, the 6.0.30 build corresponding to the tag TOMCAT_6_0_30 is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable C

Re: DO NOT REPLY [Bug 50333] IllegalArgumentException occurs when setting maxActive to smaller than 1.

2011-01-11 Thread Filip Hanik - Dev Lists
roger that Rainer, thank you! On 1/10/2011 1:43 PM, Rainer Jung wrote: Hi Filip, On 10.01.2011 17:41, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50333 Filip Hanik changed: What|Removed |Added

  1   2   3   4   5   6   7   8   9   10   >