Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/137
> 404/403/401.jsp pages in manager and host-manager may benefit from
localization, and in that case the lang attribute has to be calculated
dynamically to reflect the actual langu
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/110
So you were providing a `Properties` object that was not loaded from a
file, and had non-string values in it? Your patch would not identify that
problem. Non-string values should probably
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/110
What problem does this solve? What property file do you have that contains
non-strings?
---
-
To unsubscribe, e-mail
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/103
Honestly, I would expect `initSQL` to be executed regardless of any other
configuration (e.g. Validator present or not
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/107
Is this "just" a mild performance optimization? It looks like more code
where no more code is needed.
---
--
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/108
I'm starting to lean toward requiring this new feature to require a
configuration option to enable it, and have it default to `false`. My
justification is that it represents a bre
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/108
The performance of this strategy can be significantly improved by
converting the "version number" into a value that can more easily be compared
against other values. This can
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/96
WRT WebDav, [RFC2618](https://tools.ietf.org/html/rfc2518) says that WebDav
is an extension to HTTP/1.1 so I think we are always okay using 405 from
`WebDavServlet`. We should, however
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/96
I think 405 is more appropriate when the method is in fact not allowed
(readOnly). As for POST, there is nothing "writey" about POST, whereas PUT and
DELETE have definite "w
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/96
Patch looks good to me.
Regarding your questions:
> Why is a POST allowed when readOnly is true?
Probably because the DefaultServlet just delegates POST -&g
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/76
@markt-asf re: `Filter` versus configuration
This could be something that we add now just as a `Filter` but in the
future add a configuration option that just automatically
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/79
References:
https://apacheconna2015.sched.com/event/2P6d/rtfm-write-a-better-fm-rich-bowen-apache-software-foundation
http://feathercast.apache.org/podcasts/ApacheConNA2015/Monday
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/79
A few years ago, Rich Bowen gave a talk @ ApacheCon about documentation and
communities. He used Python as an example of a community where the Monty Python
jokes are so pervasive, it
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
Not quite yet. Let's see if we can get it closed automatically through the
"proper" channels.
---
If your project is set up for it, you can reply to this email and have yo
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
I'm not sure why the commit message hasn't closed this issue. Any thoughts
on why that might be?
---
If your project is set up for it, you can reply to this email and have
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
Committed to tomcat-trunk in ASF svn r1799462. Back-ports to follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
Thanks @Igal for your patience with this PR review. I know we've been a bit
of a pain. But this work will make the contribution that much more useful.
---
If your project is set up f
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
I'm waiting on a final review from @KeiichiFujino before I commit.
In the meantime there are 2 `@return` javadoc annotations with no value.
Could you complete those?
---
If
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@isapir FYI `1 << bit` is the same as `(int)Math.pow(2, bit)` and probably
slightly more efficient. Better yet, it's less code to read. No particular
reason to change the
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@KeiichiFujino Okay, so we'd have a synthetic mbean attribute that we can
re-construct from the int value we store internally? Or, do you think we should
save the string that was us
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@KeiichiFujino Is this patch acceptable as-is, with additional patches for
your items listed above? I think it's okay to add this feature only to
channelSendOptions as a first c
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
How would you like your name to appear in the changelog? "Patch provided by
Igal Sapir"?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ChristopherSchultz commented on the pull request:
https://github.com/apache/tomcat/commit/d91d7a802b67ab049b33df9db017ef31d3247450#commitcomment-22378483
@powerYao Because in the distant past, someone decided that having those
extra parentheses was good coding style
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@isapir I appreciate your core patch as an initial effort. It looks like it
will work. In order for it to be a good patch, it needs to be expanded, so a
larger patch is appropriate
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
A few comments:
1. I think the patch should include some TRACE-level logging, especially
when catching the NumberFormatException.
2. If there is an unrecognized option string
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/51
Might this be better written as `SELECT ... FOR UPDATE` with either
`updateRow` or `ResultSet.insert` if there are no results from the `SELECT`?
---
If your project is set up for it, you
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/41
You should use SELECT ... FOR UPDATE instead of SELECT / UPDATE. Much less
code and transactionally-safe. Also, if you use SELECT ... FOR UPDATE, you can
use ResultSet.moveToInsertRow to
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/39
This looks like a no-op change. Does the CONNECT verb not imply a default
port number when none is present?
---
If your project is set up for it, you can reply to this email and have your
28 matches
Mail list logo
