Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
markt-asf commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2896763570 Thanks for the `ifconfig` output. Configuration seems very similar. I installed Docker in case that was a factor but that didn't help trigger the issue. I still can't recreate this issue.

Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]

2025-05-20 Thread via GitHub
michael-o commented on code in PR #858: URL: https://github.com/apache/tomcat/pull/858#discussion_r2099371131 ## bin/catalina.bat: ## @@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLo

Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]

2025-05-20 Thread via GitHub
mhoffrog commented on PR #858: URL: https://github.com/apache/tomcat/pull/858#issuecomment-2895493402 > Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same two separators, that JvmOptions can use. Namely ";" and "#". Currently we use ";" for JvmOptions and "#" for Jvm

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
markt-asf commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2895192922 I'm very reluctant to make changes until I understand the root cause of an issue - especially in an area such as networking where there can be subtle behaviour differences across platforms

Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]

2025-05-20 Thread via GitHub
rainerjung commented on PR #858: URL: https://github.com/apache/tomcat/pull/858#issuecomment-2895052975 Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same two separators, that JvmOptions can use. Namely ";" and "#". Currently we use ";" for JvmOptions and "#" for Jvm

[Bug 69696] Unexpected jsp page result if inner class changed to compilation error

2025-05-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69696 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Buildbot failure in on tomcat-10.1.x

2025-05-20 Thread buildbot
Build status: BUILD FAILED: Snapshot deployed to ASF Maven snapshot repository (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/1755 Blamelist: remm Build Text: Snapshot deployed to ASF Maven snapshot repository (failure) Status Detected: new failure Build

Buildbot failure in on tomcat-11.0.x

2025-05-20 Thread buildbot
Build status: BUILD FAILED: Snapshot deployed to ASF Maven snapshot repository (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/1674 Blamelist: remm Build Text: Snapshot deployed to ASF Maven snapshot repository (failure) Status Detected: new failure Build

Buildbot failure in on tomcat-12.0.x

2025-05-20 Thread buildbot
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot repository (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/120/builds/557 Blamelist: remm Build Text: failed Snapshot deployed to ASF Maven snapshot repository (failure) Status Detected: new

(tomcat) branch 9.0.x updated: Mark the JSP wrapper for reload after a compilation

2025-05-20 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e97e430c70 Mark the JSP wrapper for reload after a c

(tomcat) branch 10.1.x updated: Mark the JSP wrapper for reload after a compilation

2025-05-20 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new ca3c961f58 Mark the JSP wrapper for reload after a

(tomcat) branch 11.0.x updated: Mark the JSP wrapper for reload after a compilation

2025-05-20 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new f52cfe4698 Mark the JSP wrapper for reload after a

(tomcat) branch main updated: Mark the JSP wrapper for reload after a compilation

2025-05-20 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3c7e0e5fae Mark the JSP wrapper for reload after a com

[Bug 69696] Unexpected jsp page result if inner class changed to compilation error

2025-05-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69696 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Mauchera

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
rmannibucau commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2894460535 @markt-asf hmm, think it is current status: tomcat does: > ServerSocketChannel.open() which ends in > ServerSocketChannelImpl(SelectorProvider sp) throw

Re: [PR] [Bug 69693] - Improve readability and type safety by changing parsingRequestLinePhase to an enum in Http11InputBuffer [tomcat]

2025-05-20 Thread via GitHub
YongGoose commented on PR #855: URL: https://github.com/apache/tomcat/pull/855#issuecomment-2894390398 Personally, I think this PR is worth reviewing! Using enums is definitely easier to understand than using integers like `0` and `1`. -- This is an automated message from the Apache Gi

[Bug 69693] Improve readability and type safety by changing parsingRequestLinePhase to an enum in Http11InputBuffer

2025-05-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69693 --- Comment #3 from injae.kim@gmail.com --- I also think refactoring by enum here looks much better for code readability :) -- You are receiving this mail because: You are the assignee for the bug. -

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
markt-asf commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893838723 May have unintended consequences for dual-stack systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
rmannibucau commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893829754 @markt-asf any reason to not enforce family in org.apache.tomcat.util.net.NioEndpoint#initServerSocket based on addr ? updated the PR in that sense -- This is an automated message fro

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
rmannibucau commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893807955 @markt-asf no vpn, just a plain default setup with this /etc/hosts: ``` 127.0.0.1 localhost local.dev 127.0.1.1 romain # The following lines are desirable for IPv6 capa

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
markt-asf commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893802873 Just downloading the iso to try and reproduce this. Any networking configured beyond the default using DHCP such as a VPN? -- This is an automated message from the Apache Git Service. To

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
rmannibucau commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893783262 Interesting, so adding `-Djava.net.preferIPv4Stack=true` i do not have the error anymore and indeed the error seems to come from the fact i'm using "localhost" so i enter into `localAddr

(tomcat) branch 10.1.x updated: Add support for the java:module namespace

2025-05-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new eb98272d1d Add support for the java:module namesp

Re: [PR] [fix] ensure that when acceptor is stopped it doesn't log an error for nothing [tomcat]

2025-05-20 Thread via GitHub
markt-asf commented on PR #857: URL: https://github.com/apache/tomcat/pull/857#issuecomment-2893704284 Tx. That helps. The unlock is trying to use an IPv6 address to unlock the Acceptor which Tomcat doesn't appear to be listening on. I'll see if I can reproduce this but if I can't, I'll add

[Bug 69696] New: Unexpected jsp page result if inner class changed to compilation error

2025-05-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69696 Bug ID: 69696 Summary: Unexpected jsp page result if inner class changed to compilation error Product: Tomcat 11 Version: 11.0.6 Hardware: PC Status: NEW

(tomcat) branch main updated: Add support for the java:module namespace

2025-05-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b930a040f5 Add support for the java:module namespace

(tomcat) branch 11.0.x updated: Add support for the java:module namespace

2025-05-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new de33f61aaa Add support for the java:module namesp

(tomcat) branch 9.0.x updated: Add support for the java:module namespace

2025-05-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 28032632e9 Add support for the java:module namespac