Re: [PR] BZ69446 - add parameter maxPutFileSize in DefaultServlet [tomcat]

2025-02-19 Thread via GitHub
Chenjp commented on PR #823: URL: https://github.com/apache/tomcat/pull/823#issuecomment-2670712406 Ok, final decision ups to you. Write is reserved to administrators... If share this standard, would to know your opinion on RCE [CVE-2017-12617](http://cve.mitre.org/cgi-bin/cvename.c

Re: [PR] BZ69446 - add parameter maxPutFileSize in DefaultServlet [tomcat]

2025-02-19 Thread via GitHub
rmaucher commented on PR #823: URL: https://github.com/apache/tomcat/pull/823#issuecomment-2670663780 We answered this quite a few times already, so let's leave it at that. Write enabled allows editing webapp contents, which is reserved to administrators. -- This is an automated message f

Re: [PR] BZ69446 - add parameter maxPutFileSize in DefaultServlet [tomcat]

2025-02-19 Thread via GitHub
rmaucher closed pull request #823: BZ69446 - add parameter maxPutFileSize in DefaultServlet URL: https://github.com/apache/tomcat/pull/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] BZ69446 - add parameter maxPutFileSize in DefaultServlet [tomcat]

2025-02-19 Thread via GitHub
Chenjp commented on PR #823: URL: https://github.com/apache/tomcat/pull/823#issuecomment-2670515402 @rmaucher @markt-asf I have to talk here since previous vul report has been rejected. I really think the target issue of this PR is a perfect match of CWE-770 / CWE-400. ***```The product all

Re: [PR] Enhance case sensitivity check [tomcat]

2025-02-19 Thread via GitHub
Chenjp commented on PR #820: URL: https://github.com/apache/tomcat/pull/820#issuecomment-2670122793 +1 Since create a case sensitivity verification file is not a good idea, then treats all as insensitive simply, remove the indicator. see PR #829. -- This is an automated message

[PR] WebResource read/write lock key changed to in lowercase arbitrarily [tomcat]

2025-02-19 Thread via GitHub
Chenjp opened a new pull request, #829: URL: https://github.com/apache/tomcat/pull/829 Discarding the file name case sensitivity of resource directory. Detection of a directory case sensitivity is expansive, we have to create file with different upper/lower case name and check result.

Re: Case sensitivity checks

2025-02-19 Thread Rémy Maucherat
On Wed, Feb 19, 2025 at 7:15 PM Mark Thomas wrote: > > All, > > A case sensitivity test was added to DirResourceSet as part of the fix > for CVE-2024-50379. It is also used to check whether the JVM setting > described in CVE-2024-56337 is required. > > The current case sensitivity check is imperfe

Case sensitivity checks

2025-02-19 Thread Mark Thomas
All, A case sensitivity test was added to DirResourceSet as part of the fix for CVE-2024-50379. It is also used to check whether the JVM setting described in CVE-2024-56337 is required. The current case sensitivity check is imperfect. Things are complicated by: - Windows introducing per direc

Re: [PR] Enhance case sensitivity check [tomcat]

2025-02-19 Thread via GitHub
markt-asf commented on PR #820: URL: https://github.com/apache/tomcat/pull/820#issuecomment-2669367602 Mounting case insensitive file systems on Linux adds yet more complexity. And I don't see an easy way to address that - especially if we want to avoid creating files to test case sensitivi

Buildbot failure in on tomcat-12.0.x

2025-02-19 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/120/builds/387 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main] 11056e8d52069f4270095f396047beb9fbba0e

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
markt-asf closed pull request #819: SpnegoAuthenticator allows wrong calls to login/logout methods URL: https://github.com/apache/tomcat/pull/819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
markt-asf commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2669268717 Thanks for the test case and the detailed configuration settings. That made working on this a lot easier. I have applied a fairly narrow fix for this issue that is similar to the `M

(tomcat) branch 11.0.x updated: Fix credential validation when JNDIRealm is configured to use GSSAPI

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new fd96ab4156 Fix credential validation when JNDIRea

(tomcat) branch 9.0.x updated: Fix credential validation when JNDIRealm is configured to use GSSAPI

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c32bbd37ea Fix credential validation when JNDIRealm

(tomcat) branch 10.1.x updated: Fix credential validation when JNDIRealm is configured to use GSSAPI

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 0cd21c0393 Fix credential validation when JNDIRea

(tomcat) branch main updated: Fix credential validation when JNDIRealm is configured to use GSSAPI

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 99e3403b0d Fix credential validation when JNDIRealm i

(tomcat) branch 11.0.x updated: Use a constant for GSSAPI authentication name

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new e2586cbc62 Use a constant for GSSAPI authenticati

(tomcat) branch 9.0.x updated: Ensure user credentials are removed when no longer required

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new bdd8318130 Ensure user credentials are removed when

(tomcat) branch 10.1.x updated: Ensure user credentials are removed when no longer required

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 34c94915e5 Ensure user credentials are removed wh

(tomcat) branch 11.0.x updated: Ensure user credentials are removed when no longer required

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new ac3208e4b1 Ensure user credentials are removed wh

(tomcat) branch main updated: Ensure user credentials are removed when no longer required

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 66372303a7 Ensure user credentials are removed when n

(tomcat) branch 9.0.x updated: Use a constant for GSSAPI authentication name

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 85e322aa5a Use a constant for GSSAPI authentication

(tomcat) branch 10.1.x updated: Use a constant for GSSAPI authentication name

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 32082b6712 Use a constant for GSSAPI authenticati

(tomcat) branch main updated (11056e8d52 -> 2e0542a0d1)

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 11056e8d52 Improve docs for useDelegatedCredential add 2e0542a0d1 Use a constant for GSSAPI authentication name No

(tomcat) branch 9.0.x updated: Improve docs for useDelegatedCredential

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new cc58f50880 Improve docs for useDelegatedCredential

(tomcat) branch 10.1.x updated: Improve docs for useDelegatedCredential

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new a6c40b8765 Improve docs for useDelegatedCredentia

(tomcat) branch 11.0.x updated: Improve docs for useDelegatedCredential

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 9625583ab6 Improve docs for useDelegatedCredentia

(tomcat) branch main updated (5708495734 -> 11056e8d52)

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 5708495734 Move constant to start of class add 11056e8d52 Improve docs for useDelegatedCredential No new revisions

(tomcat) branch 10.1.x updated: Move constant to start of class

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 79509006d6 Move constant to start of class 795090

(tomcat) branch 9.0.x updated: Move constant to start of class

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 603aa2eb24 Move constant to start of class 603aa2eb

(tomcat) branch 11.0.x updated: Move constant to start of class

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new c037d2148d Move constant to start of class c037d2

(tomcat) branch main updated: Move constant to start of class

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 5708495734 Move constant to start of class 5708495734

[Bug 69575] org.apache.coyote.CompressionConfig doesn't recognize "zstd" compression

2025-02-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69575 --- Comment #4 from Christopher Schultz --- I'm happy to add this capability, but it's not immediately clear to be how to get all of the current Content-Encoding header values. Would I actually have to loop through all headers, assembling as I

[Bug 69575] org.apache.coyote.CompressionConfig doesn't recognize "zstd" compression

2025-02-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69575 Christopher Schultz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXE

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
markt-asf commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2668964117 I don't expect the bind to use kerberos, I am debugging my way through the code and seeing kerberos being used. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
michael-o commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2668906926 > > It is not that easy and I do not agree with that. Here are cases which will not work: > > As the OP has indicated, they are already using a solution along these lines and it wor

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
markt-asf commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2668831744 > It is not that easy and I do not agree with that. Here are cases which will not work: As the OP has indicated, they are already using a solution along these lines and it works for

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
natalia-s-ivanova commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2668518211 > 2. If user/password auth is attempted when `authentication="GSSAPI"` then remove the environment properties that configured GSSAPI, perform user/password authentication and then

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
michael-o commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2668513322 > I think the current support for `logout()` can stay. I don't see a reason to change it. > > I think the issue with `login()` is slightly different. The `JNDIRealm` attempts to swi

Re: [PR] SpnegoAuthenticator allows wrong calls to login/logout methods [tomcat]

2025-02-19 Thread via GitHub
markt-asf commented on PR #819: URL: https://github.com/apache/tomcat/pull/819#issuecomment-2668483655 I think the current support for `logout()` can stay. I don't see a reason to change it. I think the issue with `login()` is slightly different. The `JNDIRealm` attempts to switch be

(tomcat) branch main updated (0113948270 -> 3f7bb7fa19)

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 0113948270 69575: Avoid using compression if a response is already compressed add 3f7bb7fa19 Fix copy/paste error i

[Bug 69530] Major different between 10.1.31 and 10.1.34 (class file doLock Method)

2025-02-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69530 --- Comment #7 from Remy Maucherat --- Without additional information, this issue will be resolved as invalid. Testing 10.1.36 could be worthwhile as the request body processing code was refined. -- You are receiving this mail because: You ar

[Bug 69575] org.apache.coyote.CompressionConfig doesn't recognize "zstd" compression

2025-02-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69575 --- Comment #2 from Todor Bonchev --- The fix: https://github.com/apache/tomcat/commit/01139482700c1a850bec9d5efea93a778615b211 will cover zstd, compress and deflate, but to make it future proof you should check on line 291 whether an encoding

(tomcat) branch 10.1.x updated: Fix copy/paste error in Javadoc

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 210a0d552e Fix copy/paste error in Javadoc 210a0d

(tomcat) branch 9.0.x updated: Fix copy/paste error in Javadoc

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e8ae34b9fa Fix copy/paste error in Javadoc e8ae34b9

(tomcat) branch 11.0.x updated: Fix copy/paste error in Javadoc

2025-02-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new d40c587727 Fix copy/paste error in Javadoc d40c58

[Bug 69575] org.apache.coyote.CompressionConfig doesn't recognize "zstd" compression

2025-02-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69575 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW