koust6u commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657908424
@n828cl
Which part do you find harder to follow? If you could clarify, it would help
me understand better.
I also believe that calling `isSameOrigin()` before `isValidOrigin()`
dsoumis commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657902498
The revised code, though less nested, adheres to the CORS flow as specified.
In my opinion, this structure offers a more maintainable and understandable
implementation.
Also the ordering
n828cl commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657751803
If this were to be merged, the CORS flowchart should be updated accordingly.
See
--
This is an automated mes
n828cl commented on PR #826:
URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657748693
I'm not sure that the revised code properly implements the spec.
(Unfortunately, the current spec is much harder to follow than the previous
iteration.) Also, calling IsSameOrigin() before is
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 3d967dddad Clean up check CORS request type metho
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 73d5ee6afd Clean up check CORS request type met
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new ad2f570cde Clean up check CORS request type met
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new a4ccdba4bf Clean up check CORS request type method
dsoumis merged PR #826:
URL: https://github.com/apache/tomcat/pull/826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Am 13.02.25 um 18:56 schrieb Christopher Schultz:
All,
There is ONE problem with this release, which I think does not require a
replacement, but I'm open to a veto.
The changelog has 10.1.35 listed twice in it. One for the actual 10.1.35
and one for 10.1.36. It was due to a typo when I incre
I also believe this minor typographical error doesn't justify a replacement
release.
Kind regards,
Dimitris
On Thu, Feb 13, 2025 at 8:04 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:
> All,
>
> There is ONE problem with this release, which I think does not require a
> replacement
Mark,
On 2/13/25 11:45 AM, Mark Thomas wrote:
Draft announcement as promised.
Once we have something we are happy with, I'll post it to announce@ and
users@
Mark
Subject: Tomcat 9.0.x End of Support and Extended Support for Tomcat 9
This subject line is confusing. It implies that Tomcat
All,
There is ONE problem with this release, which I think does not require a
replacement, but I'm open to a veto.
The changelog has 10.1.35 listed twice in it. One for the actual 10.1.35
and one for 10.1.36. It was due to a typo when I incremented the version
numbers after 10.1.35 and I did
+1 Build is reproducible and all tests pass on Fedora 41 with Java 21,
tcnative-2.0.8, apr-1.7.4, openssl-3.0.15.
On Thu, Feb 13, 2025 at 3:38 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:
> The proposed Apache Tomcat 10.1.36 release is now available for
> voting.
>
> All committe
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 1dc412b8b0 Add makensis as an option for building t
Draft announcement as promised.
Once we have something we are happy with, I'll post it to announce@ and
users@
Mark
Subject: Tomcat 9.0.x End of Support and Extended Support for Tomcat 9
Tomcat 9 is the last major Tomcat version supporting Java EE. Therefore,
the Tomcat community intends t
On 13/02/2025 12:40, Rémy Maucherat wrote:
The proposed 9.0.100 release is:
[ ] -1, Broken - do not release
[X] +1, Stable - go ahead and release as 9.0.100
Build is cross platform (Linux/Windows) reproducible.
Tests pass on:
- Linux (OpenSSL 3.0.13 from Ubuntu 24.04)
- Windows (OpenSSL 3.0.1
+1 Build is reproducible and all tests pass on Fedora 41 with Java 21,
tcnative-2.0.8, apr-1.7.4, openssl-3.0.15.
On Thu, Feb 13, 2025 at 1:23 PM Mark Thomas wrote:
> The proposed Apache Tomcat 11.0.4 release is now available for voting.
>
> The notable changes compared to 11.0.3 include:
>
> -
On Thu, Feb 13, 2025 at 10:36 AM Mark Thomas wrote:
> I haven't seen any further discussion so I am going to draft an
> announcement for review that I'll post this list.
>
Thanks for doing this! I somehow missed the thread before, but I'm +1 for
the current plan of action.
> Mark
>
>
>
> On 04
+1 Build is reproducible and all tests pass on Fedora 41 with Java 21,
tcnative-1.3.0, apr-1.7.4, openssl-3.0.15.
On Thu, Feb 13, 2025 at 2:49 PM Rémy Maucherat wrote:
> The proposed Apache Tomcat 9.0.100 release is now available for voting.
>
> The notable changes compared to 9.0.99 are:
>
> -
I haven't seen any further discussion so I am going to draft an
announcement for review that I'll post this list.
Mark
On 04/02/2025 21:14, Christopher Schultz wrote:
Mark,
On 2/3/25 11:00 AM, Mark Thomas wrote:
Responding to all the threads here...
On 03/02/2025 13:40, Christopher Schult
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new d49abb6df9 Add makensis as an option for building
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 5595e423c8 Add makensis as an option for building
All,
On 2/13/25 8:24 AM, Christopher Schultz wrote:
The proposed Apache Tomcat 10.1.36 release is now available for
voting.
All committers and PMC members are kindly requested to provide a vote if
possible. ANY TOMCAT USER MAY VOTE, though only PMC members votes are
binding. We welcome non-co
On 13/02/2025 13:24, Christopher Schultz wrote:
Please reply with a +1 for release or +0/-0/-1 with an explanation.
+1
Build is cross platform (OSX/Linux) reproducible.
Tests pass on:
- Linux (OpenSSL 3.0.13 from Ubuntu 24.04)
- Windows (OpenSSL 3.0.14 - Native 2.0.8 binaries)
- MacOS (Intel
Mark,
Thanks for RMing.
On 2/13/25 6:16 AM, Mark Thomas wrote:
The proposed Apache Tomcat 11.0.4 release is now available for voting.
The notable changes compared to 11.0.3 include:
- Fix 69576. Add a catch for InaccessibleObjectException to avoid
embedded users having to add an additional
Rémy,
Thanks for RMing.
On 2/13/25 7:40 AM, Rémy Maucherat wrote:
The proposed Apache Tomcat 9.0.100 release is now available for voting.
The notable changes compared to 9.0.99 are:
- Fix 69576. Add a catch for InaccessibleObjectException to avoid
embedded users having to add an additiona
Author: markt
Date: Thu Feb 13 13:56:09 2025
New Revision: 74893
Log:
Drop old releases from CDN
Removed:
release/tomcat/tomcat-10/v10.1.34/
release/tomcat/tomcat-11/v11.0.2/
release/tomcat/tomcat-9/v9.0.98/
-
To un
The proposed Apache Tomcat 10.1.36 release is now available for
voting.
All committers and PMC members are kindly requested to provide a vote if
possible. ANY TOMCAT USER MAY VOTE, though only PMC members votes are
binding. We welcome non-committer votes or comments on release builds.
The not
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to tag 10.1.36
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 23f54e56911d0f4ecfbd3b8c2dab5f170c675dc4
Author: Christopher Schultz
AuthorDate: Thu Feb 13 08:15:58 2025 -0500
Tag
Author: schultz
Date: Thu Feb 13 13:17:40 2025
New Revision: 74891
Log:
Upload v10.1.36 for voting
Added:
dev/tomcat/tomcat-10/v10.1.36/
dev/tomcat/tomcat-10/v10.1.36/KEYS
dev/tomcat/tomcat-10/v10.1.36/README.html
dev/tomcat/tomcat-10/v10.1.36/RELEASE-NOTES
dev/tomcat/tomcat-1
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a change to tag 10.1.36
in repository https://gitbox.apache.org/repos/asf/tomcat.git
at 23f54e5691 (commit)
This tag includes the following new commits:
new 23f54e5691 Tag 10.1.36
The 1 revisions list
The proposed Apache Tomcat 9.0.100 release is now available for voting.
The notable changes compared to 9.0.99 are:
- Fix 69576. Add a catch for InaccessibleObjectException to avoid
embedded users having to add an additional --add-opens
- Add a JSON formatter to JULI
For full details, see th
Author: remm
Date: Thu Feb 13 12:20:01 2025
New Revision: 74886
Log:
Upload Tomcat 9.0.100 for voting
Added:
dev/tomcat/tomcat-9/v9.0.100/
dev/tomcat/tomcat-9/v9.0.100/KEYS
dev/tomcat/tomcat-9/v9.0.100/README.html
dev/tomcat/tomcat-9/v9.0.100/RELEASE-NOTES
dev/tomcat/tomcat-9/
This is an automated email from the ASF dual-hosted git repository.
remm pushed a change to tag 9.0.100
in repository https://gitbox.apache.org/repos/asf/tomcat.git
at ef8388bc13 (commit)
This tag includes the following new commits:
new ef8388bc13 Tag 9.0.100
The 1 revisions listed
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to tag 9.0.100
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit ef8388bc13ee06dc1d4402da0c5ca8708c906832
Author: remm
AuthorDate: Thu Feb 13 13:09:57 2025 +0100
Tag 9.0.100
---
build
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 1028e8dd9f0fc5c07d83979ecdc76748ca796211
Author: Mark Thomas
AuthorDate: Thu Feb 13 11:27:50 2025 +
Increment ve
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit abdb4e4a62f83e54a5e6b14757145e7106864d40
Author: Mark Thomas
AuthorDate: Thu Feb 13 11:27:24 2025 +
Add release
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from ed089ebbd0 Fix oops with the log test
new abdb4e4a62 Add release date for 11.0.3
new 1028e8dd9f Increment ver
On 13/02/2025 11:16, Mark Thomas wrote:
The proposed 11.0.4 release is:
[ ] -1 Broken - do not release
[X] +1 Stable - go ahead and release as 11.0.4
Build is cross platform (Linux/Windows) reproducible.
Tests pass on:
- Linux (OpenSSL 3.0.13 from Ubuntu 24.04)
- Windows (OpenSSL 3.0.14 - Nat
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 8be9abaed5 Update 12.0.x baseline to 11.0.4
8be9abaed
Author: markt
Date: Thu Feb 13 11:09:29 2025
New Revision: 74885
Log:
Upload 11.0.4 for voting
Added:
dev/tomcat/tomcat-11/v11.0.4/
dev/tomcat/tomcat-11/v11.0.4/KEYS
dev/tomcat/tomcat-11/v11.0.4/README.html
dev/tomcat/tomcat-11/v11.0.4/RELEASE-NOTES
dev/tomcat/tomcat-11/v11.0.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to tag 11.0.4
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 41f56e094dc101d787016fe0a100210f108e6f51
Author: Mark Thomas
AuthorDate: Thu Feb 13 10:46:22 2025 +
Tag 11.0.4
---
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to tag 11.0.4
in repository https://gitbox.apache.org/repos/asf/tomcat.git
at 41f56e094d (commit)
This tag includes the following new commits:
new 41f56e094d Tag 11.0.4
The 1 revisions listed a
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|NEEDINFO
--- Comment #9 from Mark Thomas
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-tck.git
The following commit(s) were added to refs/heads/main by this push:
new 6525a18 Update ci.yml
6525a18 is described below
46 matches
Mail list logo
