Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1940452423 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) { //

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1940452423 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) { //

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
Dmole commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631976321 Looks like it was not "intentional" after all https://github.com/apache/tomcat/commit/904701a434325534b856b70f085dbe1dee05c43a -- This is an automated message from the Apache Git Service.

Re: [PR] log connectionId [tomcat]

2025-02-03 Thread via GitHub
Dmole commented on PR #814: URL: https://github.com/apache/tomcat/pull/814#issuecomment-2631971994 I added it to both AccessLogValve and ExtendedAccessLogValve because it is non-trivial for users to switch between them as the documentation does not provide a mapping (EG: %v = ?), and the ex

[Bug 69532] Performance optimization in Util.getExpressionFactory()

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532 Matafagafo changed: What|Removed |Added CC||matafag...@gmail.com -- You are receivin

(tomcat) 04/04: Improvements to Japanese translations by tak7iji.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9647a025443861f6fb6159b9c90f91dba6c7e7b4 Author: Mark Thomas AuthorDate: Mon Feb 3 17:00:39 2025 + Improvements t

(tomcat) 02/04: Improvements to French translations. (remm)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 5a46a0ab4388324c1fb6e39c91f73446c39f9389 Author: Mark Thomas AuthorDate: Mon Feb 3 16:59:39 2025 + Improvements t

(tomcat) branch 9.0.x updated (6c4d98d17e -> 9647a02544)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 6c4d98d17e Fix BZ 69559 - Avoid 24 warning when not relevant new 22f2d552bd Refactor into more, shorter tests to ai

(tomcat) 03/04: Improvements to Chinese translations by leeyazhou.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a001d52752134df5345330f106fc31cfd6a75189 Author: Mark Thomas AuthorDate: Mon Feb 3 17:00:19 2025 + Improvements t

(tomcat) branch 10.1.x updated: Improvements to Chinese translations by leeyazhou.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 98ab5cdc81 Improvements to Chinese translations b

(tomcat) branch 10.1.x updated: Improvements to Japanese translations by tak7iji.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new bb82e3c039 Improvements to Japanese translations

(tomcat) 02/02: Improvements to French translations. (remm)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6d890d4f50237b7e3b4fb9dba3488c6c6f3c2fbe Author: Mark Thomas AuthorDate: Mon Feb 3 16:50:47 2025 + Improvements

(tomcat) branch 10.1.x updated (aab33c8373 -> 6d890d4f50)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from aab33c8373 Fix BZ 69559 - Avoid 24 warning when not relevant new e4d9aaf058 Refactor into more, shorter tests to a

(tomcat) branch 11.0.x updated: Improvements to Chinese translations by leeyazhou.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 516361127a Improvements to Chinese translations b

(tomcat) branch 11.0.x updated: Improvements to Japanese translations by tak7iji.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new b6e0265ccc Improvements to Japanese translations

(tomcat) branch 11.0.x updated: Alphabetical order

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 8af919e914 Alphabetical order 8af919e914 is descr

(tomcat) branch 11.0.x updated (14f25027c7 -> 0fdefcc1a6)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 14f25027c7 Fix BZ 69559 - Avoid 24 warning when not relevant new bda90a6f6a Refactor into more, shorter tests to a

(tomcat) 02/02: Improvements to French translations. (remm)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0fdefcc1a62297e19790621d8fe746524d1cf8a4 Author: Mark Thomas AuthorDate: Mon Feb 3 16:46:25 2025 + Improvements

(tomcat) branch main updated: Improvements to Chinese translations by leeyazhou.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f8a5af4107 Improvements to Chinese translations by le

(tomcat) branch main updated: Improvements to Japanese translations by tak7iji.

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new cde3480c6d Improvements to Japanese translations by t

(tomcat) branch main updated: Improvements to French translations. (remm)

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d8c4a6e084 Improvements to French translations. (remm

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939680064 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) {

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939672492 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -145,7 +138,7 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) {

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939662587 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -145,7 +138,7 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) {

Re: Tomcat 9 extended support

2025-02-03 Thread Mark Thomas
Responding to all the threads here... On 03/02/2025 13:40, Christopher Schultz wrote: 3. What minimum version of Java do we want to support? Stick with Java 8? Increase the minimum version in line with availability of free supported JREs (e.g. from Temurin)? Something else? There are some

[Bug 69559] WARNING: sun.misc.Unsafe::invokeCleaner has been called by org.apache.tomcat.util.buf.ByteBufferUtils

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69559 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

(tomcat) branch 9.0.x updated: Fix BZ 69559 - Avoid 24 warning when not relevant

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6c4d98d17e Fix BZ 69559 - Avoid 24 warning when not

(tomcat) branch 10.1.x updated: Fix BZ 69559 - Avoid 24 warning when not relevant

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new aab33c8373 Fix BZ 69559 - Avoid 24 warning when n

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939607782 ## test/org/apache/tomcat/util/http/TestRequestUtilSameOrigin.java: ## @@ -42,6 +42,8 @@ public static Collection parameters() { TesterRequest request2 = new Test

(tomcat) branch 11.0.x updated: Fix BZ 69559 - Avoid 24 warning when not relevant

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 14f25027c7 Fix BZ 69559 - Avoid 24 warning when n

(tomcat) branch main updated: Fix BZ 69559 - Avoid 24 warning when not relevant

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 68ec5edf3e Fix BZ 69559 - Avoid 24 warning when not r

[Bug 69559] WARNING: sun.misc.Unsafe::invokeCleaner has been called by org.apache.tomcat.util.buf.ByteBufferUtils

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69559 Mark Thomas changed: What|Removed |Added Resolution|WONTFIX |--- Status|RESOLVED

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
funkman commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939578798 ## test/org/apache/tomcat/util/http/TestRequestUtilSameOrigin.java: ## @@ -42,6 +42,8 @@ public static Collection parameters() { TesterRequest request2 = new Test

(tomcat) branch main updated: Work around null checks if passing null cert password

2025-02-03 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 904701a434 Work around null checks if passing null cer

[Bug 69562] External Clothing Brand

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69562 --- Comment #1 from Chuck Caldarale --- The content of attachment 39987 has been deleted for the following reason: Spam -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69562] SPAM SPAM SPAM SPAM

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69562 Chuck Caldarale changed: What|Removed |Added OS||All Resolution|---

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
Dmole commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631122523 When editing the documentation please explain how requiring an empty password, in a text file, in an unrelated attribute, qualifies as security, and not just obscurity. -- This is an automa

[PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u opened a new pull request, #818: URL: https://github.com/apache/tomcat/pull/818 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Replace \r\n with SimpleHttpClient.CRLF in Http2TestBase & Cleanup RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u closed pull request #817: Replace \r\n with SimpleHttpClient.CRLF in Http2TestBase & Cleanup RequestUtil URL: https://github.com/apache/tomcat/pull/817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
rmaucher commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631082908 > @rmaucher This is something worth mentioning in https://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_noteable_changes for 9.0.83 and similar releases in the other branches. It's

Re: Tomcat 9 extended support

2025-02-03 Thread Christopher Schultz
Mark, On 1/30/25 11:50 AM, Mark Thomas wrote: We have discussed plans for extended Tomcat 9 support several times. It is still probably a couple of years away but I thought it would be worth starting the discussion again. There are a wide range of options. This is a brain dump of the question

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
ChristopherSchultz commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631002992 @rmaucher This is something worth mentioning in https://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_noteable_changes for 9.0.83 and similar releases in the other branches. -

[Bug 69539] Zero content length can be return with many concurrent requests

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69539 adrie...@opentext.com changed: What|Removed |Added CC||adrie...@opentext.com -- You a

Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2630705976 `getResourceAsStream()` is documented to accept a name, not a URL. I'd like to understand the use case better before making any changes. Can you provide some sample code or a test case or

Buildbot success in on tomcat-12.0.x

2025-02-03 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/120/builds/353 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] c59a4b5757583e3175c8d3d5a087928990779901 Steps: worker_prepa

[Bug 69562] New: External Clothing Brand

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69562 Bug ID: 69562 Summary: External Clothing Brand Product: Tomcat Native Version: unspecified Hardware: PC Status: NEW Severity: normal Priority: P2 Com

Re: [PR] log connectionId [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #814: URL: https://github.com/apache/tomcat/pull/814#issuecomment-2630509072 This is not the way to do this. Look at the ExtendedAccessLogValve. Look at `x-H(...)` options. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Replace \r\n with SimpleHttpClient.CRLF in Http2TestBase & Cleanup RequestUtil [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #817: URL: https://github.com/apache/tomcat/pull/817#issuecomment-2630498955 1 change per PR please. Note that we try to avoid static imports if at all possible. -- This is an automated message from the Apache Git Service. To respond to the message, please

[Bug 69532] Performance optimization in Util.getExpressionFactory()

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

(tomcat) branch 9.0.x updated: Limit maximum memory to 256m for test threads

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b4869918e6 Limit maximum memory to 256m for test th

(tomcat) branch 10.1.x updated: Limit maximum memory to 256m for test threads

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 65236d77ab Limit maximum memory to 256m for test

(tomcat) branch 11.0.x updated: Limit maximum memory to 256m for test threads

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 9414daabec Limit maximum memory to 256m for test

(tomcat) branch main updated: Limit maximum memory to 256m for test threads

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1dbe55ee39 Limit maximum memory to 256m for test thre

(tomcat) branch 9.0.x updated: Fix BZ 69532 - Optimise the creation of ExpressionFactory instances

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 60c50b8ee0 Fix BZ 69532 - Optimise the creation of

(tomcat) branch 10.1.x updated: Fix BZ 69532 - Optimise the creation of ExpressionFactory instances

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 3534f402ed Fix BZ 69532 - Optimise the creation o

(tomcat) branch 11.0.x updated: Fix BZ 69532 - Optimise the creation of ExpressionFactory instances

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 1eef0d9fb8 Fix BZ 69532 - Optimise the creation o

(tomcat) branch main updated: Fix BZ 69532 - Optimise the creation of ExpressionFactory instances

2025-02-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c59a4b5757 Fix BZ 69532 - Optimise the creation of Ex

[Bug 69365] Expose option for WebResource to determine it is read-only/read-write for DefaultServlet/WebdavServlet

2025-02-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69365 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---