jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448361853
Changes are committed as discussed, ready for re-review. Specifically:
1. Cache is removed, fast-path is added for zero-arg cases
1. Unit tests are added for:
- Zero-args method look
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448199694
Actually, it does belong to us. It isn't part of the public API. We are free
to change it how we wish. If you compare our version to the equivalent code in
the EL API JAR from Jakarta EE t
ChristopherSchultz commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448176904
> @ChristopherSchultz what prevents changes to `javax.el.Util`?
That class doesn't "belong" to us. Depending upon how it changes, we might
fail the TCK. It's just better to
jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448111787
This complexity led me to try a fallback plan, which can be faster: if the
method has zero parameters, retrieve the Method by name. This works because
there is no confusion about parameter
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448093530
I think the changes will have to go into `Util`. Something like a map of
caches, keyed by class loader with appropriate use of weak references to avoid
class loader leaks.
--
This is an
jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448015687
Thanks, I get your points about caching scope and cleanup.
@ChristopherSchultz what prevents changes to `javax.el.Util`?
--
This is an automated message from the Apache Git Service.
ChristopherSchultz commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2447969657
> I'd also like to see the key remove from the cache when the value expires.
+1
So I think your technique @jengebr is good, but the cache just needs to be
pulled-up i
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2447798338
Any caching approach needs to consider the case of two classes in different
web applications with the same name but different structures. Essentially,
caching needs to be per class loader.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377
Mark Thomas changed:
What|Removed |Added
Severity|normal |enhancement
--- Comment #6 from Mark Tho
https://bz.apache.org/bugzilla/show_bug.cgi?id=69331
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=69228
Mark Thomas changed:
What|Removed |Added
Resolution|--- |WORKSFORME
Status|NEEDINFO
https://bz.apache.org/bugzilla/show_bug.cgi?id=68720
Mark Thomas changed:
What|Removed |Added
Resolution|--- |WORKSFORME
Status|NEEDINFO
https://bz.apache.org/bugzilla/show_bug.cgi?id=69379
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|NEEDINFO
--- Comment #5 from Mark Thomas
On Wed, Oct 30, 2024 at 5:06 PM Giorgio Saviane wrote:
>
> Hi all,
> when Tomcat is used with BouncyCastle as security provider, the audit
> logs of TLS connection attempts do not report the remote IP:port where the
> connection comes from:
>
> [2024-10-25 00:26:51,328 INFO] [server #24 @23e488a
Hi all,
when Tomcat is used with BouncyCastle as security provider, the audit
logs of TLS connection attempts do not report the remote IP:port where the
connection comes from:
[2024-10-25 00:26:51,328 INFO] [server #24 @23e488a9] accepting connection
from (Unknown):(Unknown)
I investigated why
https://bz.apache.org/bugzilla/show_bug.cgi?id=69406
--- Comment #2 from John Engebretson ---
Created attachment 39917
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39917&action=edit
Patch
Patch w/ change + JUnit
--
You are receiving this mail because:
You are the assignee for the bug
> On Oct 30, 2024, at 01:55, somasani nikhil wrote:
>
> We are using the following piece of code..
>
> =
>
> Class MyTag extends *TagSupport {*
> public int doStartTag() throws JspException {
> --
> --
> *constructTitle*(list)
> --
> --
> }
>
> private
Hi all! I recently submitted 8 enhancement tickets via Bugzilla, all related
to JSP performance, and I thought an explanation would be helpful.
In early September, I received an internal report that a small EL change
created a 40ms latency regression on the affected calls. The original EL
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 2696a0293a Add debug logging for cache size
2696a02
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 7fd6a5e0a5 Add debug logging for cache size
7fd6a
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new dfd7a7b7d8 Add debug logging for cache size
dfd7a
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new ca9b39f0a1 Add debug logging for cache size
ca9b39f0a
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 1beaeadcc8 Fix incorrect cache size calculations
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new df82cbfd36 Fix incorrect cache size calculations fo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 382dabbb19 Fix incorrect cache size calculations
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 636017459a Fix incorrect cache size calculations for
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new ae609e6f84 Use finally for init
ae609e6f84 is descri
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 01aff530a2 Use finally for init
01aff530a2 is desc
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new bf8f666230 Use finally for init
bf8f666230 is desc
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b83e866818 Use finally for init
b83e866818 is describe
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 53ee2867ee Stop avec init should be a noop
53ee2867e
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 12d8b56603 Stop avec init should be a noop
12d8b56
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new dbd4162c6f Stop avec init should be a noop
dbd4162
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 3d4dce54b2 Stop avec init should be a noop
3d4dce54b2
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b8c2efc6d0 Revert "Add FAILED_INIT lifecycle state"
b8
https://bz.apache.org/bugzilla/show_bug.cgi?id=68436
--- Comment #3 from Mailmur ---
Is there a consideration to change this from `.warn` to `.debug` message?
This will constantly spam a logging file for no reason.
We deliver a war file `META-INF/context.xml` without a driverClassName
attribute
We are using the following piece of code..
=
Class MyTag extends *TagSupport {*
public int doStartTag() throws JspException {
--
--
*constructTitle*(list)
--
--
}
private String *constructTitle*(List titleElements) {
StringBuffer titleValue = new StringBuf
37 matches
Mail list logo
