Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/36/builds/743
Blamelist: Mark Thomas
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 8.5.x] b0df9819c8d130adab0490b89dce1ab4ca6a34
Woellchen commented on PR #687:
URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932961663
Alright, I guess I got this wrong then, thanks for your detailed
explanations.
In case others are wondering about the same issue I found two bugs for
reference on prominent software pro
markt-asf commented on PR #687:
URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932891346
Nope, `%2F` is NOT equivalent to `/` in a URI as explained in section 2.2 of
RFC 3986.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Woellchen commented on PR #687:
URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932841669
Thanks for checking back! The section you are referring to does not really
negate my statement however. If I get you right you are talking about this
specific thing?
> These URIs sh
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/845
Blamelist: Mark Thomas
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 9.0.x] 6ce18dc93a054949e529952e809b159040b1d1
https://bz.apache.org/bugzilla/show_bug.cgi?id=68596
--- Comment #3 from John Engebretson ---
> This needs some more thought...
Thanks, I'll keep chewing on it too.
> Note: This may get moved to an enhancement if there isn't an obvious way to
> improve this)
Makes sense, thanks.
--
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=68596
--- Comment #2 from Mark Thomas ---
#1 isn't an option unfortunately. With more complex EL expressions
ELContext.isPropertyResolved() will return true at the start of the call to
convertToType(). At least one test fails if this code is removed.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new b0df9819c8 Allow user provided SSLContext instances
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 95ca454cc2 Align with 11.0.x
95ca454cc2 is descri
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 6ce18dc93a Allow user provided SSLContext instances
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089
--- Comment #8 from John Engebretson ---
Created attachment 39575
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39575&action=edit
Support class for the speed test
--
You are receiving this mail because:
You are the assignee for the b
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089
--- Comment #7 from John Engebretson ---
Created attachment 39574
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39574&action=edit
Speed test
--
You are receiving this mail because:
You are the assignee for the bug.
--
On 2024/02/07 16:05:17 Michael Osipov wrote:
> On 2024/02/04 19:54:25 Mark Thomas wrote:
> > Hi all,
> >
> > AS you have probably noticed I am working on another round of Tomcat
> > Native releases.
> >
> > We are overdue on switching to 1.3.x so I would like to propose the
> > following with t
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089
John Engebretson changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
On 2024/02/07 18:19:24 Christopher Schultz wrote:
> Michael,
>
> On 2/7/24 11:05, Michael Osipov wrote:
> > On 2024/02/04 19:54:25 Mark Thomas wrote:
> >> Hi all,
> >>
> >> AS you have probably noticed I am working on another round of Tomcat
> >> Native releases.
> >>
> >> We are overdue on switch
markt-asf commented on PR #687:
URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932635647
Nope. Read the RFC again. Specifically 6.2.2.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Michael,
On 2/7/24 11:05, Michael Osipov wrote:
On 2024/02/04 19:54:25 Mark Thomas wrote:
Hi all,
AS you have probably noticed I am working on another round of Tomcat
Native releases.
We are overdue on switching to 1.3.x so I would like to propose the
following with this release round:
- cre
https://bz.apache.org/bugzilla/show_bug.cgi?id=68119
--- Comment #3 from John Engebretson ---
This optimization was effective in production and reduced the method cost by
approximately 2/3rds, saving more than 0.5% of cpu.
The remaining time comes from another invokevirtual in the method which I
https://bz.apache.org/bugzilla/show_bug.cgi?id=68596
--- Comment #1 from John Engebretson ---
Created attachment 39573
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39573&action=edit
Support class for the speed test
--
You are receiving this mail because:
You are the assignee for the b
https://bz.apache.org/bugzilla/show_bug.cgi?id=68596
Bug ID: 68596
Summary: Remaining overhead in
javax.el.CompositeELResolver.convertToType
Product: Tomcat 9
Version: 9.0.85
Hardware: All
OS: All
Woellchen commented on PR #687:
URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932522774
Could you please elaborate how a URI is not user input and how it can be
prevented that a user calls a URI on a web application? I can't follow you.
Relative paths are explicitly allowed
rmaucher commented on PR #687:
URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932491567
URL processing and mapping has to follow a lot of rules from specifications
to avoid inconsistencies which would be security issues. So this is one of them.
Indeed creative encoding can c
rmaucher closed pull request #687: Decode and normalize URIs before processing
them
URL: https://github.com/apache/tomcat/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
https://bz.apache.org/bugzilla/show_bug.cgi?id=68068
--- Comment #5 from John Engebretson ---
Production results confirm a small improvement - greater than zero but not
enormous. Sorry, I'm not able to provide hard numbers because of the huge
number of distinct code paths.
--
You are receiving
On 2024/02/04 19:54:25 Mark Thomas wrote:
> Hi all,
>
> AS you have probably noticed I am working on another round of Tomcat
> Native releases.
>
> We are overdue on switching to 1.3.x so I would like to propose the
> following with this release round:
>
> - create a new 1.3.x branch from the
Woellchen opened a new pull request, #687:
URL: https://github.com/apache/tomcat/pull/687
URIs must be at least decoded in order to process sub-delims as defined in
RFC 3986, because slashes and their encoded counterparts are equivalent when
processing paths. Normalization before the proces
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932206483
Thank you mate, I really appreciate this! Big kudos! 🥳
I am looking forward to the new release!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 85bff6d424 Allow user provided SSLContext instanc
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932089608
OK, it is in main. I'll back-port as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new e6da237431 Allow user provided SSLContext instances o
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931990842
I have some ideas on how to address this. I might have a fix for this soon
that takes account of the lifecycle issues.
--
This is an automated message from the Apache Git Service.
To res
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931967568
Ah that is pity, I was looking forward to it. You have a better overview of
the issues which it can cause to other functionalities. I was not aware of the
lifecycle management and only focus
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559
--- Comment #8 from Mark Thomas ---
I've been able to look at this some more. Thanks so much for the test case. It
really speeds up the process.
The processing paths for sync and async are distinct. Currently the error
handling in async is han
https://bz.apache.org/bugzilla/show_bug.cgi?id=68449
Mark Thomas changed:
What|Removed |Added
Resolution|--- |WORKSFORME
Status|NEW
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931686883
I was tempted to merge this but having reviewed the Tomcat code I think this
is going to create problems - the main one being that Tomcat clears the
SSLContext on Connector.stop() when `bi
markt-asf closed pull request #673: Added option to use custom SSLContext
URL: https://github.com/apache/tomcat/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
> >> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> >> 1.3.0 but minimum required/recommended Tomcat Native versions would not
> >> change.
> >
> > I wouldn't bother with 8.5 and 1.3, I'd use 1.2.x until end of 8.5 and the
> > put 1.2.x EOL.
>
> I'm still leaning towards
markt-asf commented on PR #686:
URL: https://github.com/apache/tomcat/pull/686#issuecomment-1931626326
WONTFIX - As per section 2.3.3.4 applications are responsible for accessing
the request in a thread safe manner.
--
This is an automated message from the Apache Git Service.
To respond t
markt-asf closed pull request #686: Add a fallback when people use Parameters
class concurrently, to avoid lost params
URL: https://github.com/apache/tomcat/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=68593
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
40 matches
Mail list logo
