[Bug 68037] Async Servlet implementation doesn't allow setting a response status

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68037 --- Comment #3 from adwsingh --- @markt do you know why we check here [1] if its an asyncError and only then choose to process the SocketEvent? [1] https://github.com/apache/tomcat/blob/9.0.x/java/org/apache/coyote/AbstractProcessor.java#L121

[Bug 68037] Async Servlet implementation doesn't allow setting a response status

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68037 --- Comment #2 from adwsingh --- @markt do you know why we check here [1] if its an asyncError and only then choose to process the SocketEvent? [1] https://github.com/apache/tomcat/blob/9.0.x/java/org/apache/coyote/AbstractProcessor.java#L121

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
w1ida commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1789983590 > The description for the PR confuses request and response. It appears from the code that this PR relates to the response. > > This PR will not be applied. Whether or not to chunk the re

[Bug 68035] Deploying a directory from Host appBase fails

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68035 brandg...@gmail.com changed: What|Removed |Added OS||All --- Comment #1 from brandg...

Buildbot success in on tomcat-11.0.x

2023-11-01 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/722 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 4ed0ea74c7f84984b617e9132b102978b65392ef Steps: worker_prepa

Buildbot failure in on tomcat-11.0.x

2023-11-01 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/721 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main] ef52cc47d886c2cb13792ec9d98448b83c3bf4

(tomcat) branch 8.5.x updated: Remove a couple of additional out-dated translations

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a97a3d6089 Remove a couple of additional out-dated

(tomcat) branch 9.0.x updated: Remove a couple of additional out-dated translations

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6d7842d59c Remove a couple of additional out-dated

(tomcat) branch 10.1.x updated: Remove a couple of additional out-dated translations

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new a082aa7248 Remove a couple of additional out-date

(tomcat) branch main updated: Remove a couple of additional out-dated translations

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4ed0ea74c7 Remove a couple of additional out-dated tr

[Bug 67628] OpenSSLCipherConfigurationParser#parse() produces misleading false positive cipher warnings

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67628 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

(tomcat) branch 8.5.x updated (08424898ac -> 790b5eecaa)

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 08424898ac Line length new 7e88304df6 OpenSSL master branch is now 3.3.x new cd164eabf2 Add test based on BZ 6

(tomcat) 01/03: OpenSSL master branch is now 3.3.x

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7e88304df66e19dceb10f750d1616479bffd8bdf Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:31 2023 + OpenSSL master

(tomcat) 03/03: Fix BZ 67628 - Improve description of ciphers

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 790b5eecaa18e4d636de69c8045e44acaff262ea Author: Mark Thomas AuthorDate: Wed Nov 1 20:13:31 2023 + Fix BZ 67628 -

(tomcat) 02/03: Add test based on BZ 67628

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cd164eabf21c8f6021291c97ee3d42701e1bafe9 Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:45 2023 + Add test based

(tomcat) branch 10.1.x updated (fe5e550d69 -> 14d70ab35b)

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from fe5e550d69 Line length new 04f54f5d1d OpenSSL master branch is now 3.3.x new 07b7551a65 Add test based on BZ

(tomcat) branch 9.0.x updated (7c53498ea8 -> 0e25627690)

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 7c53498ea8 Line length new cdf6329f70 OpenSSL master branch is now 3.3.x new 50d024b27e Add test based on BZ 6

(tomcat) 03/03: Fix BZ 67628 - Improve description of ciphers

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0e25627690245cdf1f4f013eb348290c3e0fb8f0 Author: Mark Thomas AuthorDate: Wed Nov 1 20:13:31 2023 + Fix BZ 67628 -

(tomcat) 01/03: OpenSSL master branch is now 3.3.x

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cdf6329f705e366b50f47a12453e9236355356d2 Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:31 2023 + OpenSSL master

(tomcat) 01/03: OpenSSL master branch is now 3.3.x

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 04f54f5d1d5d280a58670af6528ef5e65caee7b3 Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:31 2023 + OpenSSL maste

(tomcat) 02/03: Add test based on BZ 67628

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 50d024b27ea29380b0fc35ead39ff1c9acb97404 Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:45 2023 + Add test based

(tomcat) 02/03: Add test based on BZ 67628

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1d4f22078010aee28f097a588c2146bd2b09f7b4 Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:45 2023 + Add test based

(tomcat) 03/03: Fix BZ 67628 - Improve description of ciphers

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 14d70ab35b363e0e6541dbbaf3431e4156f9bf4f Author: Mark Thomas AuthorDate: Wed Nov 1 20:13:31 2023 + Fix BZ 67628

(tomcat) 02/03: Add test based on BZ 67628

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 07b7551a65dd42b8949c45efe422c2796ee2475b Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:45 2023 + Add test base

(tomcat) branch main updated (38a386390f -> ef52cc47d8)

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 38a386390f Line length new 8990cac7f8 OpenSSL master branch is now 3.3.x new 1d4f220780 Add test based on BZ 67

(tomcat) 03/03: Fix BZ 67628 - Improve description of ciphers

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ef52cc47d886c2cb13792ec9d98448b83c3bf47e Author: Mark Thomas AuthorDate: Wed Nov 1 20:13:31 2023 + Fix BZ 67628 -

(tomcat) 01/03: OpenSSL master branch is now 3.3.x

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8990cac7f8745651cce24db3919de8eb48e1ffd0 Author: Mark Thomas AuthorDate: Wed Nov 1 19:34:31 2023 + OpenSSL master

Buildbot success in on tomcat-10.1.x

2023-11-01 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/1015 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 10.1.x] fe5e550d6963ce9a0b6055c8c7d229867295a768 Steps: worker_pre

Buildbot success in on tomcat-11.0.x

2023-11-01 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/720 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 38a386390fec073826aca1988723fc25f9ac3bc8 Steps: worker_prepa

(tomcat-native) branch 1.2.x updated: Further improve BZ 67818 wording

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 1.2.x in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/1.2.x by this push: new c4f23c954 Further improve BZ 67818 wording c

(tomcat-native) branch main updated: Fix typo. Further improve BZ 67818 wording

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/main by this push: new 607af745a Fix typo. Further improve BZ 67818 w

[Bug 67938] Tomcat mishandles large client hello messages

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67938 --- Comment #4 from Stephen Higgs --- Reproducer Steps This reproducer creates an artificially large ClientHello that causes Tomcat to respond with an SSL alert on TLS 1.3 session resumption. In this test case, a certificate

[Bug 67628] OpenSSLCipherConfigurationParser#parse() produces misleading false positive cipher warnings

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67628 --- Comment #6 from Michael Osipov --- (In reply to Mark Thomas from comment #5) > If we pass ciphers directly to OpenSSL then we get different behaviour > between JSSE and OpenSSL. This is the issue the current design is trying to > avoid - or

Buildbot failure in on tomcat-10.1.x

2023-11-01 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/1014 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 10.1.x] eb735f853f7f1607ff82e70b4fe0f985a462

Re: (tomcat) branch main updated: Line length

2023-11-01 Thread Mark Thomas
On 01/11/2023 15:37, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 38a38

(tomcat) branch 8.5.x updated: Line length

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 08424898ac Line length 08424898ac is described belo

(tomcat) branch 9.0.x updated: Line length

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7c53498ea8 Line length 7c53498ea8 is described belo

(tomcat) branch 10.1.x updated: Line length

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new fe5e550d69 Line length fe5e550d69 is described be

(tomcat) branch main updated: Line length

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 38a386390f Line length 38a386390f is described below

[Bug 67628] OpenSSLCipherConfigurationParser#parse() produces misleading false positive cipher warnings

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67628 --- Comment #5 from Mark Thomas --- If we pass ciphers directly to OpenSSL then we get different behaviour between JSSE and OpenSSL. This is the issue the current design is trying to avoid - or at least highlight when it happens. What you are

(tomcat) branch main updated: BZ 66875. jakarta.servlet.error.exception shouldn't start error handling

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 276e04f3d5 BZ 66875. jakarta.servlet.error.exception

[Bug 66875] Handling async error after spring already handled error

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66875 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

(tomcat) branch 9.0.x updated: BZ 66875. jakarta.servlet.error.exception shouldn't start error handling

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2c5c9e3a1b BZ 66875. jakarta.servlet.error.exceptio

(tomcat) branch 8.5.x updated: BZ 66875. jakarta.servlet.error.exception shouldn't start error handling

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 37789ecd15 BZ 66875. jakarta.servlet.error.exceptio

(tomcat) branch 10.1.x updated: BZ 66875. jakarta.servlet.error.exception shouldn't start error handling

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new eb735f853f BZ 66875. jakarta.servlet.error.except

[Bug 66875] Handling async error after spring already handled error

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66875 --- Comment #11 from Mark Thomas --- I think there are two separate issues here. 1. When Spring sets jakarta.servlet.error.exception that triggers Tomcat's internal error handling. Whether Spring should do that and whether that should have the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1788896749 The description for the PR confuses request and response. It appears from the code that this PR relates to the response. This PR will not be applied. Whether or not to chunk the resp

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
markt-asf closed pull request #676: Fix explicit chunked encoding specification URL: https://github.com/apache/tomcat/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[Bug 66875] Handling async error after spring already handled error

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66875 --- Comment #10 from Mark Thomas --- (In reply to Nils Kohrs from comment #4) > Here is a minimal project to reproduce it: > https://github.com/nilskohrs/tomcat-bug-66875 Thanks. This reproduces the issue as originally described with Tomcat 10

[PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
w1ida opened a new pull request, #676: URL: https://github.com/apache/tomcat/pull/676 Summary: This commit fixes a bug in the code related to handling chunked transfer encoding. The original code only handled chunked transfer encoding when http11 was true, entityBody was true, and connec

[Bug 66875] Handling async error after spring already handled error

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66875 --- Comment #9 from Mark Thomas --- The simpler test case behaves as desired if the response buffer is flushed after the application provided error response is written. I'm not convinced that the test case completely reproduces the reported is

[Bug 67932] module-info re-export other libraries

2023-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67932 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

(tomcat-native) branch 1.2.x updated: Better wording for BZ 67818

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 1.2.x in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/1.2.x by this push: new 775330977 Better wording for BZ 67818 775330

(tomcat-native) branch main updated: Better wording for BZ 67818

2023-11-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/main by this push: new 92aefff80 Better wording for BZ 67818 92aefff8

Buildbot failure in on tomcat-11.0.x

2023-11-01 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/719 Blamelist: Andrei Briukhov , Andrey Bruykhov , Arun Chaitanya Miriappalli , Bailey Brownie , Carsten Klein , ChrissW-R1 , Christopher Schultz , Clément Guilla