Re: Potential performance improvement

2023-09-13 Thread Romain Manni-Bucau
Hi Christopher, A surprising thing is that skipping the new instance if it already fulfills the target makes it faster cause the JVM does it in both latin and utf16 cases, is it due to the fact it does not even check if the chars are surrogate which globally means the boost comes from the limited

[tomcat] branch main updated: Remove KeyStoreUtil as it is no longer required.

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a33f0a19cb Remove KeyStoreUtil as it is no longer req

Re: Potential performance improvement

2023-09-13 Thread Mark Thomas
So we are talking about a saving of around 35 nanoseconds per call. I just ran Tomcat 10.1.x through a profiler and requesting the Tomcat homepage triggered String.toLowerCase() just under 100 times (some of those calls may be from other JRE methods). So at best, we are looking at 3 microsecon

Re: Potential performance improvement

2023-09-13 Thread Christopher Schultz
All, Ping. I've added a few other implementations which will e.g. perform no char-copy if the string is already in lower-case, so they are faster under special circumstances. I'm happy to share my jmh runs, which seem to show that Java's String.toLowerCase is getting faster and faster every

[tomcat] branch 8.5.x updated: Fix possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a3ec97a0c2 Fix possible NPEs a3ec97a0c2 is described

[tomcat] branch 9.0.x updated: Fix possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f7229575fa Fix possible NPEs f7229575fa is described

[tomcat] branch 10.1.x updated: Fix possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1e26ed4b13 Fix possible NPEs 1e26ed4b13 is describ

[tomcat] branch main updated: Fix possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 34a083537b Fix possible NPEs 34a083537b is described b

[tomcat] branch 9.0.x updated: Fix bad processing for qsd flag

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 72b5029afb Fix bad processing for qsd flag 72b5029af

[tomcat] branch 10.1.x updated: Fix bad processing for qsd flag

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new a1376fa7d4 Fix bad processing for qsd flag a1376fa

[tomcat] branch 8.5.x updated: Fix bad processing for qsd flag

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 0a3ea7a40b Fix bad processing for qsd flag 0a3ea7a40

[tomcat] branch main updated: Fix bad processing for qsd flag

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 492d1cbebb Fix bad processing for qsd flag 492d1cbebb

[tomcat] branch 8.5.x updated: Superclass call

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ac6ef51b78 Superclass call ac6ef51b78 is described b

[tomcat] branch 9.0.x updated: Superclass call

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7b1282eda7 Superclass call 7b1282eda7 is described b

[tomcat] branch 10.1.x updated: Superclass call

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 46487d8e3e Superclass call 46487d8e3e is described

[tomcat] branch main updated: Superclass call

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 419cf0f040 Superclass call 419cf0f040 is described bel

[tomcat] branch 9.0.x updated: Fix NPE and fix superclass use

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c4aea9684f Fix NPE and fix superclass use c4aea9684f

[tomcat] branch 10.1.x updated: Fix NPE and fix superclass use

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8c00d17ae6 Fix NPE and fix superclass use 8c00d17a

[tomcat] branch 8.5.x updated: Fix NPE and fix superclass use

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new bf8c2d0da1 Fix NPE and fix superclass use bf8c2d0da1

[tomcat] branch main updated: Fix NPE and fix superclass use

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c7a7581f30 Fix NPE and fix superclass use c7a7581f30 i

[tomcat] branch 8.5.x updated: Fix various possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new daaa6edc4e Fix various possible NPEs daaa6edc4e is d

[tomcat] branch 9.0.x updated: Fix various possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1d633c89f2 Fix various possible NPEs 1d633c89f2 is d

[tomcat] branch 10.1.x updated: Fix various possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new d7e02c3610 Fix various possible NPEs d7e02c3610 is

[tomcat] branch main updated: Fix various possible NPEs

2023-09-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 8afd6c6f73 Fix various possible NPEs 8afd6c6f73 is des

[Bug 67235] NPE (NullPointerException) occurs in AsyncContextImpl.decrementInProgressAsyncCount after version 10.1.12.

2023-09-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235 --- Comment #6 from Mark Thomas --- I've applied the fix but I am leaving this issue open for now as I want to take a further a look at the error handling. -- You are receiving this mail because: You are the assignee for the bug.

[tomcat] branch 8.5.x updated: Fix BZ 67235 - fix NPE on dispatch from AsyncListener.onError

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 5c98e45956 Fix BZ 67235 - fix NPE on dispatch from

[tomcat] branch 9.0.x updated: Fix BZ 67235 - fix NPE on dispatch from AsyncListener.onError

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 773471992a Fix BZ 67235 - fix NPE on dispatch from

[tomcat] branch 10.1.x updated: Fix BZ 67235 - fix NPE on dispatch from AsyncListener.onError

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f4ab97cbe9 Fix BZ 67235 - fix NPE on dispatch fro

Re: [tomcat] 02/03: Experimenting with Semgrep

2023-09-13 Thread Mark Thomas
On 13/09/2023 11:18, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a78ed4a68522203def8f0c6b590678b1ff069fc0 Author: Mark Thomas AuthorDate: Wed

[tomcat] branch 9.0.x updated: Ignore sdkman config

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1aa3684cec Ignore sdkman config 1aa3684cec is descr

[tomcat] branch 8.5.x updated: Ignore sdkman config

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 302792cb8f Ignore sdkman config 302792cb8f is descr

[tomcat] branch 10.1.x updated: Ignore sdkman config

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 58e3e510aa Ignore sdkman config 58e3e510aa is des

[tomcat] 01/03: Fix BZ 67235 - fix NPE on dispatch from AsyncListener.onError

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 147cf5735c80b1fe08b2b38ff2d6a4e7c4fd4e75 Author: Mark Thomas AuthorDate: Fri Sep 8 18:34:36 2023 +0100 Fix BZ 67235 -

[tomcat] branch main updated (e830bc357a -> aa09e68f85)

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from e830bc357a Fix the logic new 147cf5735c Fix BZ 67235 - fix NPE on dispatch from AsyncListener.onError new a78e

[tomcat] 03/03: Ignore sdkman config

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit aa09e68f852e2693ca6b5add2a0e928603bdd30d Author: Mark Thomas AuthorDate: Wed Sep 13 11:17:45 2023 +0100 Ignore sdkman

[tomcat] 02/03: Experimenting with Semgrep

2023-09-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a78ed4a68522203def8f0c6b590678b1ff069fc0 Author: Mark Thomas AuthorDate: Wed Sep 13 11:16:49 2023 +0100 Experimenting

svn commit: r1912280 - in /tomcat/site/trunk: docs/security-jk.html xdocs/security-jk.xml

2023-09-13 Thread markt
Author: markt Date: Wed Sep 13 09:27:27 2023 New Revision: 1912280 URL: http://svn.apache.org/viewvc?rev=1912280&view=rev Log: Update CVE-2023-41081 Modified: tomcat/site/trunk/docs/security-jk.html tomcat/site/trunk/xdocs/security-jk.xml Modified: tomcat/site/trunk/docs/security-jk.html

[SECURITY] CVE-2023-41081 Apache Tomcat Connectors (mod_jk) Information Disclosure

2023-09-13 Thread Mark Thomas
CVE-2023-41081 Apache Tomcat Connectors (mod_jk) Information Disclosure Severity: Important Vendor: The Apache Software Foundation Versions Affected: - Apache Tomcat Connectors mod_jk Connector 1.2.0 to 1.2.48 Description: In some circumstances, such as when a configuration included "JkOptions

svn commit: r1912279 - in /tomcat/site/trunk: docs/security-jk.html xdocs/security-jk.xml

2023-09-13 Thread markt
Author: markt Date: Wed Sep 13 09:26:57 2023 New Revision: 1912279 URL: http://svn.apache.org/viewvc?rev=1912279&view=rev Log: Add details of CVE-2023-41081 Modified: tomcat/site/trunk/docs/security-jk.html tomcat/site/trunk/xdocs/security-jk.xml Modified: tomcat/site/trunk/docs/security

[Bug 67376] isapi Redirector fails to connect tomcat 9.0.78

2023-09-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67376 Mark Thomas changed: What|Removed |Added Resolution|--- |DUPLICATE OS|

[Bug 67370] isapi Redirector fails to connect tomcat 9.0.78

2023-09-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67370 --- Comment #2 from Mark Thomas --- *** Bug 67376 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 67376] New: isapi Redirector fails to connect tomcat 9.0.78

2023-09-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67376 Bug ID: 67376 Summary: isapi Redirector fails to connect tomcat 9.0.78 Product: Tomcat 9 Version: 9.0.78 Hardware: PC Status: NEW Severity: blocker Priority:

[Bug 67370] isapi Redirector fails to connect tomcat 9.0.78

2023-09-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67370 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 67370] New: isapi Redirector fails to connect tomcat 9.0.78

2023-09-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67370 Bug ID: 67370 Summary: isapi Redirector fails to connect tomcat 9.0.78 Product: Tomcat Connectors Version: 1.2.48 Hardware: PC Status: NEW Severity: blocker P