[GitHub] [tomcat] aooohan commented on pull request #646: Parameter error handling

2023-08-18 Thread via GitHub
aooohan commented on PR #646: URL: https://github.com/apache/tomcat/pull/646#issuecomment-1684798995 This change look good for me. But I have found that `org.apache.catalina.valves.ExtendedAccessLogValve.RequestParameterElement` behavior is broken due to this change. Maybe here should c

[Bug 66005] Apache crashes, if there is a tomcat server, which can not be resolved

2023-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005 --- Comment #23 from Rainer Jung --- Too many typos: Thanks for the great finding! I plan to apply your patch. Since -E is not a standardized linker flag I would rather prefer to not include it. For me it made no difference, whether I add th

[GitHub] [tomcat] markt-asf opened a new pull request, #646: Parameter error handling

2023-08-18 Thread via GitHub
markt-asf opened a new pull request, #646: URL: https://github.com/apache/tomcat/pull/646 This PR updates the parameter error handling to align with the changes in Jakarta Servlet 6.0 The short version is all getParameterXXX() calls now throw exceptions on invalid parameters. Note

[Bug 66005] Apache crashes, if there is a tomcat server, which can not be resolved

2023-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005 --- Comment #22 from Rainer Jung --- Thanks for the great finding! I plan to apply your patch. Since -E is not a standardized linker flag I would rather prefer to not include it. For me it made no difference, whether I add the -Wl,-E (so the

[GitHub] [tomcat] babyblue94520 closed pull request #645: feat(Http11Processor): Add max value in keepalive.

2023-08-18 Thread via GitHub
babyblue94520 closed pull request #645: feat(Http11Processor): Add max value in keepalive. URL: https://github.com/apache/tomcat/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific