[tomcat] branch 10.1.x updated: Added RateLimitFilter

2023-05-05 Thread isapir
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new e7fdd91265 Added RateLimitFilter e7fdd91265 is d

Re: Java 21, virtual threads and ThreadLocals

2023-05-05 Thread koteswara Rao Gundapaneni
Hi When it becomes virtual threads and Threadlocal to select with Virtual threads is great option To clarify more Cluster is no message between the nodes but synchronized the cluster Regards Koti On Fri, 5 May 2023, 20:58 Mark Thomas, wrote: > Hi all, > > I've started to review the use of T

[tomcat] branch main updated (d7411fb2a8 -> e2dd77b6d8)

2023-05-05 Thread isapir
This is an automated email from the ASF dual-hosted git repository. isapir pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from d7411fb2a8 Fix typo add fa0c65bed1 Added RateLimitFilter add 14db569d9c Updated RateLimitFilter Javadoc commen

[tomcat] 01/01: Merge pull request #607 from apache/ratelimit-filter

2023-05-05 Thread isapir
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e2dd77b6d8d5c3f4ce6ec319873287e210793f46 Merge: d7411fb2a8 a69c081677 Author: Igal Sapir AuthorDate: Sat May 6 05:04:44 20

[GitHub] [tomcat] isapir merged pull request #607: Added RateLimitFilter

2023-05-05 Thread via GitHub
isapir merged PR #607: URL: https://github.com/apache/tomcat/pull/607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: Java 21, virtual threads and ThreadLocals

2023-05-05 Thread Rémy Maucherat
On Fri, May 5, 2023 at 5:28 PM Mark Thomas wrote: > > Hi all, > > I've started to review the use of ThreadLocal within the Tomcat code > base given that using virtual threads will soon be an option. > > The first usage I came to raised a few questions. The usage is in > ApplicationContext: > > htt

Re: Workaround for misbehaving ClassLoader

2023-05-05 Thread Christopher Schultz
Mark, On 5/4/23 04:09, Mark Thomas wrote: On 03/05/2023 20:02, Christopher Schultz wrote: But my question is whether or not this is something that Tomcat should be working-around. IMO the parent ClassLoader is buggy and should be fixed, but it may be difficult or impossible to fix the paren

[tomcat] branch main updated: Fix typo

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d7411fb2a8 Fix typo d7411fb2a8 is described below co

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

2023-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66593 --- Comment #5 from Mark Thomas --- Bugzilla is NOT a support forum. Please do as you have been asked and post to the users mailing list. -- You are receiving this mail because: You are the assignee for the bug. --

[tomcat] branch 8.5.x updated: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 686b81d849 Clean-up, formatting. No functional chan

[tomcat] branch 8.5.x updated: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new db76f15c93 Clean-up, formatting. No functional chan

[tomcat] branch 9.0.x updated: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 832cf68fa8 Clean-up, formatting. No functional chan

[tomcat] branch 9.0.x updated: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b3370f5e29 Clean-up, formatting. No functional chan

[tomcat] 01/02: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0574bf30963e2ff582694e006ca598a9bb15512c Author: Mark Thomas AuthorDate: Fri May 5 16:44:52 2023 +0100 Clean-up, for

[tomcat] 02/02: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 15a1d0e0c4fbfb3afe5d3c86f8f1dd8655c38499 Author: Mark Thomas AuthorDate: Fri May 5 16:45:14 2023 +0100 Clean-up, for

[tomcat] branch 10.1.x updated (87409a1d7e -> 15a1d0e0c4)

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 87409a1d7e Increase wait time - I am seeing test failures on local VMs. new 0574bf3096 Clean-up, formatting. No fu

[tomcat] branch main updated: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f1daf9d05e Clean-up, formatting. No functional change

[tomcat] branch main updated: Clean-up, formatting. No functional change.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c16e06575b Clean-up, formatting. No functional change

[tomcat] branch main updated: Remove unused constant

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new bd25937d2a Remove unused constant bd25937d2a is descr

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

2023-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66593 --- Comment #4 from alvaro --- Hi, I have another question...if you don't mind. So in this scenario, I have the request line using the absolute path with a conflicting host header. The response is 400 bad request from Tomcat, which makes sens

Java 21, virtual threads and ThreadLocals

2023-05-05 Thread Mark Thomas
Hi all, I've started to review the use of ThreadLocal within the Tomcat code base given that using virtual threads will soon be an option. The first usage I came to raised a few questions. The usage is in ApplicationContext: https://github.com/apache/tomcat/blob/main/java/org/apache/catalin

Re: [VOTE] Release Apache Tomcat 9.0.75

2023-05-05 Thread Mark Thomas
On 04/05/2023 15:20, Rémy Maucherat wrote: The proposed Apache Tomcat 9.0.75 release is now available for voting. The notable changes compared to 9.0.74 are: - Many improvements to the json access log valve. - Deprecate support for the HTTP Connector settings rejectIllegalHeader and allowH

[tomcat] branch 8.5.x updated: Increase wait time - I am seeing test failures on local VMs.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b6d3de5d5f Increase wait time - I am seeing test fa

[tomcat] branch 9.0.x updated: Increase wait time - I am seeing test failures on local VMs.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ba6bcac2ed Increase wait time - I am seeing test fa

[tomcat] branch 10.1.x updated: Increase wait time - I am seeing test failures on local VMs.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 87409a1d7e Increase wait time - I am seeing test

[tomcat] branch main updated: Increase wait time - I am seeing test failures on local VMs.

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b917f0b2fb Increase wait time - I am seeing test fail

Re: Java 21 and virtual threads

2023-05-05 Thread Coty Sutherland
On Thu, May 4, 2023 at 8:37 AM Mark Thomas wrote: > Hi all, > > The latest Java 21 EA build has moved virtual threads (from project > Loom) out of preview. How do we want to handle this in Tomcat 11? Recall > that Jakarta EE 11 has set Java 21 as the minimum version. > > I think we have the follo

Re: [VOTE] Release Apache Tomcat 9.0.75

2023-05-05 Thread Dimitris Soumis
Tests pass with tc-natvie 1.2.36 and OpenSSL 3.0.8 on Fedora 36. On Thu, May 4, 2023 at 5:26 PM Rémy Maucherat wrote: > The proposed Apache Tomcat 9.0.75 release is now available for voting. > > The notable changes compared to 9.0.74 are: > > - Many improvements to the json access log valve. > >

[tomcat] branch main updated: Avoid possible NPEs - review from lihan

2023-05-05 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e3ebf33c51 Avoid possible NPEs - review from lihan e3

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-05 Thread Mark Thomas
On 05/05/2023 13:17, Han Li wrote: On May 5, 2023, at 18:42, Mark Thomas wrote: On 05/05/2023 04:21, Han Li wrote: On May 4, 2023, at 21:41, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-05 Thread Han Li
> On May 5, 2023, at 18:42, Mark Thomas wrote: > > On 05/05/2023 04:21, Han Li wrote: >>> On May 4, 2023, at 21:41, ma...@apache.org wrote: >>> >>> This is an automated email from the ASF dual-hosted git repository. >>> >>> markt pushed a commit to branch main >>> in repository https://gitbox

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

2023-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66593 --- Comment #3 from alvaro --- thanks, this makes sense now. cheers, Alvaro -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-ma

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-05 Thread koteswara Rao Gundapaneni
Hi Team , Management of start and stop might be arrested Regards Koti On Thu, 4 May 2023, 19:12 , wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch main > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit 4b

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-05 Thread Mark Thomas
On 05/05/2023 04:21, Han Li wrote: On May 4, 2023, at 21:41, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4b097bf2e9075e9e2949ec5aa410cba3c

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

2023-05-05 Thread Mark Thomas
On 03/05/2023 19:38, Mark Thomas wrote: The proposed 11.0.0-M6 release is: [ ] Broken - do not release [X] Alpha  - go ahead and release as 11.0.0-M6 Test pass on Windows, Linux and MacOS (Intel and M1). Mark - To unsubscribe