[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1184594119 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1184526447 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1184526447 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[tomcat] branch ratelimit-filter updated (14db569d9c -> a69c081677)

This is an automated email from the ASF dual-hosted git repository. isapir pushed a change to branch ratelimit-filter in repository https://gitbox.apache.org/repos/asf/tomcat.git from 14db569d9c Updated RateLimitFilter Javadoc comment to address feedback add a69c081677 Addressed PR feed

Re: Workaround for misbehaving ClassLoader

Dear chris, I will take care about it and update it accordingly Regards, Koti On Wed, May 3, 2023 at 12:02 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > Please check this thread for full details: > https://lists.apache.org/thread/of5ozg43zyk729cg311dktjcv3swct26 > >

[tomcat] branch ratelimit-filter updated (fa0c65bed1 -> 14db569d9c)

This is an automated email from the ASF dual-hosted git repository. isapir pushed a change to branch ratelimit-filter in repository https://gitbox.apache.org/repos/asf/tomcat.git from fa0c65bed1 Added RateLimitFilter add 14db569d9c Updated RateLimitFilter Javadoc comment to address feed

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

> On May 4, 2023, at 02:38, Mark Thomas wrote: > > The proposed Apache Tomcat 11.0.0-M6 release is now available for > voting. > > Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and has > been made to provide users with early access to the new features in Apache > Tomca

Buildbot success in on tomcat-9.0.x

Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/542 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x] 4d63c77b0276facc52a2eb794e5616d90204fcf7 Steps: worker_prepa

Re: Workaround for misbehaving ClassLoader

Hi Chris, Fixing the parent in this project is quite easy, if the OSGi bundle.getResources returns null then return emptyEnumeration instead of the direct result of the call but generally speaking this is a valid statement but I guess Tomcat can await some other hit of this issue to push forward a

Workaround for misbehaving ClassLoader

All, Please check this thread for full details: https://lists.apache.org/thread/of5ozg43zyk729cg311dktjcv3swct26 Briefly, a user reported this NPE: Apr 29, 2023 5:41:32 PM org.apache.catalina.core.StandardContext listenerStart SEVERE: Exception sending context initialized event to listener i

[tomcat] branch 8.5.x updated: Fix typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new cfc7e2b33c Fix typo cfc7e2b33c is described below

[tomcat] branch 9.0.x updated: Fix typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4d63c77b02 Fix typo 4d63c77b02 is described below

[tomcat] branch main updated: Fix typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 029e8be1d2 Fix typo 029e8be1d2 is described below co

[tomcat] branch 10.1.x updated: Fix typo

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 43ef7f0356 Fix typo 43ef7f0356 is described below

[VOTE] Release Apache Tomcat 11.0.0-M6

The proposed Apache Tomcat 11.0.0-M6 release is now available for voting. Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and has been made to provide users with early access to the new features in Apache Tomcat 11.0.x so that they may provide feedback. The notable changes

Buildbot failure in on tomcat-9.0.x

Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/541 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 2f0ca2378415f4cf0748f4bc8fa955f41f803f

svn commit: r61624 - in /dev/tomcat/tomcat-11/v11.0.0-M6: ./ bin/ bin/embed/ src/

Author: markt Date: Wed May 3 18:11:22 2023 New Revision: 61624 Log: Upload 11.0.0-M6 for voting Added: dev/tomcat/tomcat-11/v11.0.0-M6/ dev/tomcat/tomcat-11/v11.0.0-M6/KEYS dev/tomcat/tomcat-11/v11.0.0-M6/README.html dev/tomcat/tomcat-11/v11.0.0-M6/RELEASE-NOTES dev/tomcat/t

[tomcat] 01/01: Tag 11.0.0-M6

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 11.0.0-M6 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9ce010463a93138d596c54c67b11cdb35fc8244a Author: Mark Thomas AuthorDate: Wed May 3 18:47:59 2023 +0100 Tag 11.0.0-M6

[tomcat] tag 11.0.0-M6 created (now 9ce010463a)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 11.0.0-M6 in repository https://gitbox.apache.org/repos/asf/tomcat.git at 9ce010463a (commit) This tag includes the following new commits: new 9ce010463a Tag 11.0.0-M6 The 1 revisions li

Buildbot success in on tomcat-11.0.x

Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/346 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 739c7381aed22b7636351caf885ddc519ab6b442 Steps: worker_prepa

[Bug 66591] HttpResponse without any header generates corrupted AJP messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 8.5.x updated: Fix 66591 - Make sure every response includes a Send Headers packet

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2214c80305 Fix 66591 - Make sure every response inc

[tomcat] branch 9.0.x updated: Fix 66591 - Make sure every response includes a Send Headers packet

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2f0ca23784 Fix 66591 - Make sure every response inc

[tomcat] branch 10.1.x updated: Fix 66591 - Make sure every response includes a Send Headers packet

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f0742f47b9 Fix 66591 - Make sure every response i

[tomcat] branch main updated: Fix 66591 - Make sure every response includes a Send Headers packet

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 739c7381ae Fix 66591 - Make sure every response inclu

[Bug 66591] HttpResponse without any header generates corrupted AJP messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #5 from Mark Thomas ---

Buildbot failure in on tomcat-11.0.x

Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/345 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main] a477bb09a4a8fabb0c5d2d4114e2214bbb9cc4

[Bug 66591] HttpResponse without any header generates corrupted AJP messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 --- Comment #4 from Conny Seifert --- Created attachment 38551 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38551&action=edit minimal testcase attached app returns string "test" without any headers. In case of failure output looks li

[tomcat] branch 8.5.x updated: Fix off by one issue in tests found while investigating BZ 66591

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new deab34e93a Fix off by one issue in tests found whil

[tomcat] branch 9.0.x updated: Fix off by one issue in tests found while investigating BZ 66591

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c7230e10ac Fix off by one issue in tests found whil

[tomcat] branch 10.1.x updated: Fix off by one issue in tests found while investigating BZ 66591

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new a3423dc649 Fix off by one issue in tests found wh

[tomcat] branch main updated: Fix off by one issue in tests found while investigating BZ 66591

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a477bb09a4 Fix off by one issue in tests found while

Re: [Bug 66591] HttpResponse without any header generates corrupted AJP messages

Dear team, Server might sends message headers for the request done by client Here the response might be empty atheist I considered it a servlet Regards Koti On Wed, 3 May 2023, 14:43 , wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 > > --- Comment #1 from Mark Thomas ---

[Bug 66591] HttpResponse without any header generates corrupted AJP messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 --- Comment #3 from Conny Seifert --- If I understood the code correctly, the "header-loop" beginning in line 950 is not entered at all in case of 0 headers. So no https status code is appended to AJP response and also the number of headers is

[Bug 66591] HttpResponse without any header generates corrupted AJP messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Mark Thomas

[Bug 66591] HttpResponse without any header generates corrupted AJP messages

https://bz.apache.org/bugzilla/show_bug.cgi?id=66591 --- Comment #1 from Mark Thomas --- Thanks for the report. My reading of RFC 9110 (section 3.4) is that responses do not require headers. I am a little curious how the fix for bug 66512 triggered this but it does look like a bug. I'm working

Re: [Bug 66589] Data frame included in response for 200 OK status with no body (content-length=0)

Please do not hijack threads. If you want to ask a new question, DO NOT reply to an existing message. Create a new message, set an appropriate subject and send it to the correct list. Mark On 03/05/2023 08:46, koteswara Rao Gundapaneni wrote: Hi I have my code established at my local for t

Re: [Bug 66589] Data frame included in response for 200 OK status with no body (content-length=0)

Hi I have my code established at my local for tomcat but struggling alott that how can I assigned with the PR and Bugs that the software has indeed Regards, Koti On Tue, May 2, 2023 at 1:35 PM wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=66589 > > --- Comment #4 from hypn...@donarpro