[Bug 66508] Tomcat after a GC pause causes the HTTP threads to be blocked to acquire a semaphore to process WebSockets connection closure.

2023-03-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 --- Comment #9 from Venkata Manda --- When a nonblocking write is failing, the writeCompletionHandler.failed inside Nio2Endpointis getting called, but it is unable to trigger a code path to clear the handler on WsRemoteEndpointImplServer. --

[Bug 66508] Tomcat after a GC pause causes the HTTP threads to be blocked to acquire a semaphore to process WebSockets connection closure.

2023-03-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 Venkata Manda changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[GitHub] [tomcat] VirtualTim opened a new pull request, #600: echo the value of %JAVA_HOME% when it is invalid.

2023-03-15 Thread via GitHub
VirtualTim opened a new pull request, #600: URL: https://github.com/apache/tomcat/pull/600 This is useful for diagnosing %JAVA_HOME% issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-15 Thread Igal Sapir
Mark, On Wed, Mar 15, 2023 at 5:08 AM Mark Thomas wrote: > On 15/03/2023 01:52, Igal Sapir wrote: > > Hello, > > > > test/org/apache/catalina/valves/rewrite/TestRewriteValve.java fails with > > file not found when a custom tomcat.output directory is specified in > > build.properties. > > > > I h

Buildbot success in on tomcat-8.5.x

2023-03-15 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/36/builds/432 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 8.5.x] 1fd2eb80b0f8bb96b6b7ee081e497fb4e8215e13 Steps: worker_prepa

Buildbot failure in on tomcat-11.0.x

2023-03-15 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/268 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main] 6de806a21adc68a23aa4043c67c0d80bbab1c4

Re: Reduce default for maxParameterCount

2023-03-15 Thread Mark Thomas
On 15/03/2023 11:22, Konstantin Kolinko wrote: ср, 15 мар. 2023 г. в 13:29, Konstantin Kolinko : ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : ср, 15 мар. 2023 г. в 12:07, Mark Thomas : On 14/03/2023 21:13, Christopher Schultz wrote: On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14:

[Bug 66513] Primary Key Violation using PersistentManager + PersistentValves +

2023-03-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66513 --- Comment #5 from Vincent Liautaud --- Hi all, in addition to the fix, may you ask the development team : 1-To patch the following documentation regarding PersistentValve : https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html The docume

[tomcat] branch 8.5.x updated: Update comment

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1fd2eb80b0 Update comment 1fd2eb80b0 is described b

[tomcat] branch 9.0.x updated: Update comment

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c79a3f5f8c Update comment c79a3f5f8c is described b

[tomcat] branch 10.1.x updated: Update comment

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 878e69d78a Update comment 878e69d78a is described

[tomcat] branch main updated: Update comment

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6de806a21a Update comment 6de806a21a is described bel

[tomcat] branch 8.5.x updated: Make use of clear() method

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d830e02685 Make use of clear() method d830e02685 is

[tomcat] branch 9.0.x updated: Make use of clear() method

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8e51cacc70 Make use of clear() method 8e51cacc70 is

[tomcat] branch 10.1.x updated: Make use of clear() method

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1ff40e7e6b Make use of clear() method 1ff40e7e6b

[tomcat] branch main updated: Make use of clear() method

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 53f1383494 Make use of clear() method 53f1383494 is d

[tomcat] branch 8.5.x updated: Code clean-up. Formatting. No functional change.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 87e440948e Code clean-up. Formatting. No functional

[tomcat] branch 9.0.x updated: Code clean-up. Formatting. No functional change.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 25eaba18db Code clean-up. Formatting. No functional

[tomcat] branch 10.1.x updated: Code clean-up. Formatting. No functional change.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f32bf1dbf4 Code clean-up. Formatting. No function

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1f509bca8c Code clean-up. Formatting. No functional c

[tomcat] branch main updated: Correct removal version for deprecated code

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new ef88dfd484 Correct removal version for deprecated cod

[tomcat] branch main updated: Remove deprecated code

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 2a6b3fb0a6 Remove deprecated code 2a6b3fb0a6 is descr

[tomcat] branch 8.5.x updated: Support RFC 7616. Add support for multiple algorithms.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a38e8850c6 Support RFC 7616. Add support for multip

[tomcat] branch 9.0.x updated: Support RFC 7616. Add support for multiple algorithms.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4f6be52e9a Support RFC 7616. Add support for multip

[tomcat] branch 10.1.x updated: Support RFC 7616. Add support for multiple algorithms.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 010aab9b70 Support RFC 7616. Add support for mult

[tomcat] branch main updated: Fix bug in RFC 7616 changes. Spotted by lihan.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 2fb79f5b15 Fix bug in RFC 7616 changes. Spotted by li

Re: [tomcat] branch main updated: Support RFC 7616. Add support for multiple algorithms.

2023-03-15 Thread Mark Thomas
On 15/03/2023 02:35, Han Li wrote: On Mar 15, 2023, at 01:45, ma...@apache.org wrote: +boolean session = false; +if (algorithm.endsWith("-sess")) { +algorithm = algorithm.substring(0, algorithm.length() - 5); +} I guess here maybe a bug that ‘session’

Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-15 Thread Mark Thomas
On 15/03/2023 01:52, Igal Sapir wrote: Hello, test/org/apache/catalina/valves/rewrite/TestRewriteValve.java fails with file not found when a custom tomcat.output directory is specified in build.properties. I have the Tomcat source code (main branch) at /workspace/src/tomcat/main (let's call it

[tomcat] branch 8.5.x updated: Fix tests when running with custom tomcat.output

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 82028827c4 Fix tests when running with custom tomca

[tomcat] branch 9.0.x updated: Fix tests when running with custom tomcat.output

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 117d7fe78b Fix tests when running with custom tomca

[tomcat] branch 10.1.x updated: Fix tests when running with custom tomcat.output

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new c9a4038560 Fix tests when running with custom tom

[tomcat] branch main updated: Fix tests when running with custom tomcat.output

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e8611a122c Fix tests when running with custom tomcat.

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > [...] > > -1 unless the behaviour of "silently dropping extra parameters" is > changed as well. > > Silent loss of data is not what I want to see in production. > > Documentation [1] says "Request parameters beyond this limit will be ignored." >

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:29, Konstantin Kolinko : > > ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > > > ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > > > > > On 14/03/2023 21:13, Christopher Schultz wrote: > > > > Mark, > > > > > > > > On 3/14/23 13:57, Mark Thomas wrote: > > > >> On 09/03

Buildbot failure in on tomcat-8.5.x

2023-03-15 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/36/builds/431 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 8.5.x] 2c3c628138c363e86ba7fceb952b231716f680

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > > > On 14/03/2023 21:13, Christopher Schultz wrote: > > > Mark, > > > > > > On 3/14/23 13:57, Mark Thomas wrote: > > >> On 09/03/2023 14:23, Christopher Schultz wrote: > > >>> Mark, > > >>> > > >>>

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > On 14/03/2023 21:13, Christopher Schultz wrote: > > Mark, > > > > On 3/14/23 13:57, Mark Thomas wrote: > >> On 09/03/2023 14:23, Christopher Schultz wrote: > >>> Mark, > >>> > >>> On 3/9/23 05:56, Mark Thomas wrote: > Hi all, > > In the

[tomcat] branch 9.0.x updated: tomcat-jni.jar needs to be standalone

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new cd1b21d047 tomcat-jni.jar needs to be standalone cd

[tomcat] branch 10.1.x updated: tomcat-jni.jar needs to be standalone

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 2f1a40e32c tomcat-jni.jar needs to be standalone

[tomcat] branch main updated: tomcat-jni.jar needs to be standalone

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a398bdb872 tomcat-jni.jar needs to be standalone a398

Buildbot success in on tomcat-9.0.x

2023-03-15 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/493 Blamelist: Christopher Schultz , Igal Sapir , Mark Thomas , lihan Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x] b28e61513a47f01574f42

svn commit: r1908404 - in /tomcat/site/trunk: docs/ xdocs/

2023-03-15 Thread markt
Author: markt Date: Wed Mar 15 09:19:26 2023 New Revision: 1908404 URL: http://svn.apache.org/viewvc?rev=1908404&view=rev Log: Update migration guide for maxParameterCount changes. Fix a few copy/paste issues. Modified: tomcat/site/trunk/docs/migration-10.1.html tomcat/site/trunk/docs/mi

[tomcat] branch 8.5.x updated: Reduce the default for maxParameterCount from 10,000 to 1,000.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2c3c628138 Reduce the default for maxParameterCount

[tomcat] branch 9.0.x updated: Reduce the default for maxParameterCount from 10,000 to 1,000.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new be5c4c9696 Reduce the default for maxParameterCount

[tomcat] branch 10.1.x updated: Reduce the default for maxParameterCount from 10,000 to 1,000.

2023-03-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 7b6949ea7b Reduce the default for maxParameterCou

Re: Reduce default for maxParameterCount

2023-03-15 Thread Mark Thomas
On 14/03/2023 21:13, Christopher Schultz wrote: Mark, On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14:23, Christopher Schultz wrote: Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have bee

Buildbot success in on tomcat-10.1.x

2023-03-15 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/716 Blamelist: Christopher Schultz , Igal Sapir , lihan Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 10.1.x] 2d9c64e2ec56b9082c0c5bc4b1eed6

[GitHub] [tomcat] rmaucher commented on pull request #599: Use available constants

2023-03-15 Thread via GitHub
rmaucher commented on PR #599: URL: https://github.com/apache/tomcat/pull/599#issuecomment-1469470755 Personally, I hate these "work" branches. Please avoid them, and at the very least delete them afterwards. Thanks. -- This is an automated message from the Apache Git Service. To respond