[GitHub] [tomcat] isapir commented on a diff in pull request #598: Use available constants

isapir commented on code in PR #598: URL: https://github.com/apache/tomcat/pull/598#discussion_r1133421847 ## java/org/apache/catalina/storeconfig/ConnectorStoreAppender.java: ## @@ -29,6 +29,7 @@ import java.util.List; import java.util.Set; +import org.apache.catalina.Globa

[GitHub] [tomcat] isapir opened a new pull request, #598: Use available constants

isapir opened a new pull request, #598: URL: https://github.com/apache/tomcat/pull/598 We seem to have some duplication, e.g. `o.a.c.Globals.CATALINA_HOME_PROP` which is set from `o.a.c.startup.Constants.CATALINA_HOME_PROP`. Do we need `o.a.c.startup.Constants` to be separate for some

[tomcat] 01/01: Use available constants

This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch use-available-constants in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a393d738f67ab1be62a63f443e25386a66697661 Author: Igal Sapir AuthorDate: Sun Mar 12 20:42:25 2023 -0700

[tomcat] branch use-available-constants created (now a393d738f6)

This is an automated email from the ASF dual-hosted git repository. isapir pushed a change to branch use-available-constants in repository https://gitbox.apache.org/repos/asf/tomcat.git at a393d738f6 Use available constants This branch includes the following new commits: new a393d73

[Bug 66527] New: Embedded Tomcat addWebApp docBase usage is inconsistent with JavaDoc

https://bz.apache.org/bugzilla/show_bug.cgi?id=66527 Bug ID: 66527 Summary: Embedded Tomcat addWebApp docBase usage is inconsistent with JavaDoc Product: Tomcat 10 Version: 10.1.7 Hardware: PC OS: Linux

[GitHub] [tomcat] aooohan commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

aooohan commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1465410872 > One way to fix this would be to add an optional PK column (columns?) to the configuration. +1 -- This is an automated message from the Apache Git Service. To respond t

Re: Rate Limiter Filter or Valve

On Thu, Mar 9, 2023 at 12:27 AM Rémy Maucherat wrote: > On Wed, Mar 8, 2023 at 8:37 PM Igal Sapir wrote: > > > > All, > > > > I would like to add a Rate Limiter Filter or Valve which will help > mitigate > > DoS and Brute Force attacks, and want to get feedback from the community > > and the PMC

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1465328932 > One way to fix this would be to add an optional PK column (columns?) to the configuration +1 for a Primary Key column. It improves performance and is supported by all SQL compliant