Regarding IDE configuration files

Hi all, Recently, when setting up Tomcat for development with the Eclipse IDE, I noticed that the configuration files that come with Tomcat had multiple hard-coded (and outdated) references to some dependencies. Is it a good idea to handle class path configuration for IDEs by using a filters

[GitHub] [tomcat] gksxodnd007 commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

gksxodnd007 commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416100562 @markt-asf I'm sorry, but I'll follow your opinion. and I learn about the request smuggling risks while communication with you. thank you very much :) -- This is an automated messa

[GitHub] [tomcat] markt-asf commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

markt-asf commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416093124 My suggestion at this point would be to use custom 4xx and 5xx status codes in the application rather than re-using known codes. -- This is an automated message from the Apache Git Servi

[GitHub] [tomcat] gksxodnd007 commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

gksxodnd007 commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416087598 @rmaucher thank you for your explanation :) I understand. is there any better way that reuses the connection for utilizing computing resources? -- This is an automated message fro

[GitHub] [tomcat] ChristopherSchultz commented on pull request #581: Speedup by removing non pattern replaceAll with constant arg

ChristopherSchultz commented on PR #581: URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416024123 Apologies: my comments are rubbish after Java 9. Please forgive the noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [tomcat] ChristopherSchultz commented on pull request #581: Speedup by removing non pattern replaceAll with constant arg

ChristopherSchultz commented on PR #581: URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416017516 I think this "performance improvement" is not an improvement and doesn't affect performance in any meaningful way. -- This is an automated message from the Apache Git Service. T

[GitHub] [tomcat] ChristopherSchultz commented on pull request #581: Speedup by removing non pattern replaceAll with constant arg

ChristopherSchultz commented on PR #581: URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416015385 There isn't much of a difference between `String.replace` and `String.replaceAll`. They both use regular expressions under the hood. Java's `Pattern` class has a special case for

[tomcat] branch 8.5.x updated: Speedup by removing non pattern replaceAll with constant arg

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 19bc0c7ecf Speedup by removing non pattern replaceA

[tomcat] branch 9.0.x updated: Speedup by removing non pattern replaceAll with constant arg

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 315bdeac76 Speedup by removing non pattern replaceA

[tomcat] branch 10.1.x updated: Speedup by removing non pattern replaceAll with constant arg

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 14a0f91fd7 Speedup by removing non pattern replac

[tomcat] branch main updated: Add a changelog entry

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f6a46f38bd Add a changelog entry f6a46f38bd is descri

[tomcat] branch main updated: Speedup by removing non pattern replaceAll with constant arg

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 399ea1ba8d Speedup by removing non pattern replaceAll

[GitHub] [tomcat] markt-asf merged pull request #581: Speedup by removing non pattern replaceAll with constant arg

markt-asf merged PR #581: URL: https://github.com/apache/tomcat/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf commented on a diff in pull request #581: Speedup by removing non pattern replaceAll with constant arg

markt-asf commented on code in PR #581: URL: https://github.com/apache/tomcat/pull/581#discussion_r1095639347 ## java/org/apache/tomcat/buildutil/translate/Utils.java: ## @@ -123,7 +123,7 @@ static String formatValueCommon(String in) { result = ESCAPE_LEADING_SPACE.ma

[GitHub] [tomcat] rmaucher commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

rmaucher commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1415375850 Of course, some instances of these status codes would be "ok" to recover from, but Mark is actually right: it is not going to be deterministic. Also it is not possible to add "defensive"