[GitHub] [tomcat] efge commented on pull request #406: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-04-12 Thread GitBox
efge commented on pull request #406: URL: https://github.com/apache/tomcat/pull/406#issuecomment-818021878 Could someone have a look at merging this, if it's ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[Bug 65235] New: Mismatch between RemoteIpValve documentation and source code

2021-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65235 Bug ID: 65235 Summary: Mismatch between RemoteIpValve documentation and source code Product: Tomcat 9 Version: 9.0.45 Hardware: PC Status: NEW Sever

[GitHub] [tomcat] kkolinko commented on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
kkolinko commented on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817721078 > > > @kkolinko Regarding: > > > There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in use

Re: Annotations aren't working with tomcat 9

2021-04-12 Thread Rémy Maucherat
On Mon, Apr 12, 2021 at 12:51 PM Shrivastava, Vijay wrote: > Hi, > > @webservlet & @webListner annotations aren't working. > > Classes in which we are using these annotations are present in jar which > is getting scanned but registration of servlet with tomcat is not happening. > > What we have t

Annotations aren't working with tomcat 9

2021-04-12 Thread Shrivastava, Vijay
Hi, @webservlet & @webListner annotations aren't working. Classes in which we are using these annotations are present in jar which is getting scanned but registration of servlet with tomcat is not happening. What we have tried to fix: 1. To confirm the issue we downgraded Tomcat version in

[tomcat] branch master updated: Update version number

2021-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1db93d3 Update version number 1db93d3 is describe

[GitHub] [tomcat] dagnelies edited a comment on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
dagnelies edited a comment on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817654873 @kkolinko Regarding: > There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are cre

[GitHub] [tomcat] dagnelies commented on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
dagnelies commented on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817654873 @kkolinko Regarding: > There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are created a

[GitHub] [tomcat] kkolinko edited a comment on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
kkolinko edited a comment on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817630063 ` ` -1 for the above line. The "manager-jmx" role is not intended to be used by human users: it does not have CSRF protection. See https://tomcat.apa

[GitHub] [tomcat] kkolinko commented on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
kkolinko commented on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817630063 > -1 for the above line. The "manager-jmx" role is not intended to be used by human users: it does not have CSRF protection. See https://tomcat.apache.org/tomcat

[GitHub] [tomcat] martin-g commented on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
martin-g commented on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817610088 > can we perhaps simply try to re-run it? Re-scheduled it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat] dagnelies commented on pull request #412: Adding default manager roles in tomcat users config.

2021-04-12 Thread GitBox
dagnelies commented on pull request #412: URL: https://github.com/apache/tomcat/pull/412#issuecomment-817606698 Hi, since the Travis CI possibly failed due to some unrelated instability, can we perhaps simply try to re-run it? -- This is an automated message from the Apache Git Service.