[GitHub] [tomcat] martin-g commented on pull request #389: Optimize if condition

2020-12-15 Thread GitBox
martin-g commented on pull request #389: URL: https://github.com/apache/tomcat/pull/389#issuecomment-745849044 @lanicc Thanks for the PR! Can you please remove the merge commit ? This is an automated message from the Apa

[GitHub] [tomcat] lanicc opened a new pull request #389: Optimize if condition

2020-12-15 Thread GitBox
lanicc opened a new pull request #389: URL: https://github.com/apache/tomcat/pull/389 Optimize if condition in `AbstractProtocol.startAsyncTimeout()`, from `if (timeoutFuture == null || (timeoutFuture != null && timeoutFuture.isDone()))` to `if (timeoutFuture == null || timeoutFuture

Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Rory O'Donnell
Thanks Martin! On 15/12/2020 15:35, Martin Grigorov wrote: Hi Rory, We added some --add-opens to Tomcat and now the build and tests pass with JDK 16 b28 on both x86_64 and aarch64, Ubuntu 20.04! https://github.com/apache/tomcat/commit/f42f1899eda28244218bf4d29602bc99574d4486

Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Martin Grigorov
Hi Rory, We added some --add-opens to Tomcat and now the build and tests pass with JDK 16 b28 on both x86_64 and aarch64, Ubuntu 20.04! https://github.com/apache/tomcat/commit/f42f1899eda28244218bf4d29602bc99574d4486 https://github.com/apache/tomcat/commit/61f4baf64c69c5fd738d34b6139eda4549258cea

[tomcat] branch 7.0.x updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new e12d79f Add opens for Java 16 e12d79f is described

[tomcat] branch 8.5.x updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b10650e Add opens for Java 16 b10650e is described

[tomcat] branch 9.0.x updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d8636f0 Add opens for Java 16 d8636f0 is described

Re: [tomcat] branch master updated: Add opens for Java 16

2020-12-15 Thread Martin Grigorov
On Tue, Dec 15, 2020 at 3:35 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

[tomcat] branch master updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0a2ee9b Add opens for Java 16 0a2ee9b is describe

[tomcat] branch 7.0.x updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new c1d34b7 Add opens for Java 16 c1d34b7 is described

[tomcat] branch 8.5.x updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ae1b8be Add opens for Java 16 ae1b8be is described

[tomcat] branch 9.0.x updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 65b3af0 Add opens for Java 16 65b3af0 is described

[tomcat] branch master updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 61f4baf Add opens for Java 16 61f4baf is describe

Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Rémy Maucherat
On Tue, Dec 15, 2020 at 1:52 PM Martin Grigorov wrote: > Hi Rémy, > > On Mon, Dec 14, 2020 at 10:51 PM Mark Thomas wrote: > > > On 14/12/2020 11:06, Martin Grigorov wrote: > > > On Mon, Dec 14, 2020 at 12:30 PM Rémy Maucherat > wrote: > > > > > >> On Mon, Dec 14, 2020 at 8:53 AM Martin Grigorov

Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Martin Grigorov
Hi Rémy, On Mon, Dec 14, 2020 at 10:51 PM Mark Thomas wrote: > On 14/12/2020 11:06, Martin Grigorov wrote: > > On Mon, Dec 14, 2020 at 12:30 PM Rémy Maucherat wrote: > > > >> On Mon, Dec 14, 2020 at 8:53 AM Martin Grigorov > >> wrote: > >> > >>> Hi Tomcat team, > >>> > >>> The following tests

[tomcat] 02/02: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit acfeffcc0e9856d53deee1537dc5a558f82b91f4 Author: remm AuthorDate: Tue Dec 15 11:10:07 2020 +0100 Add opens for Java 16

[tomcat] 01/02: Checkstyle

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c0594c9af4811ef91ae407566ee0293df85d5e0a Author: remm AuthorDate: Tue Dec 15 11:08:36 2020 +0100 Checkstyle --- CONTR

[tomcat] branch 7.0.x updated (0a73005 -> acfeffc)

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 0a73005 Add a line about POEditor and a link to the WIKI page new c0594c9 Checkstyle new acfeffc Add opens

[tomcat] 01/02: Checkstyle

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7bc3d28de5e539dc7b07d524e04ea2cfc91a30c7 Author: remm AuthorDate: Tue Dec 15 11:08:36 2020 +0100 Checkstyle --- CONTR

[tomcat] 02/02: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 15c58043180cb885e7ff4bbb7dd135750d4e3e54 Author: remm AuthorDate: Tue Dec 15 11:10:07 2020 +0100 Add opens for Java 16

[tomcat] branch 8.5.x updated (db9fae0 -> 15c5804)

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from db9fae0 Add a line about POEditor and a link to the WIKI page new 7bc3d28 Checkstyle new 15c5804 Add opens

[tomcat] 02/02: Checkstyle

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 019f52c5d2b133586e507b03b94f12af05feaaa2 Author: remm AuthorDate: Tue Dec 15 11:08:36 2020 +0100 Checkstyle --- CONTR

[tomcat] 01/02: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit dc1c15009a815045a95e549f282d1d3bb21cb67c Author: remm AuthorDate: Tue Dec 15 11:10:07 2020 +0100 Add opens for Java 16

[tomcat] branch 9.0.x updated (1f22ac9 -> 019f52c)

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 1f22ac9 Add a line about POEditor and a link to the WIKI page new dc1c150 Add opens for Java 16 new 019f52c

[tomcat] branch master updated: Add opens for Java 16

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f42f189 Add opens for Java 16 f42f189 is describe

[tomcat] branch master updated: Checkstyle

2020-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8f5a591 Checkstyle 8f5a591 is described below co