Re: Application-accesible Executors

2020-09-21 Thread Martin Grigorov
Hi Chris, On Fri, Sep 18, 2020 at 7:10 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > I've recently been thinking about application uses of servlet-async and > Websocket for long-running operations, or really for any interactions > where you want to allow the request-pro

Re: WsFilter is missing destroy method

2020-09-21 Thread Apache
Interesting. Thanks, I will check in the morning. Ralph > On Sep 21, 2020, at 10:31 PM, Romain Manni-Bucau > wrote: > > Hi Ralph, > > Did you check your api jar was matching tomcat impl version? destroy is in > the interface (default method): > https://github.com/apache/tomcat/blob/9.0.x/jav

Re: WsFilter is missing destroy method

2020-09-21 Thread Romain Manni-Bucau
Hi Ralph, Did you check your api jar was matching tomcat impl version? destroy is in the interface (default method): https://github.com/apache/tomcat/blob/9.0.x/java/javax/servlet/Filter.java#L119 So without more details it sounds you have a dependency conflict or outdated import. Romain Manni-Bu

WsFilter is missing destroy method

2020-09-21 Thread Ralph Goers
I don’t understand why https://bz.apache.org/bugzilla/show_bug.cgi?id=63528 was closed with the comment “bugzilla is not a support forum”. Where else is one supposed to report bugs in Tomcat as this is a legitimate bug? It seems that WsFil

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696193669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r492175527 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-695996844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[tomcat] branch 8.5.x updated: Fix spelling

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3a0bb12 Fix spelling 3a0bb12 is described below c

[tomcat] branch 9.0.x updated: Fix spelling

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new dc5c7dc Fix spelling dc5c7dc is described below c

[tomcat] branch master updated: Fix spelling

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8e72db4 Fix spelling 8e72db4 is described below

[GitHub] [tomcat] mcgitty opened a new pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-21 Thread GitBox
mcgitty opened a new pull request #367: URL: https://github.com/apache/tomcat/pull/367 There seems to be no address resolution such that "http://localhost:8080/manager/html"; will not be treated as 127.0.0.1 in the RemoteAddrValve allow= pattern. -

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696218075 Yes, that is the JSP after the modifications. I asked you for a JSP that demonstrated the utility of the feature you propose. The JSP you provided did not compile. I made the min

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r492175527 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696211325 @markt-asf is this the jsp after the modifications? If not, can you attach your modified file ? Also, I know trimSpaces touches the empty output files/blank pages, but had ther

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696204359 ``` <%@ taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c"%> <%@ taglib uri="http://java.sun.com/jsp/jstl/functions"; prefix="fn" %>

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696193669 @markt-asf Can you attach what was your JSP when you tested this feature? This is an automated message from the A

[tomcat] branch 8.5.x updated: Consistent formatting of stream ID in HTTP/2 debug log messages

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f0959fe Consistent formatting of stream ID in HTTP

[tomcat] 01/02: Consistent formatting of stream ID in HTTP/2 debug log messages

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 53417b52e8b73523509a6eceb0f7bd3b4f78d778 Author: Mark Thomas AuthorDate: Mon Sep 21 14:52:33 2020 +0100 Consistent fo

[tomcat] branch 9.0.x updated (18f997d -> 51013bb)

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 18f997d Tab police new 53417b5 Consistent formatting of stream ID in HTTP/2 debug log messages new 51013bb

[tomcat] 02/02: Add debug so reason is visible for RST_STREAM frames on invalid streams

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 51013bbc86f0e8172163d6772b0eb6a0ff89efd7 Author: Mark Thomas AuthorDate: Mon Sep 21 14:57:27 2020 +0100 Add debug so

[tomcat] 01/02: Consistent formatting of stream ID in HTTP/2 debug log messages

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c1aaa4ed16b6410a602074132c75da6c85d6a8ed Author: Mark Thomas AuthorDate: Mon Sep 21 14:52:33 2020 +0100 Consistent f

[tomcat] 02/02: Add debug so reason is visible for RST_STREAM frames on invalid streams

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 27c4109a7a686b71454205faab909e5e1f041b18 Author: Mark Thomas AuthorDate: Mon Sep 21 14:57:27 2020 +0100 Add debug so

[tomcat] branch master updated (613787d -> 27c4109)

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 613787d Tab police new c1aaa4e Consistent formatting of stream ID in HTTP/2 debug log messages new 27c410

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-695996844 Taking the JSP sample above, I made the following changes so it would compile: - removed includes - replaced invalid expressions with hard-coded strings The resul

[tomcat] branch 9.0.x updated: Tab police

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 18f997d Tab police 18f997d is described below com

[tomcat] branch master updated: Tab police

2020-09-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 613787d Tab police 613787d is described below c