[Bug 64735] ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64735 --- Comment #5 from Kyle Stiemann --- Updated PRs fixing all the broken methods in ApplicationContextFacade and adding regression tests: master: https://github.com/apache/tomcat/pull/359 9.0.x: https://github.com/apache/tomcat/pull/360 -- Y

[GitHub] [tomcat] stiemannkj1 commented on pull request #360: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #360: URL: https://github.com/apache/tomcat/pull/360#issuecomment-691605029 Corresponding `9.0.x` PR: https://github.com/apache/tomcat/pull/360 This is an automated message from the Apach

[GitHub] [tomcat] stiemannkj1 commented on pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #358: URL: https://github.com/apache/tomcat/pull/358#issuecomment-691605000 @rmaucher, updated PR fixing all the broken methods and adding tests: https://github.com/apache/tomcat/pull/360 ---

[GitHub] [tomcat] stiemannkj1 opened a new pull request #360: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 opened a new pull request #360: URL: https://github.com/apache/tomcat/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] stiemannkj1 commented on pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #357: URL: https://github.com/apache/tomcat/pull/357#issuecomment-691604804 Updated PR: https://github.com/apache/tomcat/pull/359 This is an automated message from the Apache Git Service.

[GitHub] [tomcat] stiemannkj1 opened a new pull request #359: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 opened a new pull request #359: URL: https://github.com/apache/tomcat/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: Plans for Servlet 5.1

2020-09-12 Thread Filip Hanik
On 9/10/20, 01:17, "Mark Thomas" wrote: Hi all, It looks like at least one of the specs Tomcat implements, Servlets, is going to have at least one release between Jakarta EE 9 / Servlet 5.0 / Tomcat 10.0 and Jakarta EE 10/ Servlet 6.0 / Tomcat 10.1 The current plan is for

[GitHub] [tomcat] stokito commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-12 Thread GitBox
stokito commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690906236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [VOTE] Release Apache Tomcat 10.0.0-M8

2020-09-12 Thread Filip Hanik
X] Alpha - go ahead and release as 10.0.0-M8 On 9/10/20, 05:57, "Keiichi Fujino" wrote: 2020年9月9日(水) 23:57 Mark Thomas : > The proposed Apache Tomcat 10.0.0-M8 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary

Re: [VOTE] Release Apache Tomcat 9.0.38

2020-09-12 Thread Filip Hanik
[X] Stable - go ahead and release as 9.0.38 On 9/10/20, 05:58, "Keiichi Fujino" wrote: 2020年9月10日(木) 18:03 Mark Thomas : > The proposed Apache Tomcat 9.0.38 release is now available for voting. > > The notable changes compared to the 9.0.37 release are: > > - For reques

Re: [VOTE] Release Apache Tomcat 8.5.58

2020-09-12 Thread Filip Hanik
[X] Stable - go ahead and release as 8.5.58 On 9/10/20, 15:10, "Mark Thomas" wrote: The proposed Apache Tomcat 8.5.58 release is now available for voting. The notable changes compared to the 8.5.57 release are: - For requests containing the Expect: 100-continue header, optiona

[GitHub] [tomcat] rmaucher commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-12 Thread GitBox
rmaucher commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486924037 ## File path: java/org/apache/catalina/startup/LocalStrings_fr.properties ## @@ -69,6 +69,7 @@ contextConfig.missingRealm=Aucun royaume (realm) n'a été con

[GitHub] [tomcat] stiemannkj1 closed pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 closed pull request #358: URL: https://github.com/apache/tomcat/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] martin-g commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-12 Thread GitBox
martin-g commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690909792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tomcat] stiemannkj1 closed pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 closed pull request #357: URL: https://github.com/apache/tomcat/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] martin-g commented on a change in pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-12 Thread GitBox
martin-g commented on a change in pull request #352: URL: https://github.com/apache/tomcat/pull/352#discussion_r486991509 ## File path: java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java ## @@ -211,6 +216,46 @@ public final WebResource getResource(String path

[GitHub] [tomcat] stiemannkj1 commented on pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #358: URL: https://github.com/apache/tomcat/pull/358#issuecomment-691510095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] martin-g commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-12 Thread GitBox
martin-g commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486870063 ## File path: java/org/apache/catalina/startup/LocalStrings_fr.properties ## @@ -69,6 +69,7 @@ contextConfig.missingRealm=Aucun royaume (realm) n'a été con

[GitHub] [tomcat] stiemannkj1 commented on pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #357: URL: https://github.com/apache/tomcat/pull/357#issuecomment-691510106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] stokito commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-12 Thread GitBox
stokito commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690906236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] rmaucher commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-12 Thread GitBox
rmaucher commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486924037 ## File path: java/org/apache/catalina/startup/LocalStrings_fr.properties ## @@ -69,6 +69,7 @@ contextConfig.missingRealm=Aucun royaume (realm) n'a été con

[GitHub] [tomcat] stiemannkj1 closed pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 closed pull request #358: URL: https://github.com/apache/tomcat/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] martin-g commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-12 Thread GitBox
martin-g commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690909792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tomcat] stiemannkj1 closed pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 closed pull request #357: URL: https://github.com/apache/tomcat/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] martin-g commented on a change in pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-12 Thread GitBox
martin-g commented on a change in pull request #352: URL: https://github.com/apache/tomcat/pull/352#discussion_r486991509 ## File path: java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java ## @@ -211,6 +216,46 @@ public final WebResource getResource(String path

[GitHub] [tomcat] stiemannkj1 commented on pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #358: URL: https://github.com/apache/tomcat/pull/358#issuecomment-691510095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] martin-g commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-12 Thread GitBox
martin-g commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486870063 ## File path: java/org/apache/catalina/startup/LocalStrings_fr.properties ## @@ -69,6 +69,7 @@ contextConfig.missingRealm=Aucun royaume (realm) n'a été con

[GitHub] [tomcat] stiemannkj1 commented on pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #357: URL: https://github.com/apache/tomcat/pull/357#issuecomment-691510106 Closing this PR. I'll add tests and fix the other `SecurityManager` issues in this class and resend. This is a

[GitHub] [tomcat] stokito commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-12 Thread GitBox
stokito commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690906236 In fact Tomcat has hundreds of such places where simple, safe, and more readable optimizations can be applied. Just open sources in IntelliJ, open Settings/Editor/Inspections/Java/

[GitHub] [tomcat] stiemannkj1 commented on pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #358: URL: https://github.com/apache/tomcat/pull/358#issuecomment-691510095 Closing this PR. I'll add tests and fix the other `SecurityManager` issues in this class and resend. This is a

[GitHub] [tomcat] stiemannkj1 closed pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 closed pull request #357: URL: https://github.com/apache/tomcat/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] stiemannkj1 closed pull request #358: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 closed pull request #358: URL: https://github.com/apache/tomcat/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] stiemannkj1 commented on pull request #357: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-12 Thread GitBox
stiemannkj1 commented on pull request #357: URL: https://github.com/apache/tomcat/pull/357#issuecomment-691510106 Closing this PR. I'll add tests and fix the other `SecurityManager` issues in this class and resend. This is a