Re: [VOTE][RESULT][OT] Release Apache Tomcat Native 1.2.25

2020-09-03 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 9/3/20 10:34, Mark Thomas wrote: > The following votes were cast: > > Binding: +1: markt, mgrigorov, fschumacher > > +0: schultz > > The vote therefore passes. > > I think it is worth noting that there were crashes / unit test > failures re

[GitHub] [tomcat] kamnani commented on a change in pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #352: URL: https://github.com/apache/tomcat/pull/352#discussion_r483173883 ## File path: java/org/apache/catalina/webresources/JarContents.java ## @@ -0,0 +1,144 @@ +package org.apache.catalina.webresources; + +import java.util.BitS

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483128389 ## File path: java/org/apache/jasper/Options.java ## @@ -47,6 +47,13 @@ */ public boolean getKeepGenerated(); +/** + * Returns the Value

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483121476 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483121124 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483119869 ## File path: java/org/apache/jasper/JspC.java ## @@ -137,6 +137,7 @@ protected static final String SWITCH_POOLING = "-poolingEnabled"; protected s

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483088141 ## File path: java/org/apache/jasper/compiler/Generator.java ## @@ -2095,6 +2104,20 @@ public void visit(Node.JspElement n) throws JasperException {

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483088141 ## File path: java/org/apache/jasper/compiler/Generator.java ## @@ -2095,6 +2104,20 @@ public void visit(Node.JspElement n) throws JasperException {

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483088141 ## File path: java/org/apache/jasper/compiler/Generator.java ## @@ -2095,6 +2104,20 @@ public void visit(Node.JspElement n) throws JasperException {

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483087177 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

Re: Next release

2020-09-03 Thread Filip Hanik
On Thu, Sep 3, 2020 at 07:44 Mark Thomas wrote: > > > On 27/08/2020 14:15, Rémy Maucherat wrote: > > > On Thu, Aug 27, 2020 at 4:26 AM Filip Hanik > > > wrote: > > > On Wed, Aug 26, 2020 at 12:12 Rémy Maucherat > > > wrote: > > > O

Re: Next release

2020-09-03 Thread Mark Thomas
On 27/08/2020 14:15, Rémy Maucherat wrote: > On Thu, Aug 27, 2020 at 4:26 AM Filip Hanik > wrote: > On Wed, Aug 26, 2020 at 12:12 Rémy Maucherat > wrote: > On Wed, Aug 26, 2020 at 6:25 PM Filip Hanik

svn commit: r41306 - /dev/tomcat/tomcat-connectors/native/1.2.25/ /release/tomcat/tomcat-connectors/native/1.2.25/ /release/tomcat/tomcat-connectors/native/README.html

2020-09-03 Thread markt
Author: markt Date: Thu Sep 3 14:38:33 2020 New Revision: 41306 Log: Release Apache Tomcat Native 1.2.25 Added: release/tomcat/tomcat-connectors/native/1.2.25/ - copied from r41305, dev/tomcat/tomcat-connectors/native/1.2.25/ Removed: dev/tomcat/tomcat-connectors/native/1.2.25/ Mod

[VOTE][RESULT] Release Apache Tomcat Native 1.2.25

2020-09-03 Thread Mark Thomas
The following votes were cast: Binding: +1: markt, mgrigorov, fschumacher +0: schultz The vote therefore passes. I think it is worth noting that there were crashes / unit test failures reported with LibreSSL. This isn't unexpected. There is more work to do for LibreSSL support. Thanks to every

[GitHub] [tomcat] martin-g commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-03 Thread GitBox
martin-g commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r483001907 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] martin-g commented on a change in pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-03 Thread GitBox
martin-g commented on a change in pull request #352: URL: https://github.com/apache/tomcat/pull/352#discussion_r482996760 ## File path: java/org/apache/catalina/webresources/JarContents.java ## @@ -0,0 +1,144 @@ +package org.apache.catalina.webresources; + +import java.util.Bit

[GitHub] [tomcat] rmaucher closed pull request #353: Boot kanela

2020-09-03 Thread GitBox
rmaucher closed pull request #353: URL: https://github.com/apache/tomcat/pull/353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [tomcat] jaimecasero opened a new pull request #353: Boot kanela

2020-09-03 Thread GitBox
jaimecasero opened a new pull request #353: URL: https://github.com/apache/tomcat/pull/353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to