On 11/06/2020 21:59, Mark Thomas wrote:
> On 11/06/2020 21:24, Raymond Auge wrote:
>> This can totally be fixed in configuration. There is no problem. I just
>> wanted to make sure that in doing so we wouldn't just be pushing some
>> dirt under the rug so to speak.
>
> I'm concerned we might be do
On 11/06/2020 21:24, Raymond Auge wrote:
> This can totally be fixed in configuration. There is no problem. I just
> wanted to make sure that in doing so we wouldn't just be pushing some
> dirt under the rug so to speak.
I'm concerned we might be doing exactly that now we are heading into a
JPMS w
This can totally be fixed in configuration. There is no problem. I just
wanted to make sure that in doing so we wouldn't just be pushing some dirt
under the rug so to speak.
:)
- Ray
On Thu, Jun 11, 2020 at 3:25 PM Raymond Auge
wrote:
> To be clear, it's not necessarily having _all of a packag
чт, 11 июн. 2020 г. в 20:02, Christopher Schultz :
>
> All,
>
> I'm not sure who can fix this, but when I go to
> wiki.apache.org/tomcat, I'm redirected to
> https://cwiki-test.apache.org/confluence/display/tomcat which returns
> a "Service Unavailable" error.
>
> Without the /tomcat, I get redirec
To be clear, it's not necessarily having _all of a package_. It's more
about all the reachable class references. For instance jdeps looks at
classes and finds any reachable references. So does bnd for calculating
OSGi metadata.
So the issue is not really about packages, it's about having missing c
On Thu, Jun 11, 2020 at 9:01 PM Mark Thomas wrote:
> Hi,
>
> As discussed in PR#298 [1], properly/fully/correctly supporting JPMS /
> OSGi gets trickier than necessary with the bootstrap JAR because of the
> way we currently package it with the minimum that it needs and duplicate
> some classes.
markt-asf commented on pull request #297:
URL: https://github.com/apache/tomcat/pull/297#issuecomment-642879978
Tx. From my point of view better to have the changelog entry than not.
This is an automated message from the Apac
https://bz.apache.org/bugzilla/show_bug.cgi?id=64518
Mark Thomas changed:
What|Removed |Added
Resolution|--- |WONTFIX
OS|
Hi,
As discussed in PR#298 [1], properly/fully/correctly supporting JPMS /
OSGi gets trickier than necessary with the bootstrap JAR because of the
way we currently package it with the minimum that it needs and duplicate
some classes.
My simplistic understanding is that having all of a Java packag
https://bz.apache.org/bugzilla/show_bug.cgi?id=64518
Michael Enke changed:
What|Removed |Added
CC||michael.enke@wincor-nixdorf
markt-asf commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642864883
There are trade-offs here.
Modules require "clean packages" with all code from one package in one JAR.
Bootstrap uses utility code from elsewhere in the Tomcat code base.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64518
Bug ID: 64518
Summary: Illegal reflective access by WebappClassLoaderBase$1 -
embedded tomcat with resteasy
Product: Tomcat 7
Version: 7.0.104
Hardware: PC
St
markt-asf commented on pull request #299:
URL: https://github.com/apache/tomcat/pull/299#issuecomment-642862890
I back-ported this from 10.0.x
This is an automated message from the Apache Git Service.
To respond to the messag
markt-asf closed pull request #299:
URL: https://github.com/apache/tomcat/pull/299
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
https://bz.apache.org/bugzilla/show_bug.cgi?id=64515
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
rotty3000 commented on pull request #297:
URL: https://github.com/apache/tomcat/pull/297#issuecomment-642862668
Understood, if it's better to let you deal with the changelog I can do that.
I just want to avoid more work for you if I could.
-
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from a2410bb Add and use constants
new 44e8d71 Fix BZ 64515 - no need to filter bnd files (bnd passes ant
properties
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit b894ac363aec45be80c279323db4960a898ecd7f
Author: Mark Thomas
AuthorDate: Thu Jun 11 19:33:00 2020 +0100
Clean-up chan
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 44e8d71c018bd39f32a1384544eefa1d8325595a
Author: Raymond Augé
AuthorDate: Thu Jun 11 00:21:46 2020 -0400
Fix BZ 64515
markt-asf commented on pull request #297:
URL: https://github.com/apache/tomcat/pull/297#issuecomment-642859410
I added the bug number of the changelog entry (I had missed in in the
example you copied). The Tomcat committer id is always going to be tricky as
you don't know which committer
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 026ee2a Clean-up changelog
026ee2a is described
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new a546953 Fix BZ 64515 - no need to filter bnd fil
markt-asf merged pull request #297:
URL: https://github.com/apache/tomcat/pull/297
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This one was more intended to System.exit but it got aligned with mw impl
so it is quite close.
Le jeu. 11 juin 2020 à 19:40, Christopher Schultz <
ch...@christopherschultz.net> a écrit :
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Romain,
>
> On 6/11/20 13:34, Romain Manni-Bucau wrot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Romain,
On 6/11/20 13:34, Romain Manni-Bucau wrote:
> @Chris:
https://github.com/rmannibucau/letsencrypt-manager/blob/master/src/main/
java/com/github/rmannibucau/letsencrypt/manager/LetsEncryptManager.java
?
Thanks!
Stupid GitHub. I searched all
@Chris:
https://github.com/rmannibucau/letsencrypt-manager/blob/master/src/main/java/com/github/rmannibucau/letsencrypt/manager/LetsEncryptManager.java
?
it is more or less what we have in meecrowave except meecrowave can
hotreload whereas this (pre reloadSslHostConfig method) impl does not.
Romai
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Merlin,
On 6/10/20 12:32, Merlin Beedell wrote:
> Well thanks Christopher - that presentation link was just what I
> needed (well - it was your presentation after all!). Really good.
> Ideally this could be written into the Tomcat standard
> Documen
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
All,
I'm not sure who can fix this, but when I go to
wiki.apache.org/tomcat, I'm redirected to
https://cwiki-test.apache.org/confluence/display/tomcat which returns
a "Service Unavailable" error.
Without the /tomcat, I get redirected to the new Apa
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 5b794bb Add and use constants
5b794bb is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 5b794bb Add and use constants
5b794bb is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 5b794bb Add and use constants
5b794bb is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 5b794bb Add and use constants
5b794bb is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new a2410bb Add and use constants
a2410bb is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new dd558b6 Add and use constants
dd558b6 is describe
rotty3000 commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642690642
For the record I'm more interested in establishing a baseline for how to
handle these types of cases with the tomcat project. I will obviously follow
your direction :)
rotty3000 commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642689875
From a JPMS point of view the goal is always that jdeps results match up
with the module-info.class (i.e. that the jar is completely resolvable from the
module path) and if you d
rotty3000 commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642684919
So would you rather make the work around in the metadata calculation once/if
we get that far? Personally I rather make a valid jar than work around the
metadata but that's just p
markt-asf commented on pull request #298:
URL: https://github.com/apache/tomcat/pull/298#issuecomment-642679912
I don't think this is correct. Only those classes required during the
bootstrap process need to be in the bootstrap JAR. If this was not correct, I'd
expect to see reports of Cla
rotty3000 opened a new pull request #299:
URL: https://github.com/apache/tomcat/pull/299
… in)
Signed-off-by: Raymond Augé
This is an automated message from the Apache Git Service.
To respond to the message, please lo
rotty3000 opened a new pull request #298:
URL: https://github.com/apache/tomcat/pull/298
Signed-off-by: Raymond Augé
rotty3000 commented on pull request #295:
URL: https://github.com/apache/tomcat/pull/295#issuecomment-642638105
ah never mind, I found the changelog. I will update that from now on.
This is an automated message from the Apach
rotty3000 commented on pull request #295:
URL: https://github.com/apache/tomcat/pull/295#issuecomment-642635727
@markt-asf if there is some way for me to include the changelog update let
me know and I will include that in the future :)
-
rotty3000 commented on a change in pull request #296:
URL: https://github.com/apache/tomcat/pull/296#discussion_r438764896
##
File path: build.xml
##
@@ -375,6 +376,8 @@
+
Review comment:
it is transitively required by `Globals.java`
--
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 375f588 Move toPEM to PEMFile
375f588 is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 886f96d Move toPEM to PEMFile
886f96d is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 3075a2b Move toPEM to PEMFile
3075a2b is describe
https://bz.apache.org/bugzilla/show_bug.cgi?id=64513
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
markt-asf closed pull request #295:
URL: https://github.com/apache/tomcat/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new ba42096 Fix BZ 64513 - bndlib is not needed, norma
markt-asf commented on pull request #295:
URL: https://github.com/apache/tomcat/pull/295#issuecomment-642593455
Applied manually so I could add a change log entry.
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 640b789 Fix BZ 64509 - Correctly parse RFC 2109
add 83a6b36 Fix BZ 64513 - bndlib is not needed, normalize the
rmaucher commented on a change in pull request #296:
URL: https://github.com/apache/tomcat/pull/296#discussion_r438616279
##
File path: build.xml
##
@@ -375,6 +376,8 @@
+
Review comment:
Your BZ doesn't show use of this, so where is this used ?
52 matches
Mail list logo
