[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1390-L1394 How abouti

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1391 How abouting chaning th

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505220224 It's not easy for me to run a single test case now. I execute curl instead. I'll try to run single test case instead of execute command curl.

[GitHub] [tomcat] markt-asf commented on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
markt-asf commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505198902 I've started to put together a unit test for this. I've committed an initial version. It is parameterised so adding additional tests should be simple. I've tak

[tomcat] branch master updated: Start a unit test for Range requests and the Default servlet

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new d4509f4 Start a unit test for Range requests and

[GitHub] [tomcat] markt-asf closed pull request #169: Use STDIN for terminal availability check

2019-06-24 Thread GitBox
markt-asf closed pull request #169: Use STDIN for terminal availability check URL: https://github.com/apache/tomcat/pull/169 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [tomcat] markt-asf commented on issue #169: Use STDIN for terminal availability check

2019-06-24 Thread GitBox
markt-asf commented on issue #169: Use STDIN for terminal availability check URL: https://github.com/apache/tomcat/pull/169#issuecomment-505186984 Thanks for catching this and providing the fix. I applied to manually so I could include a changelog entry. ---

[tomcat] branch 7.0.x updated: Switch the check for terminal availability to test for stdin

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 5456eab Switch the check for terminal availability

[tomcat] branch master updated: Add missing title

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 853656a Add missing title 853656a is described b

[tomcat] branch 8.5.x updated: Switch the check for terminal availability to test for stdin

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 04bfd19 Switch the check for terminal availability

[tomcat] branch master updated: Switch the check for terminal availability to test for stdin

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 988d7cc Switch the check for terminal availabili

[tomcat] branch master updated: Fix typo

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4aacc21 Fix typo 4aacc21 is described below com

[tomcat] branch 8.5.x updated: Fix typo

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c73c16e Fix typo c73c16e is described below commi

[tomcat] branch 7.0.x updated: Use standard Java name for UTF-8

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 8550ae9 Use standard Java name for UTF-8 8550ae9 i

[tomcat] branch 7.0.x updated: Reduce the diff to 8.5.x. No functional change.

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new c73ad29 Reduce the diff to 8.5.x. No functional ch

[tomcat] 02/02: Use standard form to reference UTF-8

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 30e983d787eced738330a0063dee6beb6b1ef5b2 Author: Mark Thomas AuthorDate: Mon Jun 24 10:11:29 2019 +0100 Use standard

[tomcat] 01/02: Use standard charset rather than (non-standard) name for UTF-8

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ecf9143103b184bd996d519c4d8e454257b1cd30 Author: Mark Thomas AuthorDate: Mon Jun 24 10:11:08 2019 +0100 Use standard

[tomcat] branch 8.5.x updated (f2dfcb0 -> 30e983d)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from f2dfcb0 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58590 new ecf9143 Use standard charset rather than (n

[tomcat] branch 8.5.x updated (f83eae6 -> f2dfcb0)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from f83eae6 Clean-up. No functional change. new 6901b49 Skip checkstyle for test files without ALv2 header new

[tomcat] 02/02: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58590

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f2dfcb07f3aa00676f97e9a9da9ed4f1349e2ab2 Author: Mark Thomas AuthorDate: Mon Jun 24 18:01:31 2019 +0100 Fix https://b

[tomcat] 01/02: Skip checkstyle for test files without ALv2 header

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6901b494980a02b269923fa68d5211363a018e38 Author: Mark Thomas AuthorDate: Mon Jun 24 18:04:23 2019 +0100 Skip checksty

[tomcat] branch 8.5.x updated (912d12f -> f83eae6)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 912d12f Clean-up. No functional change. new 5090469 Clean-up. No functional change. new 0c86919 Review thr

[tomcat] 01/03: Clean-up. No functional change.

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 50904699381831df6ea6bede68f56ee288dede34 Author: Mark Thomas AuthorDate: Fri Sep 14 07:27:09 2018 + Clean-up. No

[tomcat] 02/03: Review thread-safety Document locking strategy

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0c86919128fd90a4904597403c6ffe24469f78d0 Author: Mark Thomas AuthorDate: Fri Sep 14 08:41:02 2018 + Review thread

[tomcat] 03/03: Clean-up. No functional change.

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f83eae67d88224c05b780255b832f68ae6531ad6 Author: Mark Thomas AuthorDate: Mon Jun 24 16:42:28 2019 +0100 Clean-up. No

Re: [tomcat] 02/02: Remove mappings provided by the JVM

2019-06-24 Thread Mark Thomas
On 24/06/2019 15:27, Mark Thomas wrote: > On 24/06/2019 13:56, Konstantin Kolinko wrote: >> пн, 24 июн. 2019 г. в 15:51, : >>> >>> This is an automated email from the ASF dual-hosted git repository. >>> >>> markt pushed a commit to branch 8.5.x >>> in repository https://gitbox.apache.org/repos/asf/

Re: [tomcat] 02/02: Remove mappings provided by the JVM

2019-06-24 Thread Mark Thomas
On 24/06/2019 13:56, Konstantin Kolinko wrote: > пн, 24 июн. 2019 г. в 15:51, : >> >> This is an automated email from the ASF dual-hosted git repository. >> >> markt pushed a commit to branch 8.5.x >> in repository https://gitbox.apache.org/repos/asf/tomcat.git >> >> commit 41db6c85dfb6f704e2911fb2

[tomcat] branch 8.5.x updated: Clean-up. No functional change.

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 912d12f Clean-up. No functional change. 912d12f is

[tomcat] branch master updated: Unnecessary space

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f9ffd5b Unnecessary space f9ffd5b is described b

[tomcat] branch 8.5.x updated: Clean-up to align 8.5.x with 9.0.x

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4b45d66 Clean-up to align 8.5.x with 9.0.x 4b45d66

Re: [tomcat] 02/02: Remove mappings provided by the JVM

2019-06-24 Thread Konstantin Kolinko
пн, 24 июн. 2019 г. в 15:51, : > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch 8.5.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit 41db6c85dfb6f704e2911fb2e41a72e6944852ae > Author: Mark Thomas > AuthorDate: Mo

[tomcat] branch 8.5.x updated (486e49e -> 41db6c8)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 486e49e Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=49464 new cda33ce Fix charset name for UTF-32LE in bo

[tomcat] 02/02: Remove mappings provided by the JVM

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 41db6c85dfb6f704e2911fb2e41a72e6944852ae Author: Mark Thomas AuthorDate: Mon Jun 24 10:09:55 2019 +0100 Remove mappin

[tomcat] 01/02: Fix charset name for UTF-32LE in bom detection.

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cda33ce11b0a354b39861016bee440ad5af03c9b Author: zhanhb <6323014+zha...@users.noreply.github.com> AuthorDate: Fri Jun 21 20

[Bug 49464] DefaultServlet and CharacterEncoding

2019-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=49464 --- Comment #9 from Mark Thomas --- It has been almost 2 years without further regressions so I have back-ported this to 8.5.x for 8.5.43 onwards. -- You are receiving this mail because: You are the assignee for the bug. -

[tomcat] 01/02: Add version info to deprecation markers

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 806b2f9ae3cf4ff3767d47def59b3db3abdf0a73 Author: Mark Thomas AuthorDate: Mon Jun 24 11:10:45 2019 +0100 Add version i

[tomcat] 02/02: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=49464

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 486e49e7c9e36c3adb93f1ec684c7d3d4a59fe69 Author: Mark Thomas AuthorDate: Mon Jun 24 13:38:12 2019 +0100 Fix https://b

[tomcat] branch 8.5.x updated (41ea849 -> 486e49e)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 41ea849 When using WebDAV to copy a file resource to a destination that requires a collection to be overwritten, ensu

[tomcat] branch master updated: Correct test parameter labels

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8af9e90 Correct test parameter labels 8af9e90 is

[tomcat] branch master updated: Add version info to deprecation markers

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 3fd38c0 Add version info to deprecation markers

[tomcat] 01/02: Back-port spotbugs fixes

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4ec3d26396e4d8804629d31fa2459eb1401bcf44 Author: Mark Thomas AuthorDate: Mon Jun 24 10:54:54 2019 +0100 Back-port spo

[tomcat] branch 8.5.x updated (8f9fdb0 -> 41ea849)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 8f9fdb0 Correct sub-section order new 4ec3d26 Back-port spotbugs fixes new 41ea849 When using WebDAV to co

[tomcat] 02/02: When using WebDAV to copy a file resource to a destination that requires a collection to be overwritten, ensure that the operation succeeds rather than fails (with a 500 response). Thi

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 41ea8490b92499e32cc1392e9d53aa7db18ef1fc Author: Mark Thomas AuthorDate: Mon Jan 8 15:52:15 2018 + When using Web

[tomcat] 01/02: Align use of Allow header and HTTP 405 status code

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 00a302f75fa757d91967fdc03a8abfd1b2bb3d26 Author: Mark Thomas AuthorDate: Tue Jan 9 13:50:52 2018 + Align use of A

[tomcat] branch 8.5.x updated (bcb0e5b -> 8f9fdb0)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from bcb0e5b Aligning o.a.c.servlets between 9.0.x and 8.5.x. No functional change. new 00a302f Align use of Allow h

[tomcat] 02/02: Correct sub-section order

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8f9fdb0eab7ec7ff0eeb8debbd8c5629da9729c0 Author: Mark Thomas AuthorDate: Mon Jun 24 10:50:19 2019 +0100 Correct sub-s

[tomcat] branch 8.5.x updated: Aligning o.a.c.servlets between 9.0.x and 8.5.x. No functional change.

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new bcb0e5b Aligning o.a.c.servlets between 9.0.x and

[tomcat] 01/03: Remove mappings provided by the JVM

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a610cf45177b7d49a23c99bb969c391f0d74a1b3 Author: Mark Thomas AuthorDate: Mon Jun 24 10:09:55 2019 +0100 Remove mappi

[tomcat] 02/03: Use standard charset rather than (non-standard) name for UTF-8

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d0bfb8a33d15de94c9f3f31a6c4a0594b0c831fb Author: Mark Thomas AuthorDate: Mon Jun 24 10:11:08 2019 +0100 Use standard

[tomcat] branch master updated (d328560 -> 7b37b04)

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from d328560 Fix charset name for UTF-32LE in bom detection. new a610cf4 Remove mappings provided by the JVM ne

[tomcat] 03/03: Use standard form to reference UTF-8

2019-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7b37b0429dc511929a546078f5ce9e5517a7eab4 Author: Mark Thomas AuthorDate: Mon Jun 24 10:11:29 2019 +0100 Use standard