[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [L559-R559](https://github.com/apache/tomcat/pull/172/fil

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [Line L559-R559](https://github.com/apache/tomcat/pull/17

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. - [Line L559-R559](https://github.com/apache/tomcat/pull/17

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. [Line L559-R559](https://github.com/apache/tomcat/pull/172/file

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. [Line L559-R559](https://github.com/apache/tomcat/pull/172/file

[GitHub] [tomcat] zhanhb commented on issue #172: Process request range as specified in RFC 7233

zhanhb commented on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. [Line L559](https://github.com/apache/tomcat/pull/172/files#diff-355391

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376 RFC 7233 says `If-Range should be compared with strong validator.` This can't be applied. I test on chrome 75 and find Header `If-Rang

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376 RFC 7233 `If-Range should be compared with strong validator.` This can't be applied. I test on chrome 75 and find Header `If-Range` is

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376 RFC 7233 `If-Range should be compared with strong validator.` This can't be applied. I test on chrome 75 and find Header `If-Range` is

[GitHub] [tomcat] zhanhb commented on issue #172: Process request range as specified in RFC 7233

zhanhb commented on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376 RFC 7233 `If-Range should be compared with strong validator.` This can't be applied. I test on chrome 75 and find Head If-Range is sent. Maybe

[Bug 63524] Private key must be accompanied by certificate chain

https://bz.apache.org/bugzilla/show_bug.cgi?id=63524 --- Comment #1 from Arnaud Kleinveld --- The domain1 configuration is also in use by a httpd server which is working fine. Upgraded lets-encrypt-x1-cross-signed.pem to lets-encrypt-x3-cross-signed.pem for domain2, unfortunately that didn't make

[Bug 63524] New: Private key must be accompanied by certificate chain

https://bz.apache.org/bugzilla/show_bug.cgi?id=63524 Bug ID: 63524 Summary: Private key must be accompanied by certificate chain Product: Tomcat 8 Version: 8.5.40 Hardware: PC OS: Linux Status: NEW Severit

[GitHub] [tomcat] zhanhb commented on issue #172: Process request range as specified in RFC 7233

zhanhb commented on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504668180 Thanks for read the changes carefully. I'll add test cases soon. IMO, most changes can be treated as bug fix or clean the source rather than b

[GitHub] [tomcat] markt-asf commented on issue #172: Process request range as specified in RFC 7233

markt-asf commented on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504667725 +1. I was thinking list out issues, separate commit (and PR?) for each and some unit tests would make this easier to review. I suspect

[GitHub] [tomcat] FSchumacher commented on issue #172: Process request range as specified in RFC 7233

FSchumacher commented on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504652328 This seems to be a bigger change. It would be really awesome, if you could add junit tests that show the old misbehaviour and the new mo

[tomcat] branch master updated: Fix charset name for UTF-32LE in bom detection.

This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new d328560 Fix charset name for UTF-32LE in b

[GitHub] [tomcat] asfgit closed pull request #173: Fix charset name in bom detection.

asfgit closed pull request #173: Fix charset name in bom detection. URL: https://github.com/apache/tomcat/pull/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a