[tomcat] branch master updated: Fix entry category

2019-05-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 9b1cb7f Fix entry category 9b1cb7f is described b

[tomcat] branch master updated: Gump nag

2019-05-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ddaba13 Gump nag ddaba13 is described below comm

Re: The migration guide configuration file difference feature is broken

2019-05-08 Thread Konstantin Kolinko
> >>> Looking at the "configure > >>> file differences" section on the 9.0 migration guide ( > >>> http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences), > >>> if you click the "view differences" button you get taken to the gitbox web > >>> UI, but it returns a 403.

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2019-05-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

Re: The migration guide configuration file difference feature is broken

2019-05-08 Thread Mark Thomas
On 08/05/2019 17:21, Konstantin Kolinko wrote: > ср, 8 мая 2019 г. в 18:16, Mark Thomas : >> >> On 08/05/2019 15:35, Coty Sutherland wrote: >>> Hi, >>> >>> Someone on freenode (CiscoEagle) pointed out to me that the migration >>> guide's file comparison feature doesn't work :( > > This has already

Re: javax.tools based JSP compiler

2019-05-08 Thread Mark Thomas
On 08/05/2019 21:58, Rémy Maucherat wrote: > On Wed, May 8, 2019 at 10:31 PM Emmanuel Bourg wrote: > >> Hi all, >> >> I've rebased the javax.tools JSP compiler on top of the current master >> branch : >> >> https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support >> >> Please let me kno

[tomcat] branch master updated: Removed the redundant 'static' modifier on the enums

2019-05-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a7a4b72 Removed the redundant 'static' modifier

buildbot success in on tomcat-trunk

2019-05-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4317 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

Applet in the documentation

2019-05-08 Thread Emmanuel Bourg
Hi, We have a clock applet in the documentation illustrating the use of the tag. Applet support has been removed from all browsers now, it's unlikely to be useful anymore. Any objection to drop this example from the documentation? Emmanuel Bourg

[tomcat] branch master updated: Fixed the javadoc in CheckEol

2019-05-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ad9b999 Fixed the javadoc in CheckEol ad9b999 i

[tomcat] branch master updated: Removed the CVS and Subversion directories from the paths excluded by javac

2019-05-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e9c253f Removed the CVS and Subversion director

buildbot failure in on tomcat-trunk

2019-05-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4315 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Changed 'ant validate-eoln' to always check LF line endings regardless of the OS (by default Git checks out the files with LF EOL even on Windows)

2019-05-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1fb000c Changed 'ant validate-eoln' to always c

Re: javax.tools based JSP compiler

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 10:31 PM Emmanuel Bourg wrote: > Hi all, > > I've rebased the javax.tools JSP compiler on top of the current master > branch : > > https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support > > Please let me know how you feel about this stuff and if it's worth mergi

[tomcat] branch master updated: Use ArrayList instead of Vector.

2019-05-08 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1b83f52 Use ArrayList instead of Vector. 1b83f

Re: javax.tools based JSP compiler

2019-05-08 Thread Emmanuel Bourg
Hi all, I've rebased the javax.tools JSP compiler on top of the current master branch : https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support Please let me know how you feel about this stuff and if it's worth merging. Emmanuel Bourg Le 09/04/2018 à 17:28, Emmanuel Bourg a écrit :

[tomcat] branch master updated: Adjust code comment.

2019-05-08 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5d7ab23 Adjust code comment. 5d7ab23 is descri

[tomcat] branch master updated: Ignore more IntelliJ files

2019-05-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 95f85b7 Ignore more IntelliJ files 95f85b7 is d

Re: More Vector -> ArrayList

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 10:06 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > It seems that Vector is used a lot in Tomcat code. > > Since the JSP engine is riddled with uses, I figured I'd start > elsewhere with my clea

More Vector -> ArrayList

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, It seems that Vector is used a lot in Tomcat code. Since the JSP engine is riddled with uses, I figured I'd start elsewhere with my cleanup. Here's something glaring: o.a.c.connector.Response:882 @Override public Collection getHeader

[tomcat] branch master updated: Replace custom split(String, String) method with call to String.split.

2019-05-08 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f7c41d1 Replace custom split(String,String) me

buildbot failure in on tomcat-85-trunk

2019-05-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1764 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

[Bug 63412] WebSocket examples in Tomcat 9.0.20 RC fail with SecurityManager

2019-05-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63412 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch master updated: 63412: Fix security manager issue with async IO

2019-05-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c662b54 63412: Fix security manager issue with as

[tomcat] branch master updated: Replace uses of Vector with ArrayList.

2019-05-08 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a5d2c73 Replace uses of Vector with ArrayList.

[tomcat] branch 8.5.x updated: Remove custom split() method. String.split is already optimized for single-character splits and won't use a regex.

2019-05-08 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f295e8d Remove custom split() method. String.spl

Re: Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Martin, On 5/8/19 13:58, Martin Grigorov wrote: > Hi, > > On Wed, May 8, 2019 at 7:16 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > While working on the sort-file-listing enhancement over the > weekend, I looked in

[tomcat] branch master updated: Remove custom split() method. String.split is already optimized for single-character splits and won't use a regex.

2019-05-08 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new bae1f02 Remove custom split() method. String.s

Re: Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/8/19 12:35, Mark Thomas wrote: > On 08/05/2019 17:30, Christopher Schultz wrote: >> >> Back to JspUtil.split. It's private and used exactly one place. >> AND it's only ever called with a single-character String value. >> So actually the

Re: Micro-optimizations

2019-05-08 Thread Martin Grigorov
Hi, On Wed, May 8, 2019 at 7:16 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > While working on the sort-file-listing enhancement over the weekend, I > looked in the Tomcat code to see if we already had a method to sp

ApacheCon call for presentations, httpd content

2019-05-08 Thread jean-frederic clere
Hi, folks. The call for presentations for ApacheCon North America closes in a little less than 6 days. The CFP is here - https://www.apachecon.com/acna19/cfp.html - and closes May 13th. Thanks! Jean-Frederic - To unsubscribe,

[Bug 63412] WebSocket examples in Tomcat 9.0.20 RC fail with SecurityManager

2019-05-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63412 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Mauchera

Re: [OT] Jakarta package change

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 6:22 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark, > > On 5/7/19 06:31, Mark Thomas wrote: > > Rather than announcing a solution, how about we announce that we > > will continue to support the java

Re: Micro-optimizations

2019-05-08 Thread Mark Thomas
On 08/05/2019 17:30, Christopher Schultz wrote: > Mark, > > On 5/8/19 12:20, Mark Thomas wrote: >> On 08/05/2019 17:16, Christopher Schultz wrote: >>> All, >>> >>> While working on the sort-file-listing enhancement over the >>> weekend, I looked in the Tomcat code to see if we already had a >>> me

Re: Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/8/19 12:20, Mark Thomas wrote: > On 08/05/2019 17:16, Christopher Schultz wrote: >> All, >> >> While working on the sort-file-listing enhancement over the >> weekend, I looked in the Tomcat code to see if we already had a >> method to sp

Re: [OT] Jakarta package change

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/7/19 06:31, Mark Thomas wrote: > Rather than announcing a solution, how about we announce that we > will continue to support the javax.* APIS (Servlet 4.0, JSP 2.3, EL > 3.0, WebSocket 1.1 and JASPIC 1.1) until at least 31 Dec 2030*. > No

Re: The migration guide configuration file difference feature is broken

2019-05-08 Thread Konstantin Kolinko
ср, 8 мая 2019 г. в 18:16, Mark Thomas : > > On 08/05/2019 15:35, Coty Sutherland wrote: > > Hi, > > > > Someone on freenode (CiscoEagle) pointed out to me that the migration > > guide's file comparison feature doesn't work :( This has already been reported 5-6 times. See the archives. > > Lookin

Re: Micro-optimizations

2019-05-08 Thread Mark Thomas
On 08/05/2019 17:16, Christopher Schultz wrote: > All, > > While working on the sort-file-listing enhancement over the weekend, I > looked in the Tomcat code to see if we already had a method to split a > string by a single character. The closest method I found was > org.pache.jasper.compiler.JspU

Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, While working on the sort-file-listing enhancement over the weekend, I looked in the Tomcat code to see if we already had a method to split a string by a single character. The closest method I found was org.pache.jasper.compiler.JspUtil which s

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-08 Thread Konstantin Kolinko
сб, 4 мая 2019 г. в 01:52, Mark Thomas : > > The proposed Apache Tomcat 9.0.20 release is now available for voting. > > > The proposed 9.0.20 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 9.0.20 Not voting yet. 1. Unit tests (Java 8 32-bit, windows 10, all conne

[Bug 63412] New: WebSocket examples in Tomcat 9.0.20 RC fail with SecurityManager

2019-05-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63412 Bug ID: 63412 Summary: WebSocket examples in Tomcat 9.0.20 RC fail with SecurityManager Product: Tomcat 9 Version: 9.0.x Hardware: PC Status: NEW Se

Re: The migration guide configuration file difference feature is broken

2019-05-08 Thread Coty Sutherland
On Wed, May 8, 2019 at 11:17 AM Mark Thomas wrote: > On 08/05/2019 15:35, Coty Sutherland wrote: > > Hi, > > > > Someone on freenode (CiscoEagle) pointed out to me that the migration > > guide's file comparison feature doesn't work :( Looking at the "configure > > file differences" section on the

Re: The migration guide configuration file difference feature is broken

2019-05-08 Thread Mark Thomas
On 08/05/2019 15:35, Coty Sutherland wrote: > Hi, > > Someone on freenode (CiscoEagle) pointed out to me that the migration > guide's file comparison feature doesn't work :( Looking at the "configure > file differences" section on the 9.0 migration guide ( > http://tomcat.apache.org/migration-9.ht

The migration guide configuration file difference feature is broken

2019-05-08 Thread Coty Sutherland
Hi, Someone on freenode (CiscoEagle) pointed out to me that the migration guide's file comparison feature doesn't work :( Looking at the "configure file differences" section on the 9.0 migration guide ( http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences), if you