Re: [OT] Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Chris, On 4/25/2019 12:08 PM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/25/19 14:42, Igal Sapir wrote: On 4/25/2019 11:30 AM, Coty Sutherland wrote: If you clone a single branch with no references such as `git clone apache/tomcat -b master --single

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Chris, On 4/25/2019 12:07 PM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/25/19 14:03, Igal Sapir wrote: Chris, On 4/25/2019 10:32 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir wr

Re: [OT] Finally getting around to switching to Git

2019-04-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/25/19 14:42, Igal Sapir wrote: > On 4/25/2019 11:30 AM, Coty Sutherland wrote: >> If you clone a single branch with no references such as `git >> clone apache/tomcat -b master --single-branch` then you get just >> the references/history f

Re: Finally getting around to switching to Git

2019-04-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/25/19 14:03, Igal Sapir wrote: > Chris, > > On 4/25/2019 10:32 AM, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Igal, >> >> On 4/23/19 12:52, Igal Sapir wrote: >>> Another thing that I have change

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Coty, On 4/25/2019 11:30 AM, Coty Sutherland wrote: On Thu, Apr 25, 2019 at 2:06 PM Igal Sapir wrote: On 4/25/2019 10:56 AM, Coty Sutherland wrote: On Thu, Apr 25, 2019 at 1:32 PM Christopher Schultz < ch...@christopherschultz.net> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Ig

Re: Finally getting around to switching to Git

2019-04-25 Thread Coty Sutherland
On Thu, Apr 25, 2019 at 2:06 PM Igal Sapir wrote: > On 4/25/2019 10:56 AM, Coty Sutherland wrote: > > On Thu, Apr 25, 2019 at 1:32 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA256 > >> > >> Igal, > >> > >> On 4/23/19 1

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
On 4/25/2019 10:56 AM, Coty Sutherland wrote: On Thu, Apr 25, 2019 at 1:32 PM Christopher Schultz < ch...@christopherschultz.net> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir wrote: Another thing that I have changed in my workflow based on Mark's

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Chris, On 4/25/2019 10:32 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir wrote: Another thing that I have changed in my workflow based on Mark's past suggestion, is that I keep a local repo for each major branch now. Okay, I

Re: Finally getting around to switching to Git

2019-04-25 Thread Coty Sutherland
On Thu, Apr 25, 2019 at 1:32 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 4/23/19 12:52, Igal Sapir wrote: > > Another thing that I have changed in my workflow based on Mark's > > past suggestion, is that I keep

Re: Finally getting around to switching to Git

2019-04-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir wrote: > Another thing that I have changed in my workflow based on Mark's > past suggestion, is that I keep a local repo for each major branch > now. Okay, I have done the following: 1. Fork tomcat master to my o

[GitHub] [tomcat] isapir commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance

2019-04-25 Thread GitBox
isapir commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance URL: https://github.com/apache/tomcat/pull/160#issuecomment-486764240 Is your remote configured for https:// (rather than git://)?. Run `git remote -v` to view the remote URLs. I was trying at first to

[GitHub] [tomcat] ChristopherSchultz commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance

2019-04-25 Thread GitBox
ChristopherSchultz commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance URL: https://github.com/apache/tomcat/pull/160#issuecomment-486762240 Just exercising everything to make sure it works how I expect it to work. For example, Eclipse crapped its pants whe

Re: JDK 13 - Early Access build 17 is available

2019-04-25 Thread Mark Thomas
On 19/04/2019 13:40, Rory O'Donnell wrote: > > *Hi Mark, * > > *OpenJDK builds *- JDK 13 - Early Access build 17 is available at > http://jdk.java.net/13/ FYI, Built and run Tomcat 9.0.x/master unit tests without any failures. Built Tomcat 9.0.x/master and passed a (very) basic smoke test. No

Re: Becoming graalvm friendly?

2019-04-25 Thread Rémy Maucherat
On Wed, Apr 24, 2019 at 6:29 PM Romain Manni-Bucau wrote: > Awesome news Rémy, thanks for sharing! > Next roadblock is https://github.com/oracle/graal/issues/684 It's probably not 100% mandatory but I'd rather have a minimum of flexibility (I'm not a big believer of Java only embedding since con

[GitHub] [tomcat] uhees opened a new pull request #161: Early check end of input condition to avoid ArrayIndexOutOfBoundsExceptions

2019-04-25 Thread GitBox
uhees opened a new pull request #161: Early check end of input condition to avoid ArrayIndexOutOfBoundsExceptions URL: https://github.com/apache/tomcat/pull/161 Exceptions are expensive and should only be thrown in an exceptional state. End of input is no exception but should be expected.