[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-11-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

svn commit: r1847153 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-11-21 Thread schultz
Author: schultz Date: Thu Nov 22 02:58:34 2018 New Revision: 1847153 URL: http://svn.apache.org/viewvc?rev=1847153&view=rev Log: Fix import order. (*eyeroll*) Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java Modified: tomcat/trunk/test/o

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-11-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

svn commit: r1847144 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-11-21 Thread schultz
Author: schultz Date: Wed Nov 21 22:48:01 2018 New Revision: 1847144 URL: http://svn.apache.org/viewvc?rev=1847144&view=rev Log: Add unit tests to ensure ciphertext uniqueness and test multiple message delivery. Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestE

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 15:11, Mark Thomas wrote: > On 21/11/2018 19:43, Christopher Schultz wrote: >> Mark, >> >> On 11/21/18 11:51, Mark Thomas wrote: >>> On 21/11/2018 16:36, Mark Thomas wrote: On 21/11/2018 15:37, Mark Thomas wrote: > On 21/

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Mark Thomas
On 21/11/2018 19:43, Christopher Schultz wrote: > Mark, > > On 11/21/18 11:51, Mark Thomas wrote: >> On 21/11/2018 16:36, Mark Thomas wrote: >>> On 21/11/2018 15:37, Mark Thomas wrote: On 21/11/2018 15:29, Christopher Schultz wrote: > All, > > With this last patch, I'm ready for a

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 11:51, Mark Thomas wrote: > On 21/11/2018 16:36, Mark Thomas wrote: >> On 21/11/2018 15:37, Mark Thomas wrote: >>> On 21/11/2018 15:29, Christopher Schultz wrote: All, With this last patch, I'm ready for a back-port

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 11:36, Mark Thomas wrote: > On 21/11/2018 15:37, Mark Thomas wrote: >> On 21/11/2018 15:29, Christopher Schultz wrote: >>> All, >>> >>> With this last patch, I'm ready for a back-port to tc8.5.x, but >>> I'm waiting for a user who

svn commit: r1847124 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 17:00:48 2018 New Revision: 1847124 URL: http://svn.apache.org/viewvc?rev=1847124&view=rev Log: Another false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Mark Thomas
On 21/11/2018 16:36, Mark Thomas wrote: > On 21/11/2018 15:37, Mark Thomas wrote: >> On 21/11/2018 15:29, Christopher Schultz wrote: >>> All, >>> >>> With this last patch, I'm ready for a back-port to tc8.5.x, but I'm >>> waiting for a user who is trying to get this working on tc9.0 to be >>> succe

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Mark Thomas
On 21/11/2018 15:37, Mark Thomas wrote: > On 21/11/2018 15:29, Christopher Schultz wrote: >> All, >> >> With this last patch, I'm ready for a back-port to tc8.5.x, but I'm >> waiting for a user who is trying to get this working on tc9.0 to be >> successful. >> >> If anyone else can confirm that thi

svn commit: r1847123 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 16:14:52 2018 New Revision: 1847123 URL: http://svn.apache.org/viewvc?rev=1847123&view=rev Log: Fix import order Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java Modified: tomcat/trunk/test/org/apache/catal

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Mark Thomas
On 21/11/2018 15:29, Christopher Schultz wrote: > All, > > With this last patch, I'm ready for a back-port to tc8.5.x, but I'm > waiting for a user who is trying to get this working on tc9.0 to be > successful. > > If anyone else can confirm that this is all working in a real cluster > (dev/test

svn commit: r1847119 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 15:36:51 2018 New Revision: 1847119 URL: http://svn.apache.org/viewvc?rev=1847119&view=rev Log: More false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.a

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, With this last patch, I'm ready for a back-port to tc8.5.x, but I'm waiting for a user who is trying to get this working on tc9.0 to be successful. If anyone else can confirm that this is all working in a real cluster (dev/test is okay) then I

svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread schultz
Author: schultz Date: Wed Nov 21 15:15:34 2018 New Revision: 1847118 URL: http://svn.apache.org/viewvc?rev=1847118&view=rev Log: Use random IVs for encryption. Support cipher block modes other than CBC. Expand unit tests. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/intercep

svn commit: r1847116 - /tomcat/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 15:01:34 2018 New Revision: 1847116 URL: http://svn.apache.org/viewvc?rev=1847116&view=rev Log: Simplify duplicated logic Reported by SpotBugs Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java Modified: tomcat/trunk/java/org/apache/tomcat/

svn commit: r1847114 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:58:18 2018 New Revision: 1847114 URL: http://svn.apache.org/viewvc?rev=1847114&view=rev Log: Remove some false positives from the results Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positive

svn commit: r1847109 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:16:18 2018 New Revision: 1847109 URL: http://svn.apache.org/viewvc?rev=1847109&view=rev Log: In theory it was possible that the lock would not be released. Reported by SpotBugs. Modified: tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java Mo

svn commit: r1847107 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:08:28 2018 New Revision: 1847107 URL: http://svn.apache.org/viewvc?rev=1847107&view=rev Log: Fix copy/paste error identified by SpotBugs Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java Modified: tomcat/trun

svn commit: r1847106 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/CGIServlet.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:06:47 2018 New Revision: 1847106 URL: http://svn.apache.org/viewvc?rev=1847106&view=rev Log: Use the trimmed value for the remainder of the method as originally intended. NO-OP code reported by SpotBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) t

svn commit: r1847105 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/CGIServlet.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:06:15 2018 New Revision: 1847105 URL: http://svn.apache.org/viewvc?rev=1847105&view=rev Log: Use the trimmed value for the remainder of the method as originally intended. NO-OP code reported by SpotBugs Modified: tomcat/tc8.5.x/trunk/ (props changed) t

svn commit: r1847104 - /tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:05:26 2018 New Revision: 1847104 URL: http://svn.apache.org/viewvc?rev=1847104&view=rev Log: Use the trimmed value for the remainder of the method as originally intended. NO-OP code reported by SpotBugs Modified: tomcat/trunk/java/org/apache/catalina/servlet

svn commit: r1847103 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:03:21 2018 New Revision: 1847103 URL: http://svn.apache.org/viewvc?rev=1847103&view=rev Log: No need for try/catch here as all Endpoint implementations support keepAliveCount Based on a report by SpotBugs Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1847102 - /tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 14:02:57 2018 New Revision: 1847102 URL: http://svn.apache.org/viewvc?rev=1847102&view=rev Log: No need for try/catch here as all Endpoint implementations support keepAliveCount Based on a report by SpotBugs Modified: tomcat/trunk/java/org/apache/catalina/manag

svn commit: r1847098 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationContext.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 13:50:04 2018 New Revision: 1847098 URL: http://svn.apache.org/viewvc?rev=1847098&view=rev Log: Remove unnecessary code reported by SpotBugs Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/ApplicationConte

svn commit: r1847097 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 13:49:22 2018 New Revision: 1847097 URL: http://svn.apache.org/viewvc?rev=1847097&view=rev Log: Remove unnecessary code reported by SpotBugs Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Modified: tomcat/trunk/java/org/apache/cata

[Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2018-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 --- Comment #12 from romain.manni-bucau --- Hi guys, isn't it possible to fix this issue since the space has this comment (org.apache.tomcat.util.http.parser.MediaType#toString): > // Workaround for Adobe Read 9 plug-in on IE bug > // Can be

Re: Parallel Classloader - Again

2018-11-21 Thread Mark Thomas
And which version of Java? See also comments below. On 20/11/2018 22:16, Mark Thomas wrote: > Which version of Tomcat are you using? > > Mark > > > On 20/11/2018 21:02, Andrew Carr wrote: >> Wait, I think I might see what I did, let me try again. >> >> Found one Java-level deadlock: >> ===

svn commit: r1847082 - in /tomcat/trunk: build.xml conf/catalina.properties res/maven/mvn-pub.xml res/maven/tomcat-i18n-ko.pom res/maven/tomcat-i18n-zh-CN.pom webapps/docs/changelog.xml

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 08:58:38 2018 New Revision: 1847082 URL: http://svn.apache.org/viewvc?rev=1847082&view=rev Log: Add simplified Chinese (currently 32% translated) and Korean (currently 10% translated) to the standard Tomcat distribution. Added: tomcat/trunk/res/maven/tomcat-i18

svn commit: r1847081 - /tomcat/trunk/webapps/docs/changelog.xml

2018-11-21 Thread markt
Author: markt Date: Wed Nov 21 08:46:50 2018 New Revision: 1847081 URL: http://svn.apache.org/viewvc?rev=1847081&view=rev Log: Update the changelog to include the updated list of translation contributors. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/c