[Bug 62799] mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets.

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62799 --- Comment #3 from Rainer Jung --- I assume you are on RHEL 6 or 7? The Red Hat article unfortunately doesn't state, which version of mod_jk it is for. The man pages for connect() tells us: === Cite === EINPROGRESS The

[Bug 62799] mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets.

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62799 --- Comment #2 from m...@blackmans.org --- Yes, it was set to 5000 milliseconds (i.e. 5 seconds). Well, we don't see this behaviour in Apache 2.2 with the prefork MPM and we do see it with Apache 2.4 in the event MPM. However, I can imagine tha

Re: Cloud clustering support using Kubernetes

2018-10-03 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/3/18 09:48, Rémy Maucherat wrote: > Hi, > > As I talked about during the latest TomcatCon (and the previous one > in London actually ...), there's a cloud aware cluster members > provider that can be contributed to Tomcat. > > The curr

svn commit: r1842760 [23/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews.html (original) +++ tomc

svn commit: r1842760 [29/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-7.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-7.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/security-7.html (original)

svn commit: r1842760 [31/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/svn.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/svn.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/svn.html (original) +++ tomcat/site/trun

svn commit: r1842760 [30/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-native.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-native.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/security-native.

svn commit: r1842760 [32/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/tomcat-60-eol.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tomcat-60-eol.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/tomcat-60-eol.html (

svn commit: r1842760 [28/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-6.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-6.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/security-6.html (original)

svn commit: r1842760 [27/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-5.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-5.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/security-5.html (original)

svn commit: r1842760 [25/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/resources.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/resources.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/resources.html (original) ++

svn commit: r1842760 [26/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-4.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-4.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/security-4.html (original)

svn commit: r1842760 [33/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/whichversion.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/whichversion.html (ori

svn commit: r1842760 [24/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/presentations.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/presentations.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/presentations.html (

svn commit: r1842760 [20/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2015.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2015.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2015.html (ori

svn commit: r1842760 [17/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2012.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2012.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2012.html (ori

svn commit: r1842760 [21/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2016.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2016.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2016.html (ori

svn commit: r1842760 [34/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/whoweare.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/whoweare.html (original) +++ t

svn commit: r1842760 [19/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2014.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2014.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2014.html (ori

svn commit: r1842760 [18/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2013.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2013.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2013.html (ori

svn commit: r1842760 [22/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2017.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2017.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2017.html (ori

svn commit: r1842760 [15/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2010.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2010.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2010.html (ori

svn commit: r1842760 [16/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2011.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2011.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/oldnews-2011.html (ori

svn commit: r1842760 [14/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/migration-9.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-9.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/migration-9.html (origin

svn commit: r1842760 [9/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/lists.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/lists.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/lists.html (original) +++ tomcat/sit

svn commit: r1842760 [13/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/migration-85.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-85.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/migration-85.html (ori

svn commit: r1842760 [6/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/download-native.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-native.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/download-native.

svn commit: r1842760 [8/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/irc.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/irc.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/irc.html (original) +++ tomcat/site/trun

svn commit: r1842760 [12/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/migration-8.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-8.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/migration-8.html (origin

svn commit: r1842760 [10/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/migration-6.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-6.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/migration-6.html (origin

svn commit: r1842760 [11/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/migration-7.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-7.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/migration-7.html (origin

svn commit: r1842760 [1/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 20:10:15 2018 New Revision: 1842760 URL: http://svn.apache.org/viewvc?rev=1842760&view=rev Log: Drop TomcatCon from the menu until we have form plans for the next event Modified: tomcat/site/trunk/docs/bugreport.html tomcat/site/trunk/docs/ci.html tomcat

svn commit: r1842760 [7/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/findhelp.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/findhelp.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/findhelp.html (original) +++ t

svn commit: r1842760 [3/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/conference.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/conference.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/conference.html (original)

svn commit: r1842760 [5/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/download-90.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-90.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/download-90.html (origin

svn commit: r1842760 [4/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/download-80.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/download-80.html (origin

svn commit: r1842760 [2/34] - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/ci.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/ci.html?rev=1842760&r1=1842759&r2=1842760&view=diff == --- tomcat/site/trunk/docs/ci.html (original) +++ tomcat/site/trunk/d

Re: [VOTE] Release JK 1.2.46

2018-10-03 Thread Mark Thomas
On 01/10/18 16:30, Mark Thomas wrote: > Tag: > http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_46/ > > Source: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ > > > This is a maintenance release with a handful of bug fixes (compared to > 1.2.44) and some clean-up. It als

svn propchange: r1840057 - svn:log

2018-10-03 Thread markt
Author: markt Revision: 1840057 Modified property: svn:log Modified: svn:log at Wed Oct 3 19:58:31 2018 -- --- svn:log (original) +++ svn:log Wed Oct 3 19:58:31 2018 @@ -1 +1,2 @@ When generating a redirect to a directo

svn propchange: r1840055 - svn:log

2018-10-03 Thread markt
Author: markt Revision: 1840055 Modified property: svn:log Modified: svn:log at Wed Oct 3 19:58:07 2018 -- --- svn:log (original) +++ svn:log Wed Oct 3 19:58:07 2018 @@ -1 +1,2 @@ When generating a redirect to a directo

svn propchange: r1840056 - svn:log

2018-10-03 Thread markt
Author: markt Revision: 1840056 Modified property: svn:log Modified: svn:log at Wed Oct 3 19:58:20 2018 -- --- svn:log (original) +++ svn:log Wed Oct 3 19:58:20 2018 @@ -1 +1,2 @@ When generating a redirect to a directo

[Bug 62799] mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets.

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62799 --- Comment #1 from Rainer Jung --- Hi Mark, just to make sure: did you notice that the unit of socket_connect_timeout is milliseconds, so did you set it to 5000? In version 1.2.44 it switched to seconds due to a regression which will be fixe

[SECURITY] CVE-2018-11784 Apache Tomcat - Open Redirect

2018-10-03 Thread Mark Thomas
CVE-2018-11784 Apache Tomcat - Open Redirect Severity: Moderate Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 9.0.0.M1 to 9.0.11 Apache Tomcat 8.5.0 to 8.5.33 Apache Tomcat 7.0.23 to 7.0.90 The unsupported 8.0.x release line has not been analysed but is likely to be aff

svn commit: r1842754 [3/5] - in /tomcat/site/trunk: docs/index.html docs/security-7.html docs/security-8.html docs/security-9.html xdocs/security-7.xml xdocs/security-8.xml xdocs/security-9.xml

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-8.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-8.html?rev=1842754&r1=1842753&r2=1842754&view=diff == --- tomcat/site/trunk/docs/security-8.html (original)

svn commit: r1842754 [5/5] - in /tomcat/site/trunk: docs/index.html docs/security-7.html docs/security-8.html docs/security-9.html xdocs/security-7.xml xdocs/security-8.xml xdocs/security-9.xml

2018-10-03 Thread markt
Modified: tomcat/site/trunk/xdocs/security-7.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-7.xml?rev=1842754&r1=1842753&r2=1842754&view=diff == --- tomcat/site/trunk/xdocs/security-7.xml (original)

svn commit: r1842754 [4/5] - in /tomcat/site/trunk: docs/index.html docs/security-7.html docs/security-8.html docs/security-9.html xdocs/security-7.xml xdocs/security-8.xml xdocs/security-9.xml

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-9.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-9.html?rev=1842754&r1=1842753&r2=1842754&view=diff == --- tomcat/site/trunk/docs/security-9.html (original)

svn commit: r1842754 [1/5] - in /tomcat/site/trunk: docs/index.html docs/security-7.html docs/security-8.html docs/security-9.html xdocs/security-7.xml xdocs/security-8.xml xdocs/security-9.xml

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 19:49:05 2018 New Revision: 1842754 URL: http://svn.apache.org/viewvc?rev=1842754&view=rev Log: Add details of CVE-2018-11784 Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/security-7.html tomcat/site/trunk/docs/security-8.html to

svn commit: r1842754 [2/5] - in /tomcat/site/trunk: docs/index.html docs/security-7.html docs/security-8.html docs/security-9.html xdocs/security-7.xml xdocs/security-8.xml xdocs/security-9.xml

2018-10-03 Thread markt
Modified: tomcat/site/trunk/docs/security-7.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-7.html?rev=1842754&r1=1842753&r2=1842754&view=diff == --- tomcat/site/trunk/docs/security-7.html (original)

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Igal Sapir
On 10/3/2018 12:05 PM, Mark Thomas wrote: [4] https://github.com/apache/tomcat/blob/trunk/test/org/apache/tomcat/util/net/TesterSupport.java#L196 That one I do think makes sense to pull into JrePlatform. I have moved [4] above in r1842748.  I used the existing convention in the file of setting

svn commit: r1842751 - /tomcat/trunk/java/org/apache/tomcat/util/compat/JrePlatform.java

2018-10-03 Thread isapir
Author: isapir Date: Wed Oct 3 19:19:17 2018 New Revision: 1842751 URL: http://svn.apache.org/viewvc?rev=1842751&view=rev Log: Inlined strings that are used only once Modified: tomcat/trunk/java/org/apache/tomcat/util/compat/JrePlatform.java Modified: tomcat/trunk/java/org/apache/tomcat/uti

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Mark Thomas
On 03/10/18 19:23, Igal Sapir wrote: > On 10/3/2018 4:41 AM, Mark Thomas wrote: [4] https://github.com/apache/tomcat/blob/trunk/test/org/apache/tomcat/util/net/TesterSupport.java#L196 >> That one I do think makes sense to pull into JrePlatform. > > I have moved [4] above in r1842

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Igal Sapir
On 10/3/2018 4:41 AM, Mark Thomas wrote: On 03/10/18 00:48, Igal Sapir wrote: Regarding this: On 10/2/2018 3:54 PM, Igal Sapir wrote: Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAM

svn commit: r1842748 - in /tomcat/trunk: java/org/apache/tomcat/util/compat/JrePlatform.java test/org/apache/tomcat/util/net/TesterSupport.java

2018-10-03 Thread isapir
Author: isapir Date: Wed Oct 3 18:16:35 2018 New Revision: 1842748 URL: http://svn.apache.org/viewvc?rev=1842748&view=rev Log: Moved check of isMacOs() to o.a.t.util.compat.JrePlatform Modified: tomcat/trunk/java/org/apache/tomcat/util/compat/JrePlatform.java tomcat/trunk/test/org/apache

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-03 Thread Igal Sapir
Chris, Thank you for the feedback: On 10/3/2018 10:01 AM, Christopher Schultz wrote: On 10/2/18 17:39, isa...@apache.org wrote: Author: isapir Date: Tue Oct 2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657&view=rev Log: Fixed test cases that errored due to

[Bug 62739] Tomcat should allow blank Host header

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 --- Comment #9 from Michael Orr --- Good question. Let me know how you want to proceed, and I'll add tests and code accordingly. -- You are receiving this mail because: You are the assignee for the bug. --

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 10/2/18 18:54, Igal Sapir wrote: > Rainer pointed out to me the class JrePlatform [1], which has a > helper field called IS_WINDOWS. > > I think that it would make sense to add a constant field OS_NAME, > as well as IS_LINUX and IS_MACOS,

Re: Bug 62140 implementation question

2018-10-03 Thread Mitch Claborn
My only thought was the single-source value. If it would be a lot of extra work to do the text file, then I think the original design is fine. Mitch On 10/02/2018 09:56 AM, Marek Czernek wrote: Well, I personally would prefer if it was  a soure-able (or call-able for windows) script; otherwi

[Bug 62739] Tomcat should allow blank Host header

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 --- Comment #8 from Mark Thomas --- Patch looks good - thanks for including the tests. My main thought at this point is what should HttpServletRequest.getServerName() return? My reading of the Javadoc is if the Host header is present, its valu

Re: Cloud clustering support using Kubernetes

2018-10-03 Thread Rémy Maucherat
On Wed, Oct 3, 2018 at 4:35 PM Mark Thomas wrote: > On 03/10/18 14:48, Rémy Maucherat wrote: > > Hi, > > > > As I talked about during the latest TomcatCon (and the previous one in > > London actually ...), there's a cloud aware cluster members provider that > > can be contributed to Tomcat. > > >

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1842729 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/JspRuntimeContext.java java/org/apache/jasper/compiler/TagFileProcessor.java java/org/apache/jasper/servlet/JspServl

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 14:38:14 2018 New Revision: 1842729 URL: http://svn.apache.org/viewvc?rev=1842729&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Correct a regression in the fix for bug 62603 that caused NullPointerExceptions when compiling tag files on first

Re: Cloud clustering support using Kubernetes

2018-10-03 Thread Mark Thomas
On 03/10/18 14:48, Rémy Maucherat wrote: > Hi, > > As I talked about during the latest TomcatCon (and the previous one in > London actually ...), there's a cloud aware cluster members provider that > can be contributed to Tomcat. > > The current code is here: https://github.com/rmaucher/tomcat-in

svn commit: r1842726 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/jasper/compiler/JspRuntimeContext.java java/org/apache/jasper/compiler/TagFileProcessor.java java/org/apache/jasper/servlet/JspServl

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 14:11:02 2018 New Revision: 1842726 URL: http://svn.apache.org/viewvc?rev=1842726&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Correct a regression in the fix for bug 62603 that caused NullPointerExceptions when compiling tag files on first

svn commit: r1842725 - in /tomcat/trunk: java/org/apache/jasper/compiler/JspRuntimeContext.java java/org/apache/jasper/compiler/TagFileProcessor.java java/org/apache/jasper/servlet/JspServletWrapper.j

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 14:03:51 2018 New Revision: 1842725 URL: http://svn.apache.org/viewvc?rev=1842725&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Correct a regression in the fix for bug 62603 that caused NullPointerExceptions when compiling tag files on first

Cloud clustering support using Kubernetes

2018-10-03 Thread Rémy Maucherat
Hi, As I talked about during the latest TomcatCon (and the previous one in London actually ...), there's a cloud aware cluster members provider that can be contributed to Tomcat. The current code is here: https://github.com/rmaucher/tomcat-in-the-cloud It uses Kubernetes to retrieve the members o

[Bug 62799] New: mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets.

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62799 Bug ID: 62799 Summary: mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets. Product: Tomcat Connectors Version: 1.2.42 Hardware: All

[Bug 62798] Apache failed to initialize connector

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62798 --- Comment #4 from Gaël REYNOARD --- Thank you for your reply I opened a message on the User list and I continue to do tests on my side to try to understand why I have this exception. What bothers me in this error is the fact that NETSTAT sys

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Jordi Llach changed: What|Removed |Added OS|Mac OS X 10.1 |All Hardware|PC

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 Jordi Llach changed: What|Removed |Added Version|8.5.34 |8.5.33 Severity|normal

[Bug 62798] Apache failed to initialize connector

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62798 --- Comment #3 from Remy Maucherat --- Maybe it's a bug somewhere in your situation, but given the exception is "Caused by: java.net.BindException: Address already in use: bind", it's supposed to be a port already bound and we won't take any fu

[Bug 62739] Tomcat should allow blank Host header

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 --- Comment #7 from Mark Thomas --- Thanks. Looking at this now. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsub

svn commit: r1842706 - /tomcat/trunk/java/org/apache/tomcat/util/compat/TLS.java

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 11:42:09 2018 New Revision: 1842706 URL: http://svn.apache.org/viewvc?rev=1842706&view=rev Log: Fix IDE nag (unused variable) Modified: tomcat/trunk/java/org/apache/tomcat/util/compat/TLS.java Modified: tomcat/trunk/java/org/apache/tomcat/util/compat/TLS.java U

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Mark Thomas
On 03/10/18 00:48, Igal Sapir wrote: > Regarding this: > > On 10/2/2018 3:54 PM, Igal Sapir wrote: >> Rainer pointed out to me the class JrePlatform [1], which has a helper >> field called IS_WINDOWS. >> >> I think that it would make sense to add a constant field OS_NAME, as >> well as IS_LINUX an

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-03 Thread Mark Thomas
On 03/10/18 11:17, Mark Thomas wrote: > On 02/10/18 22:39, isa...@apache.org wrote: >> Author: isapir >> Date: Tue Oct 2 21:39:57 2018 >> New Revision: 1842657 >> >> URL: http://svn.apache.org/viewvc?rev=1842657&view=rev >> Log: >> Fixed test cases that errored due to path case sentsitivity on Win

svn commit: r1842705 - in /tomcat/trunk/test/org/apache/catalina/webresources: TestAbstractArchiveResource.java TestFileResource.java

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 11:26:43 2018 New Revision: 1842705 URL: http://svn.apache.org/viewvc?rev=1842705&view=rev Log: Alternative fix for case sensitivity issue. Resource URLs are generated from canonical file paths so the expected paths need to be canonical as well. Modified: tomc

svn commit: r1842704 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 11:18:55 2018 New Revision: 1842704 URL: http://svn.apache.org/viewvc?rev=1842704&view=rev Log: Ensure that a canonical path is always used for the docBase of a Context to ensure consistent behaviour. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat

svn commit: r1842703 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 11:17:17 2018 New Revision: 1842703 URL: http://svn.apache.org/viewvc?rev=1842703&view=rev Log: Ensure that a canonical path is always used for the docBase of a Context to ensure consistent behaviour. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat

svn commit: r1842702 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 11:16:07 2018 New Revision: 1842702 URL: http://svn.apache.org/viewvc?rev=1842702&view=rev Log: Ensure that a canonical path is always used for the docBase of a Context to ensure consistent behaviour. Modified: tomcat/trunk/java/org/apache/catalina/startup/Cont

svn commit: r1842701 - /tomcat/trunk/webapps/docs/changelog.xml

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 11:03:36 2018 New Revision: 1842701 URL: http://svn.apache.org/viewvc?rev=1842701&view=rev Log: Line length Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webap

[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757 --- Comment #9 from Jordi Llach --- The way you've solved the issue in JspServletWrapper's loadTagFile method by checking whether tagHandlerClass is null (in the second synchronized block) is better than mine. Also, removing firstTime from Jsp

[Bug 62798] Apache failed to initialize connector

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62798 --- Comment #2 from Gaël REYNOARD --- (In reply to Mark Thomas from comment #1) > Tomcat has not been shutdown fully. Either because enough time has not been > allowed for the shutdown process to complete or because a bug in a web > application

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-03 Thread Mark Thomas
On 02/10/18 22:39, isa...@apache.org wrote: > Author: isapir > Date: Tue Oct 2 21:39:57 2018 > New Revision: 1842657 > > URL: http://svn.apache.org/viewvc?rev=1842657&view=rev > Log: > Fixed test cases that errored due to path case sentsitivity on Windows This looks to be addressing the symptom

[Bug 62798] Apache failed to initialize connector

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62798 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: SSL Unit Tests Failing

2018-10-03 Thread Mark Thomas
On 02/10/18 20:40, Igal Sapir wrote: > Mark / Chris, > > On 10/2/2018 6:36 AM, Mark Thomas wrote: >> On 02/10/18 06:58, Igal Sapir wrote: >>> When trying to run the unit test cases with `ant clean test` on the >>> current >>> trunk [1] I am getting two (per connector) failures: >>> >>> org.ap

[Bug 62798] New: Apache failed to initialize connector

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62798 Bug ID: 62798 Summary: Apache failed to initialize connector Product: Tomcat 8 Version: 8.5.31 Hardware: PC Status: NEW Severity: normal Priority: P2

svn commit: r1842694 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 09:12:15 2018 New Revision: 1842694 URL: http://svn.apache.org/viewvc?rev=1842694&view=rev Log: Fix failing tests when testing against OpenSSL 1.1.0. The ARIA ciphers were introduced in 1.1.1, not 1.1.0. Modified: tomcat/tc8.5.x/trunk/ (props changed) tom

svn commit: r1842693 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TestCipher.java

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 09:10:43 2018 New Revision: 1842693 URL: http://svn.apache.org/viewvc?rev=1842693&view=rev Log: Whitespace only Align with 8.5.x Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TestCipher.java Modified: tomcat/trunk/test/org/apache/tomca

svn commit: r1842692 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 09:07:15 2018 New Revision: 1842692 URL: http://svn.apache.org/viewvc?rev=1842692&view=rev Log: Back-port fix from trunk that is required by Gump so the required OpenSSL libraries are on the path. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc

svn commit: r1842691 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java

2018-10-03 Thread markt
Author: markt Date: Wed Oct 3 08:56:54 2018 New Revision: 1842691 URL: http://svn.apache.org/viewvc?rev=1842691&view=rev Log: Fix failing tests when testing against OpenSSL 1.1.0. The ARIA ciphers were introduced in 1.1.1, not 1.1.0. Modified: tomcat/trunk/test/org/apache/tomcat/util/net/op

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-10-03 Thread Bill Barker
jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20181003.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPS

Re: [GUMP@vmgump-vm3]: Project tomcat-native-1.2-1.1.1-configure (in module tomcat-native-1.2-1.1.1) failed

2018-10-03 Thread Mark Thomas
; and/or contact the folk at gene...@gump.apache.org. >> >> Project tomcat-native-1.2-1.1.1-configure has an issue affecting its >> community integration. > > > >> checking for OpenSSL library... using openssl from >> /srv/gump/public/workspace/openssl-1.1.1/des

Re: [GUMP@vmgump-vm3]: Project tomcat-native-1.2-1.1.1-configure (in module tomcat-native-1.2-1.1.1) failed

2018-10-03 Thread Mark Thomas
ect tomcat-native-1.2-1.1.1-configure has an issue affecting its > community integration. > checking for OpenSSL library... using openssl from > /srv/gump/public/workspace/openssl-1.1.1/dest-20181003/${exec_prefix}/lib and > /srv/gump/public/workspace/openssl-1.1.1/dest-20181003/i

[Bug 62739] Tomcat should allow blank Host header

2018-10-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 --- Comment #6 from Michael Orr --- I managed to find time after all! Here's the pull request: https://github.com/apache/tomcat/pull/124 -- You are receiving this mail because: You are the assignee for the bug. --

[GitHub] tomcat pull request #124: Allow empty 'Host' HTTP header

2018-10-03 Thread michaelomichael
GitHub user michaelomichael opened a pull request: https://github.com/apache/tomcat/pull/124 Allow empty 'Host' HTTP header Sending an empty string for the value of the 'Host' header no longer results in a 400 (Bad Request) response. This new behaviour reflects RFC 7230 and